diff mbox series

[2/3] i2c: qup: Remove dev_err() log after platform_get_irq*() failure

Message ID 20190916185857.GA14093@SD
State Superseded
Headers show
Series Fix issues reported by Coccinelle | expand

Commit Message

Saiyam Doshi Sept. 16, 2019, 6:58 p.m. UTC 
The debug message after platform_get_irq() failure is redundant
because platform_get_irq() already prints an error. Thus remove it.

The semantic patch that makes this report is available
in scripts/coccinelle/api/platform_get_irq.cocci.

Found using - http://coccinelle.lip6.fr/

Signed-off-by: Saiyam Doshi <saiyamdoshi.in@gmail.com>
---
 drivers/i2c/busses/i2c-qup.c | 1 -
 1 file changed, 1 deletion(-)

--
2.20.1

Comments

Markus Elfring Sept. 17, 2019, 3:28 p.m. UTC | #1 
> The semantic patch that makes this report is available
> in scripts/coccinelle/api/platform_get_irq.cocci.
>
> Found using - http://coccinelle.lip6.fr/

Can a tag like “Generated by: scripts/coccinelle/api/platform_get_irq.cocci”
be more helpful than the other description variant?


> +++ b/drivers/i2c/busses/i2c-qup.c
> @@ -1767,7 +1767,6 @@ static int qup_i2c_probe(struct platform_device *pdev)
>
>  	qup->irq = platform_get_irq(pdev, 0);
>  	if (qup->irq < 0) {
> -		dev_err(qup->dev, "No IRQ defined\n");
>  		return qup->irq;
>  	}

How do you think about to omit the curly brackets here after only a single
statement would be used in the if branch?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?id=ad062195731bea1624ce7160e79e0fcdaa25c1b5#n175

Regards,
Markus
Saiyam Doshi Sept. 17, 2019, 4:25 p.m. UTC | #2 
On Tue, Sep 17, 2019 at 05:28:47PM +0200, Markus Elfring wrote:
> > The semantic patch that makes this report is available
> > in scripts/coccinelle/api/platform_get_irq.cocci.
> >
> > Found using - http://coccinelle.lip6.fr/
> 
> Can a tag like “Generated by: scripts/coccinelle/api/platform_get_irq.cocci”
> be more helpful than the other description variant?
Okay, will update the changelog.

> >  	if (qup->irq < 0) {
> > -		dev_err(qup->dev, "No IRQ defined\n");
> >  		return qup->irq;
> >  	}
> How do you think about to omit the curly brackets here after only a single
> statement would be used in the if branch?
Completely missed that! I will update and resend.

-Saiyam
diff mbox series

Patch

diff --git a/drivers/i2c/busses/i2c-qup.c b/drivers/i2c/busses/i2c-qup.c
index 5519c19bfd9c..23c4893512b2 100644
--- a/drivers/i2c/busses/i2c-qup.c
+++ b/drivers/i2c/busses/i2c-qup.c
@@ -1767,7 +1767,6 @@  static int qup_i2c_probe(struct platform_device *pdev)

 	qup->irq = platform_get_irq(pdev, 0);
 	if (qup->irq < 0) {
-		dev_err(qup->dev, "No IRQ defined\n");
 		return qup->irq;
 	}