| Message ID | 20190822063156.4000-1-ganeshgr@linux.ibm.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | powerpc: dump kernel log before carrying out fadump or kdump | expand |
| Context | Check | Description |
|---|---|---|
| snowpatch_ozlabs/apply_patch | success | Successfully applied on branch next (0e4523c0b4f64eaf7abe59e143e6bdf8f972acff) |
| snowpatch_ozlabs/build-ppc64le | success | Build succeeded |
| snowpatch_ozlabs/build-ppc64be | success | Build succeeded |
| snowpatch_ozlabs/build-ppc64e | success | Build succeeded |
| snowpatch_ozlabs/build-pmac32 | success | Build succeeded |
| snowpatch_ozlabs/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 7 lines checked |
Ganesh Goudar's on August 22, 2019 4:31 pm: > Die or panic path in system reset handler dumps kernel log to > nvram, since commit 4388c9b3a6ee ("powerpc: Do not send system > reset request through the oops path") system reset request is > not allowed to take die path if fadump or kdump is configured, > hence we miss dumping kernel log to nvram, call kmsg_dump() > before carrying out fadump or kdump. > > Fixes: 4388c9b3a6ee ("powerpc: Do not send system reset request through the oops path") > Reviewed-by: Mahesh Salgaonkar <mahesh@linux.vnet.ibm.com> > Signed-off-by: Ganesh Goudar <ganeshgr@linux.ibm.com> Reviewed-by: Nicholas Piggin <npiggin@gmail.com>
diff --git a/arch/powerpc/kernel/traps.c b/arch/powerpc/kernel/traps.c index 11caa0291254..82f43535e686 100644 --- a/arch/powerpc/kernel/traps.c +++ b/arch/powerpc/kernel/traps.c @@ -472,6 +472,7 @@ void system_reset_exception(struct pt_regs *regs) if (debugger(regs)) goto out; + kmsg_dump(KMSG_DUMP_OOPS); /* * A system reset is a request to dump, so we always send * it through the crashdump code (if fadump or kdump are
Die or panic path in system reset handler dumps kernel log to nvram, since commit 4388c9b3a6ee ("powerpc: Do not send system reset request through the oops path") system reset request is not allowed to take die path if fadump or kdump is configured, hence we miss dumping kernel log to nvram, call kmsg_dump() before carrying out fadump or kdump. Fixes: 4388c9b3a6ee ("powerpc: Do not send system reset request through the oops path") Reviewed-by: Mahesh Salgaonkar <mahesh@linux.vnet.ibm.com> Signed-off-by: Ganesh Goudar <ganeshgr@linux.ibm.com> --- arch/powerpc/kernel/traps.c | 1 + 1 file changed, 1 insertion(+)