diff mbox series

[U-Boot,v1,2/2] apalis_imx6: use distroboot by default

Message ID 20190823170049.23870-2-igor.opaniuk@gmail.com
State Accepted
Commit d73c520327b2ae337efc0d557fd45a1b7010da17
Delegated to: Stefano Babic
Headers show
Series [U-Boot,v1,1/2] colibri_imx6/imx7/imx8x: use distroboot by default | expand

Commit Message

Igor Opaniuk Aug. 23, 2019, 5 p.m. UTC 
From: Igor Opaniuk <igor.opaniuk@toradex.com>

Use distro_bootcmd as defauult bootcmd instead of legacy wrappers.

Signed-off-by: Igor Opaniuk <igor.opaniuk@toradex.com>
---

 include/configs/apalis_imx6.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Oleksandr Suvorov Aug. 27, 2019, 9:31 a.m. UTC | #1 
On Fri, Aug 23, 2019 at 8:01 PM Igor Opaniuk <igor.opaniuk@gmail.com> wrote:
>
> From: Igor Opaniuk <igor.opaniuk@toradex.com>
>
> Use distro_bootcmd as defauult bootcmd instead of legacy wrappers.
>
> Signed-off-by: Igor Opaniuk <igor.opaniuk@toradex.com>

In general:
Reviewed-by: Oleksandr Suvorov <oleksandr.suvorov@toradex.com>

But if you will push a new version, please fix the typo in comment msg:
s/defauult/default/

> ---
>
>  include/configs/apalis_imx6.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/configs/apalis_imx6.h b/include/configs/apalis_imx6.h
> index 974571df43..736ebb60ce 100644
> --- a/include/configs/apalis_imx6.h
> +++ b/include/configs/apalis_imx6.h
> @@ -102,6 +102,7 @@
>
>  #ifndef CONFIG_SPL_BUILD
>  #define BOOT_TARGET_DEVICES(func) \
> +       func(MMC, mmc, 0) \
>         func(MMC, mmc, 1) \
>         func(MMC, mmc, 2) \
>         func(USB, usb, 0) \
> @@ -184,8 +185,7 @@
>  #endif
>  #define CONFIG_EXTRA_ENV_SETTINGS \
>         BOOTENV \
> -       "bootcmd=run emmcboot ; echo ; echo emmcboot failed ; " \
> -               "setenv fdtfile ${fdt_file}; run distro_bootcmd ; " \
> +       "bootcmd=setenv fdtfile ${fdt_file}; run distro_bootcmd ; " \
>                 "usb start ; " \
>                 "setenv stdout serial,vga ; setenv stdin serial,usbkbd\0" \
>         "boot_file=zImage\0" \
> --
> 2.17.1
>
> _______________________________________________
> U-Boot mailing list
> U-Boot@lists.denx.de
> https://lists.denx.de/listinfo/u-boot
diff mbox series

Patch

diff --git a/include/configs/apalis_imx6.h b/include/configs/apalis_imx6.h
index 974571df43..736ebb60ce 100644
--- a/include/configs/apalis_imx6.h
+++ b/include/configs/apalis_imx6.h
@@ -102,6 +102,7 @@ 
 
 #ifndef CONFIG_SPL_BUILD
 #define BOOT_TARGET_DEVICES(func) \
+	func(MMC, mmc, 0) \
 	func(MMC, mmc, 1) \
 	func(MMC, mmc, 2) \
 	func(USB, usb, 0) \
@@ -184,8 +185,7 @@ 
 #endif
 #define CONFIG_EXTRA_ENV_SETTINGS \
 	BOOTENV \
-	"bootcmd=run emmcboot ; echo ; echo emmcboot failed ; " \
-		"setenv fdtfile ${fdt_file}; run distro_bootcmd ; " \
+	"bootcmd=setenv fdtfile ${fdt_file}; run distro_bootcmd ; " \
 		"usb start ; " \
 		"setenv stdout serial,vga ; setenv stdin serial,usbkbd\0" \
 	"boot_file=zImage\0" \