| Message ID | 20190724173538.22913-2-joseph.kogut@gmail.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | Add Buildroot toolchain support for LLD | expand |
Hi Joseph, Le 24/07/2019 à 19:35, Joseph Kogut a écrit : > Signed-off-by: Joseph Kogut <joseph.kogut@gmail.com> > --- > package/llvm/llvm.mk | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/package/llvm/llvm.mk b/package/llvm/llvm.mk > index 3c62285188..11c8d90af0 100644 > --- a/package/llvm/llvm.mk > +++ b/package/llvm/llvm.mk > @@ -184,7 +184,8 @@ LLVM_CONF_OPTS += -DLLVM_HOST_TRIPLE=$(GNU_TARGET_NAME) > # check preventively. Building the Go and OCaml bindings is yet unsupported. > HOST_LLVM_CONF_OPTS += \ > -DGO_EXECUTABLE=GO_EXECUTABLE-NOTFOUND \ > - -DOCAMLFIND=OCAMLFIND-NOTFOUND > + -DOCAMLFIND=OCAMLFIND-NOTFOUND \ > + -DLLVM_ENABLE_BINDINGS=OFF With LLVM_ENABLE_BINDINGS=OFF, you should be able to remove GO_EXECUTABLE and DOCAMLFIND Best regards, Romain > > # Builds a release host tablegen that gets used during the LLVM build. > HOST_LLVM_CONF_OPTS += -DLLVM_OPTIMIZED_TABLEGEN=ON >
On 24/07/2019 19:35, Joseph Kogut wrote: > Signed-off-by: Joseph Kogut <joseph.kogut@gmail.com> Can you explain why this is needed/wanted? Regards, Arnout > --- > package/llvm/llvm.mk | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/package/llvm/llvm.mk b/package/llvm/llvm.mk > index 3c62285188..11c8d90af0 100644 > --- a/package/llvm/llvm.mk > +++ b/package/llvm/llvm.mk > @@ -184,7 +184,8 @@ LLVM_CONF_OPTS += -DLLVM_HOST_TRIPLE=$(GNU_TARGET_NAME) > # check preventively. Building the Go and OCaml bindings is yet unsupported. > HOST_LLVM_CONF_OPTS += \ > -DGO_EXECUTABLE=GO_EXECUTABLE-NOTFOUND \ > - -DOCAMLFIND=OCAMLFIND-NOTFOUND > + -DOCAMLFIND=OCAMLFIND-NOTFOUND \ > + -DLLVM_ENABLE_BINDINGS=OFF > > # Builds a release host tablegen that gets used during the LLVM build. > HOST_LLVM_CONF_OPTS += -DLLVM_OPTIMIZED_TABLEGEN=ON >
On Sat, Oct 19, 2019 at 3:47 PM Arnout Vandecappelle <arnout@mind.be> wrote: > > > > On 24/07/2019 19:35, Joseph Kogut wrote: > > Signed-off-by: Joseph Kogut <joseph.kogut@gmail.com> > > Can you explain why this is needed/wanted? > > Regards, > Arnout > Nope. This commit was a while ago, and when I was working on this feature, I found that certain bindings were still enabled which caused a build failure. I researched the configure flags for LLVM, and found this one. Enabling it fixed the build, so I added it. It's very possible the enabling of this flag obviates the need for the priors. If that's the case, I would of course support removing the unneeded flags. Best, Joseph
diff --git a/package/llvm/llvm.mk b/package/llvm/llvm.mk index 3c62285188..11c8d90af0 100644 --- a/package/llvm/llvm.mk +++ b/package/llvm/llvm.mk @@ -184,7 +184,8 @@ LLVM_CONF_OPTS += -DLLVM_HOST_TRIPLE=$(GNU_TARGET_NAME) # check preventively. Building the Go and OCaml bindings is yet unsupported. HOST_LLVM_CONF_OPTS += \ -DGO_EXECUTABLE=GO_EXECUTABLE-NOTFOUND \ - -DOCAMLFIND=OCAMLFIND-NOTFOUND + -DOCAMLFIND=OCAMLFIND-NOTFOUND \ + -DLLVM_ENABLE_BINDINGS=OFF # Builds a release host tablegen that gets used during the LLVM build. HOST_LLVM_CONF_OPTS += -DLLVM_OPTIMIZED_TABLEGEN=ON
Signed-off-by: Joseph Kogut <joseph.kogut@gmail.com> --- package/llvm/llvm.mk | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)