| Message ID | 20190510081546.17982-1-luca@lucaceresoli.net |
|---|---|
| State | Superseded |
| Delegated to: | Michal Simek |
| Headers | show |
| Series | [U-Boot,1/3] arm64: zynqmp: xil_io.h: declare functions asstatic | expand |
On 10. 05. 19 10:15, Luca Ceresoli wrote: > Fixes chekcpatch warnings when building zynqmp defconfigs: it is not checkpatch who reports this. It is sparse. > ./board/xilinx/zynqmp/xil_io.h:12:6: warning: symbol 'Xil_Out32' was not declared. Should it be static? > ./board/xilinx/zynqmp/xil_io.h:17:5: warning: symbol 'Xil_In32' was not declared. Should it be static? > ./board/xilinx/zynqmp/xil_io.h:22:6: warning: symbol 'usleep' was not declared. Should it be static? > > Also add __maybe_unused to usleep() since it is not used by minimized > psu_init_gpl.c files, so it would warn as "defined but not used". > > Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net> > --- > board/xilinx/zynqmp/xil_io.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/board/xilinx/zynqmp/xil_io.h b/board/xilinx/zynqmp/xil_io.h > index c476c902ebcb..1c1bf32adaae 100644 > --- a/board/xilinx/zynqmp/xil_io.h > +++ b/board/xilinx/zynqmp/xil_io.h > @@ -9,17 +9,17 @@ > > #define xil_printf(...) > > -void Xil_Out32(unsigned long addr, unsigned long val) > +static void Xil_Out32(unsigned long addr, unsigned long val) > { > writel(val, addr); > } > > -int Xil_In32(unsigned long addr) > +static int Xil_In32(unsigned long addr) > { > return readl(addr); > } > > -void usleep(u32 sleep) > +static void __maybe_unused usleep(u32 sleep) > { > udelay(sleep); > } > The rest looks good. Thanks, Michal
Hi, On 22/05/19 13:26, Michal Simek wrote: > On 10. 05. 19 10:15, Luca Ceresoli wrote: >> Fixes chekcpatch warnings when building zynqmp defconfigs: > > it is not checkpatch who reports this. It is sparse. Good catch, will fix.
diff --git a/board/xilinx/zynqmp/xil_io.h b/board/xilinx/zynqmp/xil_io.h index c476c902ebcb..1c1bf32adaae 100644 --- a/board/xilinx/zynqmp/xil_io.h +++ b/board/xilinx/zynqmp/xil_io.h @@ -9,17 +9,17 @@ #define xil_printf(...) -void Xil_Out32(unsigned long addr, unsigned long val) +static void Xil_Out32(unsigned long addr, unsigned long val) { writel(val, addr); } -int Xil_In32(unsigned long addr) +static int Xil_In32(unsigned long addr) { return readl(addr); } -void usleep(u32 sleep) +static void __maybe_unused usleep(u32 sleep) { udelay(sleep); }
Fixes chekcpatch warnings when building zynqmp defconfigs: ./board/xilinx/zynqmp/xil_io.h:12:6: warning: symbol 'Xil_Out32' was not declared. Should it be static? ./board/xilinx/zynqmp/xil_io.h:17:5: warning: symbol 'Xil_In32' was not declared. Should it be static? ./board/xilinx/zynqmp/xil_io.h:22:6: warning: symbol 'usleep' was not declared. Should it be static? Also add __maybe_unused to usleep() since it is not used by minimized psu_init_gpl.c files, so it would warn as "defined but not used". Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net> --- board/xilinx/zynqmp/xil_io.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)