| Message ID | 20190415083605.32138-1-fontaine.fabrice@gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [1/1] package/busybox: fix S0{1sys, 2k}logd indentation | expand |
What’s wrong with the current indentation? (Sorry for the top-posting. Answering from the phone). Em 15 de abr de 2019, à(s) 05:36, Fabrice Fontaine <fontaine.fabrice@gmail.com> escreveu: > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> > --- > package/busybox/S01syslogd | 8 ++++---- > package/busybox/S02klogd | 8 ++++---- > 2 files changed, 8 insertions(+), 8 deletions(-) > > diff --git a/package/busybox/S01syslogd b/package/busybox/S01syslogd > index 6e642a678a..15006bc06f 100644 > --- a/package/busybox/S01syslogd > +++ b/package/busybox/S01syslogd > @@ -44,12 +44,12 @@ restart() { > } > > case "$1" in > - start|stop|restart) > + start|stop|restart) > "$1";; > reload) > # Restart, since there is no true "reload" feature. > restart;; > - *) > - echo "Usage: $0 {start|stop|restart|reload}" > - exit 1 > + *) > + echo "Usage: $0 {start|stop|restart|reload}" > + exit 1 > esac > diff --git a/package/busybox/S02klogd b/package/busybox/S02klogd > index a4200cfb34..0677e1e5ca 100644 > --- a/package/busybox/S02klogd > +++ b/package/busybox/S02klogd > @@ -44,12 +44,12 @@ restart() { > } > > case "$1" in > - start|stop|restart) > + start|stop|restart) > "$1";; > reload) > # Restart, since there is no true "reload" feature. > restart;; > - *) > - echo "Usage: $0 {start|stop|restart|reload}" > - exit 1 > + *) > + echo "Usage: $0 {start|stop|restart|reload}" > + exit 1 > esac > -- > 2.20.1 >
Hello Carlos, Le lun. 15 avr. 2019 à 12:36, Carlos Santos <unixmania@gmail.com> a écrit : > > What’s wrong with the current indentation? Current file indentation is mixing spaces with tabs. I removed spaces to use only tabs. > > (Sorry for the top-posting. Answering from the phone). > > Em 15 de abr de 2019, à(s) 05:36, Fabrice Fontaine <fontaine.fabrice@gmail.com> escreveu: > > > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> > > --- > > package/busybox/S01syslogd | 8 ++++---- > > package/busybox/S02klogd | 8 ++++---- > > 2 files changed, 8 insertions(+), 8 deletions(-) > > > > diff --git a/package/busybox/S01syslogd b/package/busybox/S01syslogd > > index 6e642a678a..15006bc06f 100644 > > --- a/package/busybox/S01syslogd > > +++ b/package/busybox/S01syslogd > > @@ -44,12 +44,12 @@ restart() { > > } > > > > case "$1" in > > - start|stop|restart) > > + start|stop|restart) > > "$1";; > > reload) > > # Restart, since there is no true "reload" feature. > > restart;; > > - *) > > - echo "Usage: $0 {start|stop|restart|reload}" > > - exit 1 > > + *) > > + echo "Usage: $0 {start|stop|restart|reload}" > > + exit 1 > > esac > > diff --git a/package/busybox/S02klogd b/package/busybox/S02klogd > > index a4200cfb34..0677e1e5ca 100644 > > --- a/package/busybox/S02klogd > > +++ b/package/busybox/S02klogd > > @@ -44,12 +44,12 @@ restart() { > > } > > > > case "$1" in > > - start|stop|restart) > > + start|stop|restart) > > "$1";; > > reload) > > # Restart, since there is no true "reload" feature. > > restart;; > > - *) > > - echo "Usage: $0 {start|stop|restart|reload}" > > - exit 1 > > + *) > > + echo "Usage: $0 {start|stop|restart|reload}" > > + exit 1 > > esac > > -- > > 2.20.1 > > Best Regards, Fabrice
On 15/04/2019 10:36, Fabrice Fontaine wrote: > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> Applied to master, thanks. Note that the other init scripts that were updated by Carlos have the same issue (copy&paste, I guess): package/rsyslog/S01rsyslogd package/sysklogd/S01syslogd package/sysklogd/S02klogd package/syslog-ng/S01syslog-ng Regards, Arnout > --- > package/busybox/S01syslogd | 8 ++++---- > package/busybox/S02klogd | 8 ++++---- > 2 files changed, 8 insertions(+), 8 deletions(-) > > diff --git a/package/busybox/S01syslogd b/package/busybox/S01syslogd > index 6e642a678a..15006bc06f 100644 > --- a/package/busybox/S01syslogd > +++ b/package/busybox/S01syslogd > @@ -44,12 +44,12 @@ restart() { > } > > case "$1" in > - start|stop|restart) > + start|stop|restart) > "$1";; > reload) > # Restart, since there is no true "reload" feature. > restart;; > - *) > - echo "Usage: $0 {start|stop|restart|reload}" > - exit 1 > + *) > + echo "Usage: $0 {start|stop|restart|reload}" > + exit 1 > esac > diff --git a/package/busybox/S02klogd b/package/busybox/S02klogd > index a4200cfb34..0677e1e5ca 100644 > --- a/package/busybox/S02klogd > +++ b/package/busybox/S02klogd > @@ -44,12 +44,12 @@ restart() { > } > > case "$1" in > - start|stop|restart) > + start|stop|restart) > "$1";; > reload) > # Restart, since there is no true "reload" feature. > restart;; > - *) > - echo "Usage: $0 {start|stop|restart|reload}" > - exit 1 > + *) > + echo "Usage: $0 {start|stop|restart|reload}" > + exit 1 > esac >
>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes: > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> Committed to 2019.02.x, thanks.
diff --git a/package/busybox/S01syslogd b/package/busybox/S01syslogd index 6e642a678a..15006bc06f 100644 --- a/package/busybox/S01syslogd +++ b/package/busybox/S01syslogd @@ -44,12 +44,12 @@ restart() { } case "$1" in - start|stop|restart) + start|stop|restart) "$1";; reload) # Restart, since there is no true "reload" feature. restart;; - *) - echo "Usage: $0 {start|stop|restart|reload}" - exit 1 + *) + echo "Usage: $0 {start|stop|restart|reload}" + exit 1 esac diff --git a/package/busybox/S02klogd b/package/busybox/S02klogd index a4200cfb34..0677e1e5ca 100644 --- a/package/busybox/S02klogd +++ b/package/busybox/S02klogd @@ -44,12 +44,12 @@ restart() { } case "$1" in - start|stop|restart) + start|stop|restart) "$1";; reload) # Restart, since there is no true "reload" feature. restart;; - *) - echo "Usage: $0 {start|stop|restart|reload}" - exit 1 + *) + echo "Usage: $0 {start|stop|restart|reload}" + exit 1 esac
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> --- package/busybox/S01syslogd | 8 ++++---- package/busybox/S02klogd | 8 ++++---- 2 files changed, 8 insertions(+), 8 deletions(-)