| Message ID | 20190115101548.16270-1-juergh@canonical.com |
|---|---|
| State | New |
| Headers | show |
| Series | [SRU,Cosmic] tools/kvm_stat: switch to python3 | expand |
On 15.01.19 11:15, Juerg Haefliger wrote: > From: Stefan Raspl <stefan.raspl@de.ibm.com> > > BugLink: https://bugs.launchpad.net/bugs/1798776 > > The current shebang does not work in environments that only support python3 > and have no python2 installed. Plus there does not seem to be a way to > support python2 and python3 at the same time. Since all known python3 issues > were fixed, and as python3 is the way to go, let's switch over. > Note that the code is still python2 compliant, so folks in bad use can > simply revert the shebang. > > Suggested-by: Christian Ehrhardt <christian.ehrhardt@canonical.com> > Signed-off-by: Stefan Raspl <raspl@linux.ibm.com> > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> > (cherry picked from commit 09f70c3b70e7d9e209a820b54dda42502fa40711) > Signed-off-by: Juerg Haefliger <juergh@canonical.com> Acked-by: Stefan Bader <stefan.bader@canonical.com> > --- Formally, there should be a SRU justification section in the bug description even for things as simple as that. -Stefan > tools/kvm/kvm_stat/kvm_stat | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/kvm/kvm_stat/kvm_stat b/tools/kvm/kvm_stat/kvm_stat > index 7c92545931e3..fb25837df44f 100755 > --- a/tools/kvm/kvm_stat/kvm_stat > +++ b/tools/kvm/kvm_stat/kvm_stat > @@ -1,4 +1,4 @@ > -#!/usr/bin/python > +#!/usr/bin/env python3 > # > # top-like utility for displaying kvm statistics > # >
On 1/15/19 11:15 AM, Juerg Haefliger wrote: > From: Stefan Raspl <stefan.raspl@de.ibm.com> > > BugLink: https://bugs.launchpad.net/bugs/1798776 > > The current shebang does not work in environments that only support python3 > and have no python2 installed. Plus there does not seem to be a way to > support python2 and python3 at the same time. Since all known python3 issues > were fixed, and as python3 is the way to go, let's switch over. > Note that the code is still python2 compliant, so folks in bad use can > simply revert the shebang. > > Suggested-by: Christian Ehrhardt <christian.ehrhardt@canonical.com> > Signed-off-by: Stefan Raspl <raspl@linux.ibm.com> > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> > (cherry picked from commit 09f70c3b70e7d9e209a820b54dda42502fa40711) > Signed-off-by: Juerg Haefliger <juergh@canonical.com> Acked-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com> > --- > tools/kvm/kvm_stat/kvm_stat | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/kvm/kvm_stat/kvm_stat b/tools/kvm/kvm_stat/kvm_stat > index 7c92545931e3..fb25837df44f 100755 > --- a/tools/kvm/kvm_stat/kvm_stat > +++ b/tools/kvm/kvm_stat/kvm_stat > @@ -1,4 +1,4 @@ > -#!/usr/bin/python > +#!/usr/bin/env python3 > # > # top-like utility for displaying kvm statistics > #
On 2019-01-15 11:15:48 , Juerg Haefliger wrote: > From: Stefan Raspl <stefan.raspl@de.ibm.com> > > BugLink: https://bugs.launchpad.net/bugs/1798776 > > The current shebang does not work in environments that only support python3 > and have no python2 installed. Plus there does not seem to be a way to > support python2 and python3 at the same time. Since all known python3 issues > were fixed, and as python3 is the way to go, let's switch over. > Note that the code is still python2 compliant, so folks in bad use can > simply revert the shebang. > > Suggested-by: Christian Ehrhardt <christian.ehrhardt@canonical.com> > Signed-off-by: Stefan Raspl <raspl@linux.ibm.com> > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> > (cherry picked from commit 09f70c3b70e7d9e209a820b54dda42502fa40711) > Signed-off-by: Juerg Haefliger <juergh@canonical.com> > --- > tools/kvm/kvm_stat/kvm_stat | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/kvm/kvm_stat/kvm_stat b/tools/kvm/kvm_stat/kvm_stat > index 7c92545931e3..fb25837df44f 100755 > --- a/tools/kvm/kvm_stat/kvm_stat > +++ b/tools/kvm/kvm_stat/kvm_stat > @@ -1,4 +1,4 @@ > -#!/usr/bin/python > +#!/usr/bin/env python3 > # > # top-like utility for displaying kvm statistics > # > -- > 2.19.1 > > > -- > kernel-team mailing list > kernel-team@lists.ubuntu.com > https://lists.ubuntu.com/mailman/listinfo/kernel-team
diff --git a/tools/kvm/kvm_stat/kvm_stat b/tools/kvm/kvm_stat/kvm_stat index 7c92545931e3..fb25837df44f 100755 --- a/tools/kvm/kvm_stat/kvm_stat +++ b/tools/kvm/kvm_stat/kvm_stat @@ -1,4 +1,4 @@ -#!/usr/bin/python +#!/usr/bin/env python3 # # top-like utility for displaying kvm statistics #