Message ID | 1533648586-60818-1-git-send-email-matthew.weber@rockwellcollins.com |
---|---|
State | Superseded |
Headers | show |
Series | openresolv: new package | expand |
Hello Matt, On Tue, 7 Aug 2018 08:29:46 -0500, Matt Weber wrote: > package/Config.in | 1 + > package/openresolv/Config.in | 13 +++++++++++++ > package/openresolv/openresolv.hash | 3 +++ > package/openresolv/openresolv.mk | 12 ++++++++++++ > 4 files changed, 29 insertions(+) Entry in DEVELOPERS file is missing. > diff --git a/package/Config.in b/package/Config.in > index f5a1749..2ad6687 100644 > --- a/package/Config.in > +++ b/package/Config.in > @@ -1843,6 +1843,7 @@ endif > source "package/open-plc-utils/Config.in" > source "package/openntpd/Config.in" > source "package/openobex/Config.in" > + source "package/openresolv/Config.in" > source "package/openssh/Config.in" > source "package/openswan/Config.in" > source "package/openvpn/Config.in" > diff --git a/package/openresolv/Config.in b/package/openresolv/Config.in > new file mode 100644 > index 0000000..3eb736f > --- /dev/null > +++ b/package/openresolv/Config.in > @@ -0,0 +1,13 @@ > +comment "openresolv needs a bash shell" > + depends on !BR2_SYSTEM_BIN_SH_BASH Are you sure it needs a bash shell ? Indeed in https://github.com/rsmarples/openresolv, the #1 argument for resolvconf compared to its Debian variant is: "" Works with POSIX shell and userland "" > $(eval $(autotools-package)) This package is not using the autotools. The configure script is not generated by autoconf, the Makefile is not generated by automake. So, generic-package should be used, and not autotools-package. Thanks! Thomas
Thomas, On Tue, Aug 14, 2018 at 9:12 AM Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote: > > Hello Matt, > > On Tue, 7 Aug 2018 08:29:46 -0500, Matt Weber wrote: > > > package/Config.in | 1 + > > package/openresolv/Config.in | 13 +++++++++++++ > > package/openresolv/openresolv.hash | 3 +++ > > package/openresolv/openresolv.mk | 12 ++++++++++++ > > 4 files changed, 29 insertions(+) > > Entry in DEVELOPERS file is missing. Ah yes, will add. > > > diff --git a/package/Config.in b/package/Config.in > > index f5a1749..2ad6687 100644 > > --- a/package/Config.in > > +++ b/package/Config.in > > @@ -1843,6 +1843,7 @@ endif > > source "package/open-plc-utils/Config.in" > > source "package/openntpd/Config.in" > > source "package/openobex/Config.in" > > + source "package/openresolv/Config.in" > > source "package/openssh/Config.in" > > source "package/openswan/Config.in" > > source "package/openvpn/Config.in" > > diff --git a/package/openresolv/Config.in b/package/openresolv/Config.in > > new file mode 100644 > > index 0000000..3eb736f > > --- /dev/null > > +++ b/package/openresolv/Config.in > > @@ -0,0 +1,13 @@ > > +comment "openresolv needs a bash shell" > > + depends on !BR2_SYSTEM_BIN_SH_BASH > > Are you sure it needs a bash shell ? Indeed in > https://github.com/rsmarples/openresolv, the #1 argument for resolvconf > compared to its Debian variant is: > > "" > Works with POSIX shell and userland > "" This dialog should have been included in the description related to use of getopts vs getopt in the script. https://github.com/rsmarples/openresolv/commit/a694a49c41ffdc0e215320459af009d44482b065#commitcomment-29850615 > > > $(eval $(autotools-package)) > > This package is not using the autotools. The configure script is not > generated by autoconf, the Makefile is not generated by automake. So, > generic-package should be used, and not autotools-package. Missed this, looks like they are mimic'n a configure script. It is working as a autotools pkg, but I'll pull the commands over to a generic. Matt
Hello, On Tue, 14 Aug 2018 09:37:05 -0500, Matthew Weber wrote: > > Are you sure it needs a bash shell ? Indeed in > > https://github.com/rsmarples/openresolv, the #1 argument for resolvconf > > compared to its Debian variant is: > > > > "" > > Works with POSIX shell and userland > > "" > > This dialog should have been included in the description related to > use of getopts vs getopt in the script. > > https://github.com/rsmarples/openresolv/commit/a694a49c41ffdc0e215320459af009d44482b065#commitcomment-29850615 I think Paresh got it wrong somehow. Busybox provides both getopt and getopts. getopt is non-POSIX, while getopts is POSIX (see https://en.wikipedia.org/wiki/Getopt#Shell and http://pubs.opengroup.org/onlinepubs/9699919799/utilities/getopts.html). Minimal Buildroot system with our default Busybox configuration: # getopts -sh: getopts: usage: getopts optstring var [arg] # getopt getopt: missing optstring argument Both are provided. getopt is a separate program, getopts is a shell built-in. I added a comment on the Github issue. > Missed this, looks like they are mimic'n a configure script. It is > working as a autotools pkg, but I'll pull the commands over to a > generic. Please don't pull the full commands from autotools-package with all the environment variables and options that only make sense for real-autotools based packages: only include the minimal set of variables/options. Thanks! Thomas
diff --git a/package/Config.in b/package/Config.in index f5a1749..2ad6687 100644 --- a/package/Config.in +++ b/package/Config.in @@ -1843,6 +1843,7 @@ endif source "package/open-plc-utils/Config.in" source "package/openntpd/Config.in" source "package/openobex/Config.in" + source "package/openresolv/Config.in" source "package/openssh/Config.in" source "package/openswan/Config.in" source "package/openvpn/Config.in" diff --git a/package/openresolv/Config.in b/package/openresolv/Config.in new file mode 100644 index 0000000..3eb736f --- /dev/null +++ b/package/openresolv/Config.in @@ -0,0 +1,13 @@ +comment "openresolv needs a bash shell" + depends on !BR2_SYSTEM_BIN_SH_BASH + +config BR2_PACKAGE_OPENRESOLV + bool "openresolv" + depends on BR2_SYSTEM_BIN_SH_BASH # bash runtime dependency + select BR2_PACKAGE_BASH + help + openresolv is a resolvconf implementation which + manages resolv.conf. This tool provides a dns management + framework to track currently available nameservers. + + https://github.com/rsmarples/openresolv diff --git a/package/openresolv/openresolv.hash b/package/openresolv/openresolv.hash new file mode 100644 index 0000000..e1a1fb5 --- /dev/null +++ b/package/openresolv/openresolv.hash @@ -0,0 +1,3 @@ +# Locally calculated +sha256 96b3f84435a183426c622db7097a930fb0d48a99e82cd87ce83bd343b8c20574 openresolv-fe4e1ec4e2be2adfc1530ade94ebb30aa6f51540.tar.gz +sha256 d1f9dcd2dac4e095b14caab517cfe791a6e0785346164b7d0cafc13c714f8aa5 LICENSE diff --git a/package/openresolv/openresolv.mk b/package/openresolv/openresolv.mk new file mode 100644 index 0000000..2faa6e1 --- /dev/null +++ b/package/openresolv/openresolv.mk @@ -0,0 +1,12 @@ +################################################################################ +# +# openresolv +# +################################################################################ + +OPENRESOLV_VERSION = fe4e1ec4e2be2adfc1530ade94ebb30aa6f51540 +OPENRESOLV_SITE = $(call github,rsmarples,openresolv,$(OPENRESOLV_VERSION)) +OPENRESOLV_LICENSE = BSD-2-Clause +OPENRESOLV_LICENSE_FILES = LICENSE + +$(eval $(autotools-package))