| Message ID | 1533601964-20157-1-git-send-email-leitao@debian.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | powerpc/tm: Print 64-bits MSR | expand |
| Context | Check | Description |
|---|---|---|
| snowpatch_ozlabs/apply_patch | success | next/apply_patch Successfully applied |
| snowpatch_ozlabs/checkpatch | warning | Test checkpatch on branch next |
| snowpatch_ozlabs/build-ppc64le | success | Test build-ppc64le on branch next |
| snowpatch_ozlabs/build-ppc64be | success | Test build-ppc64be on branch next |
| snowpatch_ozlabs/build-ppc64e | success | Test build-ppc64e on branch next |
| snowpatch_ozlabs/build-ppc32 | success | Test build-ppc32 on branch next |
On Mon, 2018-08-06 at 21:32 -0300, Breno Leitao wrote: > On a kernel TM Bad thing program exception, the MSR is not being properly > displayed, since it dumps a 32-bits value. MSR is a 64 bits register for > all platforms that have HTM enabled. > > This patch dumps the MSR value as 64-bits instead of 32 bits. (sorry I was distracted when you asked me about this before offline...) I think you might need to clear up in the description why you are changing reason -> msr. Mikey > Signed-off-by: Breno Leitao <leitao@debian.org> > --- > arch/powerpc/kernel/traps.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/powerpc/kernel/traps.c b/arch/powerpc/kernel/traps.c > index 0e17dcb48720..cd561fd89532 100644 > --- a/arch/powerpc/kernel/traps.c > +++ b/arch/powerpc/kernel/traps.c > @@ -1402,7 +1402,7 @@ void program_check_exception(struct pt_regs *regs) > goto bail; > } else { > printk(KERN_EMERG "Unexpected TM Bad Thing exception > " > - "at %lx (msr 0x%x)\n", regs->nip, reason); > + "at %lx (msr 0x%lx)\n", regs->nip, regs->msr); > > die("Unrecoverable exception", regs, SIGABRT); > } > }
diff --git a/arch/powerpc/kernel/traps.c b/arch/powerpc/kernel/traps.c index 0e17dcb48720..cd561fd89532 100644 --- a/arch/powerpc/kernel/traps.c +++ b/arch/powerpc/kernel/traps.c @@ -1402,7 +1402,7 @@ void program_check_exception(struct pt_regs *regs) goto bail; } else { printk(KERN_EMERG "Unexpected TM Bad Thing exception " - "at %lx (msr 0x%x)\n", regs->nip, reason); + "at %lx (msr 0x%lx)\n", regs->nip, regs->msr); die("Unrecoverable exception", regs, SIGABRT); } }
On a kernel TM Bad thing program exception, the MSR is not being properly displayed, since it dumps a 32-bits value. MSR is a 64 bits register for all platforms that have HTM enabled. This patch dumps the MSR value as 64-bits instead of 32 bits. Signed-off-by: Breno Leitao <leitao@debian.org> --- arch/powerpc/kernel/traps.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)