Message ID | 20180710091313.424-1-po-hsu.lin@canonical.com |
---|---|
State | New |
Headers | show |
Series | [xenial/gcp,bionic/gcp,cosmic/gcp] UBUNTU: Add the linux-modules-extra-gcp/gke meta package | expand |
On 10.07.2018 11:13, Po-Hsu Lin wrote: > BugLink: https://bugs.launchpad.net/bugs/1780923 > > linux-image-gcp/gke does not install extra modules by default. Because > of that, there's no simple way for users and for the testing > infrastructure to install them. > > Add a meta package to always follow the latest > linux-modules-extra-<version>-gcp/gke package available. > > Signed-off-by: Po-Hsu Lin <po-hsu.lin@canonical.com> Acked-by: Stefan Bader <stefan.bader@canonical.com> > --- I guess since we create it there should be a way to keep it current. Note that this has to be applied to the linux-gcp-meta tree(s). It can be guessed by the contents but the subject might be misleading. -Stefan > debian/control.d/gcp | 8 ++++++++ > debian/control.d/gke | 8 ++++++++ > 2 files changed, 16 insertions(+) > > diff --git a/debian/control.d/gcp b/debian/control.d/gcp > index 1db6cd3..263b6d4 100644 > --- a/debian/control.d/gcp > +++ b/debian/control.d/gcp > @@ -1,3 +1,11 @@ > +Package: linux-extra@SUFFIX@ > +Architecture: amd64 > +Section: kernel > +Depends: ${misc:Depends}, linux-image-extra-${kernel-abi-version}@SUFFIX@ > +Description: Google Cloud Platform (GCP) Linux kernel extra modules > + This package will always depend on the latest Google Cloud Platform (GCP) > + extra modules package available. > + > Package: linux-headers@SUFFIX@ > Architecture: amd64 > Section: kernel > diff --git a/debian/control.d/gke b/debian/control.d/gke > index 96b38d1..96aa554 100644 > --- a/debian/control.d/gke > +++ b/debian/control.d/gke > @@ -1,3 +1,11 @@ > +Package: linux-extra@SUFFIX@ > +Architecture: amd64 > +Section: kernel > +Depends: ${misc:Depends}, linux-image-extra-${kernel-abi-version}@SRCSUFFIX@ > +Description: Google Container Engine (GKE) Linux kernel extra modules > + This package will always depend on the latest Google Container Engine (GKE) > + extra modules package available. > + > Package: linux-headers@SUFFIX@ > Architecture: amd64 > Section: kernel >
On Thu, Jul 26, 2018 at 9:30 PM, Stefan Bader <stefan.bader@canonical.com> wrote: > On 10.07.2018 11:13, Po-Hsu Lin wrote: >> BugLink: https://bugs.launchpad.net/bugs/1780923 >> >> linux-image-gcp/gke does not install extra modules by default. Because >> of that, there's no simple way for users and for the testing >> infrastructure to install them. >> >> Add a meta package to always follow the latest >> linux-modules-extra-<version>-gcp/gke package available. >> >> Signed-off-by: Po-Hsu Lin <po-hsu.lin@canonical.com> > Acked-by: Stefan Bader <stefan.bader@canonical.com> >> --- > > I guess since we create it there should be a way to keep it current. Note that > this has to be applied to the linux-gcp-meta tree(s). It can be guessed by the > contents but the subject might be misleading. > > -Stefan > Ah, yes, sorry for the confusion. Any suggestion for this kind of changes that is targeting another tree? Maybe add a [linux-meta-gcp] tag? Thanks Sam > >> debian/control.d/gcp | 8 ++++++++ >> debian/control.d/gke | 8 ++++++++ >> 2 files changed, 16 insertions(+) >> >> diff --git a/debian/control.d/gcp b/debian/control.d/gcp >> index 1db6cd3..263b6d4 100644 >> --- a/debian/control.d/gcp >> +++ b/debian/control.d/gcp >> @@ -1,3 +1,11 @@ >> +Package: linux-extra@SUFFIX@ >> +Architecture: amd64 >> +Section: kernel >> +Depends: ${misc:Depends}, linux-image-extra-${kernel-abi-version}@SUFFIX@ >> +Description: Google Cloud Platform (GCP) Linux kernel extra modules >> + This package will always depend on the latest Google Cloud Platform (GCP) >> + extra modules package available. >> + >> Package: linux-headers@SUFFIX@ >> Architecture: amd64 >> Section: kernel >> diff --git a/debian/control.d/gke b/debian/control.d/gke >> index 96b38d1..96aa554 100644 >> --- a/debian/control.d/gke >> +++ b/debian/control.d/gke >> @@ -1,3 +1,11 @@ >> +Package: linux-extra@SUFFIX@ >> +Architecture: amd64 >> +Section: kernel >> +Depends: ${misc:Depends}, linux-image-extra-${kernel-abi-version}@SRCSUFFIX@ >> +Description: Google Container Engine (GKE) Linux kernel extra modules >> + This package will always depend on the latest Google Container Engine (GKE) >> + extra modules package available. >> + >> Package: linux-headers@SUFFIX@ >> Architecture: amd64 >> Section: kernel >> > >
On 07/10/18 11:13, Po-Hsu Lin wrote: > BugLink: https://bugs.launchpad.net/bugs/1780923 > > linux-image-gcp/gke does not install extra modules by default. Because > of that, there's no simple way for users and for the testing > infrastructure to install them. > > Add a meta package to always follow the latest > linux-modules-extra-<version>-gcp/gke package available. > > Signed-off-by: Po-Hsu Lin <po-hsu.lin@canonical.com> > --- > debian/control.d/gcp | 8 ++++++++ > debian/control.d/gke | 8 ++++++++ > 2 files changed, 16 insertions(+) > > diff --git a/debian/control.d/gcp b/debian/control.d/gcp > index 1db6cd3..263b6d4 100644 > --- a/debian/control.d/gcp > +++ b/debian/control.d/gcp > @@ -1,3 +1,11 @@ > +Package: linux-extra@SUFFIX@ Shouldn't this be linux-modules-extra@SUFFIX@ ? There are no other package in the repo called linux-extra*. > +Architecture: amd64 > +Section: kernel > +Depends: ${misc:Depends}, linux-image-extra-${kernel-abi-version}@SUFFIX@ The binary package produced is called linux-modules-extra-<kernel-abi>-gcp So above should be linux-modules-extra-${kernel-abi-version}@SUFFIX@ > +Description: Google Cloud Platform (GCP) Linux kernel extra modules > + This package will always depend on the latest Google Cloud Platform (GCP) > + extra modules package available. > + > Package: linux-headers@SUFFIX@ > Architecture: amd64 > Section: kernel > diff --git a/debian/control.d/gke b/debian/control.d/gke > index 96b38d1..96aa554 100644 > --- a/debian/control.d/gke > +++ b/debian/control.d/gke > @@ -1,3 +1,11 @@ > +Package: linux-extra@SUFFIX@ Same here: linux-modules-extra@SUFFIX@ > +Architecture: amd64 > +Section: kernel > +Depends: ${misc:Depends}, linux-image-extra-${kernel-abi-version}@SRCSUFFIX@ linux-modules-extra-${kernel-abi-version}@SRCSUFFIX@ > +Description: Google Container Engine (GKE) Linux kernel extra modules > + This package will always depend on the latest Google Container Engine (GKE) > + extra modules package available. > + > Package: linux-headers@SUFFIX@ > Architecture: amd64 > Section: kernel > Thanks, Kleber
Ah OK, I was cooking this with the 4.13 kernel, which did have the linux-image-extra package. Since we're now 4.15 and it's gone, I will send a V2 for this. Thanks! Sam On Fri, Jul 27, 2018 at 7:23 PM, Kleber Souza <kleber.souza@canonical.com> wrote: > On 07/10/18 11:13, Po-Hsu Lin wrote: >> BugLink: https://bugs.launchpad.net/bugs/1780923 >> >> linux-image-gcp/gke does not install extra modules by default. Because >> of that, there's no simple way for users and for the testing >> infrastructure to install them. >> >> Add a meta package to always follow the latest >> linux-modules-extra-<version>-gcp/gke package available. >> >> Signed-off-by: Po-Hsu Lin <po-hsu.lin@canonical.com> >> --- >> debian/control.d/gcp | 8 ++++++++ >> debian/control.d/gke | 8 ++++++++ >> 2 files changed, 16 insertions(+) >> >> diff --git a/debian/control.d/gcp b/debian/control.d/gcp >> index 1db6cd3..263b6d4 100644 >> --- a/debian/control.d/gcp >> +++ b/debian/control.d/gcp >> @@ -1,3 +1,11 @@ >> +Package: linux-extra@SUFFIX@ > > Shouldn't this be linux-modules-extra@SUFFIX@ ? There are no other > package in the repo called linux-extra*. > >> +Architecture: amd64 >> +Section: kernel >> +Depends: ${misc:Depends}, linux-image-extra-${kernel-abi-version}@SUFFIX@ > > The binary package produced is called > > linux-modules-extra-<kernel-abi>-gcp > > So above should be > > linux-modules-extra-${kernel-abi-version}@SUFFIX@ > > >> +Description: Google Cloud Platform (GCP) Linux kernel extra modules >> + This package will always depend on the latest Google Cloud Platform (GCP) >> + extra modules package available. >> + >> Package: linux-headers@SUFFIX@ >> Architecture: amd64 >> Section: kernel >> diff --git a/debian/control.d/gke b/debian/control.d/gke >> index 96b38d1..96aa554 100644 >> --- a/debian/control.d/gke >> +++ b/debian/control.d/gke >> @@ -1,3 +1,11 @@ >> +Package: linux-extra@SUFFIX@ > > Same here: linux-modules-extra@SUFFIX@ > >> +Architecture: amd64 >> +Section: kernel >> +Depends: ${misc:Depends}, linux-image-extra-${kernel-abi-version}@SRCSUFFIX@ > > linux-modules-extra-${kernel-abi-version}@SRCSUFFIX@ > > >> +Description: Google Container Engine (GKE) Linux kernel extra modules >> + This package will always depend on the latest Google Container Engine (GKE) >> + extra modules package available. >> + >> Package: linux-headers@SUFFIX@ >> Architecture: amd64 >> Section: kernel >> > > > Thanks, > Kleber
diff --git a/debian/control.d/gcp b/debian/control.d/gcp index 1db6cd3..263b6d4 100644 --- a/debian/control.d/gcp +++ b/debian/control.d/gcp @@ -1,3 +1,11 @@ +Package: linux-extra@SUFFIX@ +Architecture: amd64 +Section: kernel +Depends: ${misc:Depends}, linux-image-extra-${kernel-abi-version}@SUFFIX@ +Description: Google Cloud Platform (GCP) Linux kernel extra modules + This package will always depend on the latest Google Cloud Platform (GCP) + extra modules package available. + Package: linux-headers@SUFFIX@ Architecture: amd64 Section: kernel diff --git a/debian/control.d/gke b/debian/control.d/gke index 96b38d1..96aa554 100644 --- a/debian/control.d/gke +++ b/debian/control.d/gke @@ -1,3 +1,11 @@ +Package: linux-extra@SUFFIX@ +Architecture: amd64 +Section: kernel +Depends: ${misc:Depends}, linux-image-extra-${kernel-abi-version}@SRCSUFFIX@ +Description: Google Container Engine (GKE) Linux kernel extra modules + This package will always depend on the latest Google Container Engine (GKE) + extra modules package available. + Package: linux-headers@SUFFIX@ Architecture: amd64 Section: kernel
BugLink: https://bugs.launchpad.net/bugs/1780923 linux-image-gcp/gke does not install extra modules by default. Because of that, there's no simple way for users and for the testing infrastructure to install them. Add a meta package to always follow the latest linux-modules-extra-<version>-gcp/gke package available. Signed-off-by: Po-Hsu Lin <po-hsu.lin@canonical.com> --- debian/control.d/gcp | 8 ++++++++ debian/control.d/gke | 8 ++++++++ 2 files changed, 16 insertions(+)