| Message ID | 20180530114651.3225-1-valentin.korenblit@smile.fr |
|---|---|
| State | Accepted |
| Commit | 71b3df1cbbfeb69d9f9a39af9a1ae5722215a9a3 |
| Headers | show |
| Series | [v2] package/clang: fix host-clang binaries | expand |
Hi Valentin, On Wed, May 30, 2018 at 4:46 AM, Valentin Korenblit <valentin.korenblit@smile.fr> wrote: > This patch fixes the following error when trying to execute clang compiler > (host-variant): > > CommandLine Error: Option 'x86-use-base-pointer' registered more than once! > LLVM ERROR: inconsistency in registered CommandLine options > > The same happens for the other binaries, such as clang-format: > > ./clang-format > : CommandLine Error: Option 'help-list' registered more than once! > LLVM ERROR: inconsistency in registered CommandLine options > > Clang binaries are tools, and given that DLLVM_LINK_LLVM_DYLIB is set, > they are linked against libLLVM.so. The problem is that binaries are > also linking against some LLVM static libraries, resulting in the error > shown above. However, it is not the same case for libclang, which is also > a tool but links only against libLLVM.so. > > To fix this problem, add LLVM_DYLIB_COMPONENTS=all. > > Signed-off-by: Valentin Korenblit <valentin.korenblit@smile.fr> Tested-by: Joseph Kogut <joseph.kogut@gmail.com> > --- > Currently there is no package in Buildroot that needs host-clang compiler. > This error was found when trying to build libclc (WIP) after having applied: > http://lists.busybox.net/pipermail/buildroot/2018-May/221386.html > > Changes v1 -> v2: > > *Use LLVM_DYLIB_COMPONENTS=all instead of patching CMakeLists.txt of clang binaries. > > package/clang/clang.mk | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/package/clang/clang.mk b/package/clang/clang.mk > index ae0140c783..dc086c6eed 100644 > --- a/package/clang/clang.mk > +++ b/package/clang/clang.mk > @@ -89,5 +89,9 @@ HOST_CLANG_POST_INSTALL_HOOKS = HOST_CLANG_INSTALL_CLANG_TBLGEN > HOST_CLANG_CONF_OPTS += -DLLVM_LINK_LLVM_DYLIB=ON > CLANG_CONF_OPTS += -DLLVM_LINK_LLVM_DYLIB=ON > > +# Prevent clang binaries from linking against LLVM static libs > +HOST_CLANG_CONF_OPTS += -DLLVM_DYLIB_COMPONENTS=all > +CLANG_CONF_OPTS += -DLLVM_DYLIB_COMPONENTS=all > + > $(eval $(cmake-package)) > $(eval $(host-cmake-package)) > -- > 2.14.3 > > _______________________________________________ > buildroot mailing list > buildroot@busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot
>>>>> "Valentin" == Valentin Korenblit <valentin.korenblit@smile.fr> writes: > This patch fixes the following error when trying to execute clang compiler > (host-variant): > CommandLine Error: Option 'x86-use-base-pointer' registered more than once! > LLVM ERROR: inconsistency in registered CommandLine options > The same happens for the other binaries, such as clang-format: > ./clang-format > : CommandLine Error: Option 'help-list' registered more than once! > LLVM ERROR: inconsistency in registered CommandLine options > Clang binaries are tools, and given that DLLVM_LINK_LLVM_DYLIB is set, > they are linked against libLLVM.so. The problem is that binaries are > also linking against some LLVM static libraries, resulting in the error > shown above. However, it is not the same case for libclang, which is also > a tool but links only against libLLVM.so. > To fix this problem, add LLVM_DYLIB_COMPONENTS=all. > Signed-off-by: Valentin Korenblit <valentin.korenblit@smile.fr> > --- > Currently there is no package in Buildroot that needs host-clang compiler. > This error was found when trying to build libclc (WIP) after having applied: > http://lists.busybox.net/pipermail/buildroot/2018-May/221386.html > Changes v1 -> v2: > *Use LLVM_DYLIB_COMPONENTS=all instead of patching CMakeLists.txt of clang binaries. Committed, thanks.
diff --git a/package/clang/clang.mk b/package/clang/clang.mk index ae0140c783..dc086c6eed 100644 --- a/package/clang/clang.mk +++ b/package/clang/clang.mk @@ -89,5 +89,9 @@ HOST_CLANG_POST_INSTALL_HOOKS = HOST_CLANG_INSTALL_CLANG_TBLGEN HOST_CLANG_CONF_OPTS += -DLLVM_LINK_LLVM_DYLIB=ON CLANG_CONF_OPTS += -DLLVM_LINK_LLVM_DYLIB=ON +# Prevent clang binaries from linking against LLVM static libs +HOST_CLANG_CONF_OPTS += -DLLVM_DYLIB_COMPONENTS=all +CLANG_CONF_OPTS += -DLLVM_DYLIB_COMPONENTS=all + $(eval $(cmake-package)) $(eval $(host-cmake-package))
This patch fixes the following error when trying to execute clang compiler (host-variant): CommandLine Error: Option 'x86-use-base-pointer' registered more than once! LLVM ERROR: inconsistency in registered CommandLine options The same happens for the other binaries, such as clang-format: ./clang-format : CommandLine Error: Option 'help-list' registered more than once! LLVM ERROR: inconsistency in registered CommandLine options Clang binaries are tools, and given that DLLVM_LINK_LLVM_DYLIB is set, they are linked against libLLVM.so. The problem is that binaries are also linking against some LLVM static libraries, resulting in the error shown above. However, it is not the same case for libclang, which is also a tool but links only against libLLVM.so. To fix this problem, add LLVM_DYLIB_COMPONENTS=all. Signed-off-by: Valentin Korenblit <valentin.korenblit@smile.fr> --- Currently there is no package in Buildroot that needs host-clang compiler. This error was found when trying to build libclc (WIP) after having applied: http://lists.busybox.net/pipermail/buildroot/2018-May/221386.html Changes v1 -> v2: *Use LLVM_DYLIB_COMPONENTS=all instead of patching CMakeLists.txt of clang binaries. package/clang/clang.mk | 4 ++++ 1 file changed, 4 insertions(+)