[17/30] hw/tricore: use the BYTE-based definitions

Message ID	20180215042900.16078-18-f4bug@amsat.org
State	New
Headers	show Return-Path: <qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org> From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <f4bug@amsat.org> To: qemu-devel@nongnu.org Date: Thu, 15 Feb 2018 01:28:47 -0300 Message-Id: <20180215042900.16078-18-f4bug@amsat.org> In-Reply-To: <20180215042900.16078-1-f4bug@amsat.org> References: <20180215042900.16078-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: [Qemu-devel] [PATCH 17/30] hw/tricore: use the BYTE-based definitions Precedence: list Cc: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>, =?utf-8?q?Philipp?= =?utf-8?q?e_Mathieu-Daud=C3=A9?= <f4bug@amsat.org> Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" <qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>
Series	hw: use the BYTE-based definitions when useful \| expand [00/30] hw: use the BYTE-based definitions when useful [01/30] util/cutils: extract byte-based definitions into a new header: "qemu/cunits.h" [02/30] hw: include "qemu/cunits.h" and clean unused "qemu/cutils.h" [03/30] hw/block/nvme: include the "qemu/cutils.h" in the source file [04/30] hw/lm32/milkymist: remove unused include [05/30] hw/mips/r4k: constify params_size [06/30] hw/mips: use the BYTE-based definitions [07/30] hw/arm: use the BYTE-based definitions [08/30] hw/i386: use the BYTE-based definitions [09/30] hw/sparc: use the BYTE-based definitions [10/30] hw/ppc: use the BYTE-based definitions [11/30] hw/s390x: use the BYTE-based definitions [12/30] hw/hppa: use the BYTE-based definitions [13/30] hw/xtensa: use the BYTE-based definitions [14/30] hw/alpha: use the BYTE-based definitions [15/30] hw/lm32: use the BYTE-based definitions [16/30] hw/sh4: use the BYTE-based definitions [17/30] hw/tricore: use the BYTE-based definitions [18/30] hw/microblaze: use the BYTE-based definitions [19/30] hw/nios2: use the BYTE-based definitions [20/30] hw/cris: use the BYTE-based definitions [21/30] hw/misc: use the BYTE-based definitions [22/30] hw/display: use the BYTE-based definitions [23/30] hw/net: use the BYTE-based definitions [24/30] hw/ipack: use the BYTE-based definitions [25/30] hw/scsi: use the BYTE-based definitions [26/30] hw/smbios: use the BYTE-based definitions [27/30] vfio/pci: use the BYTE-based definitions [28/30] ivshmem: use the BYTE-based definitions [29/30] tpm: use the BYTE-based definitions [30/30] xen: use the BYTE-based definitions

Message ID

20180215042900.16078-18-f4bug@amsat.org

State

New

Headers

From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <f4bug@amsat.org>
To: qemu-devel@nongnu.org
Date: Thu, 15 Feb 2018 01:28:47 -0300
Message-Id: <20180215042900.16078-18-f4bug@amsat.org>
In-Reply-To: <20180215042900.16078-1-f4bug@amsat.org>
References: <20180215042900.16078-1-f4bug@amsat.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Subject: [Qemu-devel] [PATCH 17/30] hw/tricore: use the BYTE-based
	definitions
Precedence: list
Cc: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>, =?utf-8?q?Philipp?=
	=?utf-8?q?e_Mathieu-Daud=C3=A9?= <f4bug@amsat.org>
Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org
Sender: "Qemu-devel"
	<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>

Series

hw: use the BYTE-based definitions when useful | expand

It ease code review, unit is explicit. Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> --- hw/tricore/tricore_testboard.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)

Comments

Bastian Koppelmann Feb. 20, 2018, 4:04 p.m. UTC | #1

On 02/15/2018 05:28 AM, Philippe Mathieu-Daudé wrote:
> It ease code review, unit is explicit.
> 
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>  hw/tricore/tricore_testboard.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)

Acked-by: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>

Cheers,
Bastian

diff --git a/hw/tricore/tricore_testboard.c b/hw/tricore/tricore_testboard.c
index ac75eb2128..032bcc8efb 100644
--- a/hw/tricore/tricore_testboard.c
+++ b/hw/tricore/tricore_testboard.c
@@ -74,17 +74,17 @@  static void tricore_testboard_init(MachineState *machine, int board_id)
     cpu = TRICORE_CPU(cpu_create(machine->cpu_type));
     env = &cpu->env;
     memory_region_init_ram(ext_cram, NULL, "powerlink_ext_c.ram",
-                           2 * 1024 * 1024, &error_fatal);
+                           2 * M_BYTE, &error_fatal);
     memory_region_init_ram(ext_dram, NULL, "powerlink_ext_d.ram",
-                           4 * 1024 * 1024, &error_fatal);
-    memory_region_init_ram(int_cram, NULL, "powerlink_int_c.ram", 48 * 1024,
+                           4 * M_BYTE, &error_fatal);
+    memory_region_init_ram(int_cram, NULL, "powerlink_int_c.ram", 48 * K_BYTE,
                            &error_fatal);
-    memory_region_init_ram(int_dram, NULL, "powerlink_int_d.ram", 48 * 1024,
+    memory_region_init_ram(int_dram, NULL, "powerlink_int_d.ram", 48 * K_BYTE,
                            &error_fatal);
     memory_region_init_ram(pcp_data, NULL, "powerlink_pcp_data.ram",
-                           16 * 1024, &error_fatal);
+                           16 * K_BYTE, &error_fatal);
     memory_region_init_ram(pcp_text, NULL, "powerlink_pcp_text.ram",
-                           32 * 1024, &error_fatal);
+                           32 * K_BYTE, &error_fatal);
 
     memory_region_add_subregion(sysmem, 0x80000000, ext_cram);
     memory_region_add_subregion(sysmem, 0xa1000000, ext_dram);

[17/30] hw/tricore: use the BYTE-based definitions

Commit Message

Comments

Patch