Message ID | 20180215042900.16078-29-f4bug@amsat.org |
---|---|
State | New |
Headers | show |
Series | hw: use the BYTE-based definitions when useful | expand |
On 02/15/2018 01:28 AM, Philippe Mathieu-Daudé wrote: > It ease code review, unit is explicit. Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > --- > hw/misc/ivshmem.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c > index 16f03701b7..9b3ad96471 100644 > --- a/hw/misc/ivshmem.c > +++ b/hw/misc/ivshmem.c > @@ -1302,7 +1302,7 @@ static void ivshmem_realize(PCIDevice *dev, Error **errp) > } > > if (s->sizearg == NULL) { > - s->legacy_size = 4 << 20; /* 4 MB default */ > + s->legacy_size = 4 * M_BYTE; /* 4 MB default */ > } else { > int ret; > uint64_t size; >
On Thu, Feb 15, 2018 at 5:28 AM, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote: > It ease code review, unit is explicit. Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com> > --- > hw/misc/ivshmem.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c > index 16f03701b7..9b3ad96471 100644 > --- a/hw/misc/ivshmem.c > +++ b/hw/misc/ivshmem.c > @@ -1302,7 +1302,7 @@ static void ivshmem_realize(PCIDevice *dev, Error **errp) > } > > if (s->sizearg == NULL) { > - s->legacy_size = 4 << 20; /* 4 MB default */ > + s->legacy_size = 4 * M_BYTE; /* 4 MB default */ > } else { > int ret; > uint64_t size; > -- > 2.16.1 > >
diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c index 16f03701b7..9b3ad96471 100644 --- a/hw/misc/ivshmem.c +++ b/hw/misc/ivshmem.c @@ -1302,7 +1302,7 @@ static void ivshmem_realize(PCIDevice *dev, Error **errp) } if (s->sizearg == NULL) { - s->legacy_size = 4 << 20; /* 4 MB default */ + s->legacy_size = 4 * M_BYTE; /* 4 MB default */ } else { int ret; uint64_t size;