| Message ID | 20180205140325.12241-1-wens@csie.org |
|---|---|
| State | Accepted |
| Commit | 1bcfba537e7f59ce997094139a1f69a598e0c618 |
| Delegated to: | Jagannadha Sutradharudu Teki |
| Headers | show |
| Series | [U-Boot] sunxi: Add reg property for USB OTG node in sun8i-a83t.dtsi | expand |
On Mon, Feb 05, 2018 at 10:03:25PM +0800, Chen-Yu Tsai wrote: > When the OTG node was added, its reg property for its address space was > missing. With commit f4f9896ac310 ("musb: sunxi: Use base address from > device tree"), the OTG controller's address is derived from the device > tree exclusively. The missing property results in U-boot crashing when > MUSB is initialized. > > Fixes: b0bea6678981 ("sunxi: Add USB and R_PIO nodes to sun8i-a83t.dtsi") > Signed-off-by: Chen-Yu Tsai <wens@csie.org> Acked-by: Maxime Ripard <maxime.ripard@bootlin.com> Thanks! Maxime
On Mon, Feb 5, 2018 at 7:54 PM, Maxime Ripard <maxime.ripard@bootlin.com> wrote: > On Mon, Feb 05, 2018 at 10:03:25PM +0800, Chen-Yu Tsai wrote: >> When the OTG node was added, its reg property for its address space was >> missing. With commit f4f9896ac310 ("musb: sunxi: Use base address from >> device tree"), the OTG controller's address is derived from the device >> tree exclusively. The missing property results in U-boot crashing when >> MUSB is initialized. >> >> Fixes: b0bea6678981 ("sunxi: Add USB and R_PIO nodes to sun8i-a83t.dtsi") >> Signed-off-by: Chen-Yu Tsai <wens@csie.org> > > Acked-by: Maxime Ripard <maxime.ripard@bootlin.com> Reviewed-by: Jagan Teki <jagan@openedev.com> Tested-by: Jagan Teki <jagan@openedev.com>
diff --git a/arch/arm/dts/sun8i-a83t.dtsi b/arch/arm/dts/sun8i-a83t.dtsi index 0fe73e173f44..bab6c1812b8a 100644 --- a/arch/arm/dts/sun8i-a83t.dtsi +++ b/arch/arm/dts/sun8i-a83t.dtsi @@ -227,6 +227,7 @@ usb_otg: usb@01c19000 { compatible = "allwinner,sun8i-a33-musb"; + reg = <0x01c19000 0x400>; interrupts = <GIC_SPI 71 IRQ_TYPE_LEVEL_HIGH>; interrupt-names = "mc"; status = "disabled";
When the OTG node was added, its reg property for its address space was missing. With commit f4f9896ac310 ("musb: sunxi: Use base address from device tree"), the OTG controller's address is derived from the device tree exclusively. The missing property results in U-boot crashing when MUSB is initialized. Fixes: b0bea6678981 ("sunxi: Add USB and R_PIO nodes to sun8i-a83t.dtsi") Signed-off-by: Chen-Yu Tsai <wens@csie.org> --- arch/arm/dts/sun8i-a83t.dtsi | 1 + 1 file changed, 1 insertion(+)