diff mbox series

imx-alsa-plugins: new package

Message ID 20180128212346.23249-1-joerg.krause@embedded.rocks
State Changes Requested
Headers show
Series imx-alsa-plugins: new package | expand

Commit Message

Jörg Krause Jan. 28, 2018, 9:23 p.m. UTC 
Freescale specific alsa-lib plugins for the i.MX processor family.

For now, the only provided plugin is:
  * Rate Converter Plugin Using Freescale ASRC Resampler

The ASRC hardware resampler can be found on i.MX53 and most i.MX 6
processors.

Signed-off-by: Jörg Krause <joerg.krause@embedded.rocks>
---
 package/freescale-imx/Config.in                    |  1 +
 package/freescale-imx/imx-alsa-plugins/Config.in   | 23 ++++++++++++++++++++++
 .../imx-alsa-plugins/imx-alsa-plugins.hash         |  3 +++
 .../imx-alsa-plugins/imx-alsa-plugins.mk           | 21 ++++++++++++++++++++
 4 files changed, 48 insertions(+)
 create mode 100644 package/freescale-imx/imx-alsa-plugins/Config.in
 create mode 100644 package/freescale-imx/imx-alsa-plugins/imx-alsa-plugins.hash
 create mode 100644 package/freescale-imx/imx-alsa-plugins/imx-alsa-plugins.mk

Comments

Marcus Folkesson Feb. 1, 2018, 8:55 a.m. UTC | #1 
Hi Jörg,

On Sun, Jan 28, 2018 at 10:23:46PM +0100, Jörg Krause wrote:
> Freescale specific alsa-lib plugins for the i.MX processor family.
> 
> For now, the only provided plugin is:
>   * Rate Converter Plugin Using Freescale ASRC Resampler
> 
> The ASRC hardware resampler can be found on i.MX53 and most i.MX 6
> processors.
> 
> Signed-off-by: Jörg Krause <joerg.krause@embedded.rocks>
> ---
>  package/freescale-imx/Config.in                    |  1 +
>  package/freescale-imx/imx-alsa-plugins/Config.in   | 23 ++++++++++++++++++++++
>  .../imx-alsa-plugins/imx-alsa-plugins.hash         |  3 +++
>  .../imx-alsa-plugins/imx-alsa-plugins.mk           | 21 ++++++++++++++++++++
>  4 files changed, 48 insertions(+)
>  create mode 100644 package/freescale-imx/imx-alsa-plugins/Config.in
>  create mode 100644 package/freescale-imx/imx-alsa-plugins/imx-alsa-plugins.hash
>  create mode 100644 package/freescale-imx/imx-alsa-plugins/imx-alsa-plugins.mk
> 
> diff --git a/package/freescale-imx/Config.in b/package/freescale-imx/Config.in
> index b5e5ab23dc..f658c46ba0 100644
> --- a/package/freescale-imx/Config.in
> +++ b/package/freescale-imx/Config.in
> @@ -69,6 +69,7 @@ config BR2_PACKAGE_FREESCALE_IMX_HAS_VIV_GPU
>  		BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX6S || \
>  		BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX7
>  
> +source "package/freescale-imx/imx-alsa-plugins/Config.in"
>  source "package/freescale-imx/imx-codec/Config.in"
>  source "package/freescale-imx/imx-kobs/Config.in"
>  source "package/freescale-imx/imx-lib/Config.in"
> diff --git a/package/freescale-imx/imx-alsa-plugins/Config.in b/package/freescale-imx/imx-alsa-plugins/Config.in
> new file mode 100644
> index 0000000000..57ce6216f3
> --- /dev/null
> +++ b/package/freescale-imx/imx-alsa-plugins/Config.in
> @@ -0,0 +1,23 @@
> +config BR2_PACKAGE_IMX_ALSA_PLUGINS
> +	bool "imx-alsa-plugins"
> +	depends on BR2_arm # Only relevant for i.MX
> +	depends on BR2_LINUX_KERNEL
> +	depends on BR2_TOOLCHAIN_HAS_THREADS # alsa-lib
> +	select BR2_PACKAGE_ALSA_LIB
> +	help
> +	  ALSA plugins specific for the Freescale i.MX platform. It
> +	  requires a kernel that includes the i.MX specific headers
> +	  to be built.
> +
> +	  The following plugins are provided so far:
> +	    * Rate Converter Plugin Using Freescale ASRC Hardware
> +	      Resampler (i.MX53 and most i.MX6)
> +
> +	  This package is provided by Freescale as-is and doesn't have
> +	  an upstream.
> +
> +comment "imx-alsa-libs needs an imx-specific Linux kernel to be built"
> +	depends on BR2_arm && !BR2_LINUX_KERNEL
> +
> +comment "imx-alsa-libs needs a toolchain w/ threads"
> +	depends on !BR2_TOOLCHAIN_HAS_THREADS

Should we not be depend on BR2_arm here as well?

depends on BR2_arm && !BR2_TOOLCHAIN_HAS_THREADS

> diff --git a/package/freescale-imx/imx-alsa-plugins/imx-alsa-plugins.hash b/package/freescale-imx/imx-alsa-plugins/imx-alsa-plugins.hash
> new file mode 100644
> index 0000000000..b0f47080ce
> --- /dev/null
> +++ b/package/freescale-imx/imx-alsa-plugins/imx-alsa-plugins.hash
> @@ -0,0 +1,3 @@
> +# Locally calculated:
> +sha256  e76a71e9166fbedeaa535fd7ebc07edc30a1e87f529ab2aa733e3603d3183ed0  imx-alsa-plugins-rel_imx_4.9.x_1.0.0_ga.tar.gz
> +sha256  32b1062f7da84967e7019d01ab805935caa7ab7321a7ced0e30ebe75e5df1670  COPYING.GPL
> diff --git a/package/freescale-imx/imx-alsa-plugins/imx-alsa-plugins.mk b/package/freescale-imx/imx-alsa-plugins/imx-alsa-plugins.mk
> new file mode 100644
> index 0000000000..9c81ff0df0
> --- /dev/null
> +++ b/package/freescale-imx/imx-alsa-plugins/imx-alsa-plugins.mk
> @@ -0,0 +1,21 @@
> +################################################################################
> +#
> +# imx-alsa-plugins
> +#
> +################################################################################
> +
> +IMX_ALSA_PLUGINS_VERSION = rel_imx_4.9.x_1.0.0_ga
> +IMX_ALSA_PLUGINS_SITE = https://source.codeaurora.org/external/imx/imx-alsa-plugins
> +IMX_ALSA_PLUGINS_SITE_METHOD = git
> +IMX_ALSA_PLUGINS_LICENSE = GPL-2.0+
> +IMX_ALSA_PLUGINS_LICENSE_FILES = COPYING.GPL
> +IMX_ALSA_PLUGINS_DEPENDENCIES = host-pkgconf alsa-lib
> +
> +# git, no configure
> +IMX_ALSA_PLUGINS_AUTORECONF = YES
> +
> +# needs access to imx-specific kernel headers
> +IMX_ALSA_PLUGINS_DEPENDENCIES += linux
> +IMX_ALSA_PLUGINS_CONF_ENV += CPPFLAGS="$(TARGET_CPPFLAGS) -idirafter $(LINUX_DIR)/include/uapi"
> +
> +$(eval $(autotools-package))
> -- 
> 2.16.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

Best regards
Marcus Folkesson
Jörg Krause Feb. 1, 2018, 9:06 a.m. UTC | #2 
Hi Marcus,

On Thu, 2018-02-01 at 09:55 +0100, Marcus Folkesson wrote:
> Hi Jörg,
> 
> On Sun, Jan 28, 2018 at 10:23:46PM +0100, Jörg Krause wrote:
> > Freescale specific alsa-lib plugins for the i.MX processor family.
> > 
> > For now, the only provided plugin is:
> >   * Rate Converter Plugin Using Freescale ASRC Resampler
> > 
> > The ASRC hardware resampler can be found on i.MX53 and most i.MX 6
> > processors.
> > 
> > Signed-off-by: Jörg Krause <joerg.krause@embedded.rocks>
> > ---
> >  package/freescale-imx/Config.in                    |  1 +
> >  package/freescale-imx/imx-alsa-plugins/Config.in   | 23 ++++++++++++++++++++++
> >  .../imx-alsa-plugins/imx-alsa-plugins.hash         |  3 +++
> >  .../imx-alsa-plugins/imx-alsa-plugins.mk           | 21 ++++++++++++++++++++
> >  4 files changed, 48 insertions(+)
> >  create mode 100644 package/freescale-imx/imx-alsa-plugins/Config.in
> >  create mode 100644 package/freescale-imx/imx-alsa-plugins/imx-alsa-plugins.hash
> >  create mode 100644 package/freescale-imx/imx-alsa-plugins/imx-alsa-plugins.mk
> > 
> > diff --git a/package/freescale-imx/Config.in b/package/freescale-imx/Config.in
> > index b5e5ab23dc..f658c46ba0 100644
> > --- a/package/freescale-imx/Config.in
> > +++ b/package/freescale-imx/Config.in
> > @@ -69,6 +69,7 @@ config BR2_PACKAGE_FREESCALE_IMX_HAS_VIV_GPU
> >  		BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX6S || \
> >  		BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX7
> >  
> > +source "package/freescale-imx/imx-alsa-plugins/Config.in"
> >  source "package/freescale-imx/imx-codec/Config.in"
> >  source "package/freescale-imx/imx-kobs/Config.in"
> >  source "package/freescale-imx/imx-lib/Config.in"
> > diff --git a/package/freescale-imx/imx-alsa-plugins/Config.in b/package/freescale-imx/imx-alsa-plugins/Config.in
> > new file mode 100644
> > index 0000000000..57ce6216f3
> > --- /dev/null
> > +++ b/package/freescale-imx/imx-alsa-plugins/Config.in
> > @@ -0,0 +1,23 @@
> > +config BR2_PACKAGE_IMX_ALSA_PLUGINS
> > +	bool "imx-alsa-plugins"
> > +	depends on BR2_arm # Only relevant for i.MX
> > +	depends on BR2_LINUX_KERNEL
> > +	depends on BR2_TOOLCHAIN_HAS_THREADS # alsa-lib
> > +	select BR2_PACKAGE_ALSA_LIB
> > +	help
> > +	  ALSA plugins specific for the Freescale i.MX platform. It
> > +	  requires a kernel that includes the i.MX specific headers
> > +	  to be built.
> > +
> > +	  The following plugins are provided so far:
> > +	    * Rate Converter Plugin Using Freescale ASRC Hardware
> > +	      Resampler (i.MX53 and most i.MX6)
> > +
> > +	  This package is provided by Freescale as-is and doesn't have
> > +	  an upstream.
> > +
> > +comment "imx-alsa-libs needs an imx-specific Linux kernel to be built"
> > +	depends on BR2_arm && !BR2_LINUX_KERNEL
> > +
> > +comment "imx-alsa-libs needs a toolchain w/ threads"
> > +	depends on !BR2_TOOLCHAIN_HAS_THREADS
> 
> Should we not be depend on BR2_arm here as well?

There are two comments. One for the imx-specific Linux kernel and one
for the threads-dependency.

> depends on BR2_arm && !BR2_TOOLCHAIN_HAS_THREADS
> 
> > diff --git a/package/freescale-imx/imx-alsa-plugins/imx-alsa-plugins.hash b/package/freescale-imx/imx-alsa-plugins/imx-alsa-plugins.hash
> > new file mode 100644
> > index 0000000000..b0f47080ce
> > --- /dev/null
> > +++ b/package/freescale-imx/imx-alsa-plugins/imx-alsa-plugins.hash
> > @@ -0,0 +1,3 @@
> > +# Locally calculated:
> > +sha256  e76a71e9166fbedeaa535fd7ebc07edc30a1e87f529ab2aa733e3603d3183ed0  imx-alsa-plugins-rel_imx_4.9.x_1.0.0_ga.tar.gz
> > +sha256  32b1062f7da84967e7019d01ab805935caa7ab7321a7ced0e30ebe75e5df1670  COPYING.GPL
> > diff --git a/package/freescale-imx/imx-alsa-plugins/imx-alsa-plugins.mk b/package/freescale-imx/imx-alsa-plugins/imx-alsa-plugins.mk
> > new file mode 100644
> > index 0000000000..9c81ff0df0
> > --- /dev/null
> > +++ b/package/freescale-imx/imx-alsa-plugins/imx-alsa-plugins.mk
> > @@ -0,0 +1,21 @@
> > +################################################################################
> > +#
> > +# imx-alsa-plugins
> > +#
> > +################################################################################
> > +
> > +IMX_ALSA_PLUGINS_VERSION = rel_imx_4.9.x_1.0.0_ga
> > +IMX_ALSA_PLUGINS_SITE = https://source.codeaurora.org/external/imx/imx-alsa-plugins
> > +IMX_ALSA_PLUGINS_SITE_METHOD = git
> > +IMX_ALSA_PLUGINS_LICENSE = GPL-2.0+
> > +IMX_ALSA_PLUGINS_LICENSE_FILES = COPYING.GPL
> > +IMX_ALSA_PLUGINS_DEPENDENCIES = host-pkgconf alsa-lib
> > +
> > +# git, no configure
> > +IMX_ALSA_PLUGINS_AUTORECONF = YES
> > +
> > +# needs access to imx-specific kernel headers
> > +IMX_ALSA_PLUGINS_DEPENDENCIES += linux
> > +IMX_ALSA_PLUGINS_CONF_ENV += CPPFLAGS="$(TARGET_CPPFLAGS) -idirafter $(LINUX_DIR)/include/uapi"
> > +
> > +$(eval $(autotools-package))
> > -- 
> > 2.16.1
> > 
> > _______________________________________________
> > buildroot mailing list
> > buildroot@busybox.net
> > http://lists.busybox.net/mailman/listinfo/buildroot
> 
> Best regards
> Marcus Folkesson

Best regards
Jörg Krause
Baruch Siach Feb. 1, 2018, 9:20 a.m. UTC | #3 
Hi Jörg,

On Thu, Feb 01, 2018 at 10:06:51AM +0100, Jörg Krause wrote:
> On Thu, 2018-02-01 at 09:55 +0100, Marcus Folkesson wrote:
> > On Sun, Jan 28, 2018 at 10:23:46PM +0100, Jörg Krause wrote: 
> > > diff --git a/package/freescale-imx/imx-alsa-plugins/Config.in b/package/freescale-imx/imx-alsa-plugins/Config.in
> > > new file mode 100644
> > > index 0000000000..57ce6216f3
> > > --- /dev/null
> > > +++ b/package/freescale-imx/imx-alsa-plugins/Config.in
> > > @@ -0,0 +1,23 @@
> > > +config BR2_PACKAGE_IMX_ALSA_PLUGINS
> > > +	bool "imx-alsa-plugins"
> > > +	depends on BR2_arm # Only relevant for i.MX
> > > +	depends on BR2_LINUX_KERNEL
> > > +	depends on BR2_TOOLCHAIN_HAS_THREADS # alsa-lib
> > > +	select BR2_PACKAGE_ALSA_LIB
> > > +	help
> > > +	  ALSA plugins specific for the Freescale i.MX platform. It
> > > +	  requires a kernel that includes the i.MX specific headers
> > > +	  to be built.
> > > +
> > > +	  The following plugins are provided so far:
> > > +	    * Rate Converter Plugin Using Freescale ASRC Hardware
> > > +	      Resampler (i.MX53 and most i.MX6)
> > > +
> > > +	  This package is provided by Freescale as-is and doesn't have
> > > +	  an upstream.
> > > +
> > > +comment "imx-alsa-libs needs an imx-specific Linux kernel to be built"
> > > +	depends on BR2_arm && !BR2_LINUX_KERNEL
> > > +
> > > +comment "imx-alsa-libs needs a toolchain w/ threads"
> > > +	depends on !BR2_TOOLCHAIN_HAS_THREADS
> > 
> > Should we not be depend on BR2_arm here as well?
> 
> There are two comments. One for the imx-specific Linux kernel and one
> for the threads-dependency.

But we don't want the threads dependency comment to show when the architecture 
is something other than arm. This is because adding threads support would only 
eliminate the comment, but the imx-alsa-plugins package will still not be 
selectable.

We usually do this in a separate 'depends' line, so:

comment "imx-alsa-libs needs a toolchain w/ threads"
    depends on BR2_arm
    depends on !BR2_TOOLCHAIN_HAS_THREADS

baruch
Jörg Krause Feb. 1, 2018, 10:03 a.m. UTC | #4 
Hi Baruch,

On Thu, 2018-02-01 at 11:20 +0200, Baruch Siach wrote:
> Hi Jörg,
> 
> On Thu, Feb 01, 2018 at 10:06:51AM +0100, Jörg Krause wrote:
> > On Thu, 2018-02-01 at 09:55 +0100, Marcus Folkesson wrote:
> > > On Sun, Jan 28, 2018 at 10:23:46PM +0100, Jörg Krause wrote: 
> > > > diff --git a/package/freescale-imx/imx-alsa-plugins/Config.in b/package/freescale-imx/imx-alsa-plugins/Config.in
> > > > new file mode 100644
> > > > index 0000000000..57ce6216f3
> > > > --- /dev/null
> > > > +++ b/package/freescale-imx/imx-alsa-plugins/Config.in
> > > > @@ -0,0 +1,23 @@
> > > > +config BR2_PACKAGE_IMX_ALSA_PLUGINS
> > > > +	bool "imx-alsa-plugins"
> > > > +	depends on BR2_arm # Only relevant for i.MX
> > > > +	depends on BR2_LINUX_KERNEL
> > > > +	depends on BR2_TOOLCHAIN_HAS_THREADS # alsa-lib
> > > > +	select BR2_PACKAGE_ALSA_LIB
> > > > +	help
> > > > +	  ALSA plugins specific for the Freescale i.MX platform. It
> > > > +	  requires a kernel that includes the i.MX specific headers
> > > > +	  to be built.
> > > > +
> > > > +	  The following plugins are provided so far:
> > > > +	    * Rate Converter Plugin Using Freescale ASRC Hardware
> > > > +	      Resampler (i.MX53 and most i.MX6)
> > > > +
> > > > +	  This package is provided by Freescale as-is and doesn't have
> > > > +	  an upstream.
> > > > +
> > > > +comment "imx-alsa-libs needs an imx-specific Linux kernel to be built"
> > > > +	depends on BR2_arm && !BR2_LINUX_KERNEL
> > > > +
> > > > +comment "imx-alsa-libs needs a toolchain w/ threads"
> > > > +	depends on !BR2_TOOLCHAIN_HAS_THREADS
> > > 
> > > Should we not be depend on BR2_arm here as well?
> > 
> > There are two comments. One for the imx-specific Linux kernel and one
> > for the threads-dependency.
> 
> But we don't want the threads dependency comment to show when the architecture 
> is something other than arm. This is because adding threads support would only 
> eliminate the comment, but the imx-alsa-plugins package will still not be 
> selectable.
> 
> We usually do this in a separate 'depends' line, so:
> 
> comment "imx-alsa-libs needs a toolchain w/ threads"
>     depends on BR2_arm
>     depends on !BR2_TOOLCHAIN_HAS_THREADS
> 
> baruch
> 

I see! I'll send a new version of the patch.

Jörg
diff mbox series

Patch

diff --git a/package/freescale-imx/Config.in b/package/freescale-imx/Config.in
index b5e5ab23dc..f658c46ba0 100644
--- a/package/freescale-imx/Config.in
+++ b/package/freescale-imx/Config.in
@@ -69,6 +69,7 @@  config BR2_PACKAGE_FREESCALE_IMX_HAS_VIV_GPU
 		BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX6S || \
 		BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX7
 
+source "package/freescale-imx/imx-alsa-plugins/Config.in"
 source "package/freescale-imx/imx-codec/Config.in"
 source "package/freescale-imx/imx-kobs/Config.in"
 source "package/freescale-imx/imx-lib/Config.in"
diff --git a/package/freescale-imx/imx-alsa-plugins/Config.in b/package/freescale-imx/imx-alsa-plugins/Config.in
new file mode 100644
index 0000000000..57ce6216f3
--- /dev/null
+++ b/package/freescale-imx/imx-alsa-plugins/Config.in
@@ -0,0 +1,23 @@ 
+config BR2_PACKAGE_IMX_ALSA_PLUGINS
+	bool "imx-alsa-plugins"
+	depends on BR2_arm # Only relevant for i.MX
+	depends on BR2_LINUX_KERNEL
+	depends on BR2_TOOLCHAIN_HAS_THREADS # alsa-lib
+	select BR2_PACKAGE_ALSA_LIB
+	help
+	  ALSA plugins specific for the Freescale i.MX platform. It
+	  requires a kernel that includes the i.MX specific headers
+	  to be built.
+
+	  The following plugins are provided so far:
+	    * Rate Converter Plugin Using Freescale ASRC Hardware
+	      Resampler (i.MX53 and most i.MX6)
+
+	  This package is provided by Freescale as-is and doesn't have
+	  an upstream.
+
+comment "imx-alsa-libs needs an imx-specific Linux kernel to be built"
+	depends on BR2_arm && !BR2_LINUX_KERNEL
+
+comment "imx-alsa-libs needs a toolchain w/ threads"
+	depends on !BR2_TOOLCHAIN_HAS_THREADS
diff --git a/package/freescale-imx/imx-alsa-plugins/imx-alsa-plugins.hash b/package/freescale-imx/imx-alsa-plugins/imx-alsa-plugins.hash
new file mode 100644
index 0000000000..b0f47080ce
--- /dev/null
+++ b/package/freescale-imx/imx-alsa-plugins/imx-alsa-plugins.hash
@@ -0,0 +1,3 @@ 
+# Locally calculated:
+sha256  e76a71e9166fbedeaa535fd7ebc07edc30a1e87f529ab2aa733e3603d3183ed0  imx-alsa-plugins-rel_imx_4.9.x_1.0.0_ga.tar.gz
+sha256  32b1062f7da84967e7019d01ab805935caa7ab7321a7ced0e30ebe75e5df1670  COPYING.GPL
diff --git a/package/freescale-imx/imx-alsa-plugins/imx-alsa-plugins.mk b/package/freescale-imx/imx-alsa-plugins/imx-alsa-plugins.mk
new file mode 100644
index 0000000000..9c81ff0df0
--- /dev/null
+++ b/package/freescale-imx/imx-alsa-plugins/imx-alsa-plugins.mk
@@ -0,0 +1,21 @@ 
+################################################################################
+#
+# imx-alsa-plugins
+#
+################################################################################
+
+IMX_ALSA_PLUGINS_VERSION = rel_imx_4.9.x_1.0.0_ga
+IMX_ALSA_PLUGINS_SITE = https://source.codeaurora.org/external/imx/imx-alsa-plugins
+IMX_ALSA_PLUGINS_SITE_METHOD = git
+IMX_ALSA_PLUGINS_LICENSE = GPL-2.0+
+IMX_ALSA_PLUGINS_LICENSE_FILES = COPYING.GPL
+IMX_ALSA_PLUGINS_DEPENDENCIES = host-pkgconf alsa-lib
+
+# git, no configure
+IMX_ALSA_PLUGINS_AUTORECONF = YES
+
+# needs access to imx-specific kernel headers
+IMX_ALSA_PLUGINS_DEPENDENCIES += linux
+IMX_ALSA_PLUGINS_CONF_ENV += CPPFLAGS="$(TARGET_CPPFLAGS) -idirafter $(LINUX_DIR)/include/uapi"
+
+$(eval $(autotools-package))