diff mbox series

[U-Boot] spl: include timezone in banner

Message ID 20180104062211.1761-1-klaus.goger@theobroma-systems.com
State Accepted
Delegated to: Tom Rini
Headers show
Series [U-Boot] spl: include timezone in banner | expand

Commit Message

Klaus Goger Jan. 4, 2018, 6:22 a.m. UTC 
Include the timezone in the SPL banner so the timestamp matches with
that from u-boot proper.

Signed-off-by: Klaus Goger <klaus.goger@theobroma-systems.com>
Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>

---
I know this is kind of a nitpick patch and we don't really have any space
to waste in SPL. But the inconsistency annoyed me after wasting some time 
figuring out why one of my testcases always failed due a regex not matching. 

The additional 6 bytes don't break any builds as verified with Travis-CI:
https://travis-ci.org/ptomsich/u-boot-rockchip/builds/324694323

 common/spl/spl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Tom Rini Jan. 29, 2018, 8:20 p.m. UTC | #1 
On Thu, Jan 04, 2018 at 07:22:11AM +0100, Klaus Goger wrote:

> Include the timezone in the SPL banner so the timestamp matches with
> that from u-boot proper.
> 
> Signed-off-by: Klaus Goger <klaus.goger@theobroma-systems.com>
> Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>

Now that we have an option to disable this print entirely, applied to
u-boot/master, thanks!
diff mbox series

Patch

diff --git a/common/spl/spl.c b/common/spl/spl.c
index 76c1963611..660e4011e6 100644
--- a/common/spl/spl.c
+++ b/common/spl/spl.c
@@ -478,7 +478,7 @@  void preloader_console_init(void)
 	gd->have_console = 1;
 
 	puts("\nU-Boot SPL " PLAIN_VERSION " (" U_BOOT_DATE " - " \
-			U_BOOT_TIME ")\n");
+			U_BOOT_TIME " " U_BOOT_TZ ")\n");
 #ifdef CONFIG_SPL_DISPLAY_PRINT
 	spl_display_print();
 #endif