| Message ID | 1496397921-1713-1-git-send-email-gottfried.haider@gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
On Fri, Jun 02, 2017 at 10:05:21AM +0000, Gottfried Haider wrote: > Notifications for devices without bus or class set get dropped by > dev_uevent_filter. Adding the class to the exported child matches > what the gpio subsystem is doing. > > With this change exporting a channel triggers a udev event, which > gives userspace a chance to fixup permissions and makes it possible > for non-root users to make use of the pwm subsystem. > > Signed-off-by: Gottfried Haider <gottfried.haider@gmail.com> > CC: Thierry Reding <thierry.reding@gmail.com> > CC: H Hartley Sweeten <hsweeten@visionengravers.com> > CC: linux-pwm@vger.kernel.org > CC: linux-arm-kernel@lists.infradead.org > CC: linux-rpi-kernel@lists.infradead.org > --- > drivers/pwm/sysfs.c | 1 + > 1 file changed, 1 insertion(+) Sorry for the long delay, applied to for-next now. Thanks, Thierry
diff --git a/drivers/pwm/sysfs.c b/drivers/pwm/sysfs.c index a813239..83f2b0b 100644 --- a/drivers/pwm/sysfs.c +++ b/drivers/pwm/sysfs.c @@ -263,6 +263,7 @@ static int pwm_export_child(struct device *parent, struct pwm_device *pwm) export->pwm = pwm; mutex_init(&export->lock); + export->child.class = parent->class; export->child.release = pwm_export_release; export->child.parent = parent; export->child.devt = MKDEV(0, 0);
Notifications for devices without bus or class set get dropped by dev_uevent_filter. Adding the class to the exported child matches what the gpio subsystem is doing. With this change exporting a channel triggers a udev event, which gives userspace a chance to fixup permissions and makes it possible for non-root users to make use of the pwm subsystem. Signed-off-by: Gottfried Haider <gottfried.haider@gmail.com> CC: Thierry Reding <thierry.reding@gmail.com> CC: H Hartley Sweeten <hsweeten@visionengravers.com> CC: linux-pwm@vger.kernel.org CC: linux-arm-kernel@lists.infradead.org CC: linux-rpi-kernel@lists.infradead.org --- drivers/pwm/sysfs.c | 1 + 1 file changed, 1 insertion(+)