| Message ID | 1507775912-22402-2-git-send-email-linyunsheng@huawei.com |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | David Miller |
| Headers | show |
| Series | Add mqprio hardware offload support in hns3 driver | expand |
> When a driver supports both dcb and hardware offloaded mqprio, and > user is running mqprio and dcb tool concurrently, the configuration > set by each tool may be conflicted with each other because the dcb (for second 'each') s/each/the > and mqprio may be using the same hardwere offload component and share s/hardwere/hardware > the tc system in the network stack. > > This patch adds a new offload type to indicate that the underlying > driver offload prio mapping as part of DCB. If the driver would be 'should' offload > incapable of that it would refuse the offload. User would then have > to explicitly request that qdisc offload.
Hi, Yuval On 2017/10/13 4:10, Yuval Mintz wrote: >> When a driver supports both dcb and hardware offloaded mqprio, and >> user is running mqprio and dcb tool concurrently, the configuration >> set by each tool may be conflicted with each other because the dcb > (for second 'each') s/each/the > Will do, Thanks >> and mqprio may be using the same hardwere offload component and share > s/hardwere/hardware Will do, Thanks > >> the tc system in the network stack. >> >> This patch adds a new offload type to indicate that the underlying >> driver offload prio mapping as part of DCB. If the driver would be > 'should' offload Will do, Thanks > >> incapable of that it would refuse the offload. User would then have >> to explicitly request that qdisc offload. > > >
diff --git a/include/uapi/linux/pkt_sched.h b/include/uapi/linux/pkt_sched.h index 099bf55..8016027 100644 --- a/include/uapi/linux/pkt_sched.h +++ b/include/uapi/linux/pkt_sched.h @@ -620,6 +620,7 @@ struct tc_drr_stats { enum { TC_MQPRIO_HW_OFFLOAD_NONE, /* no offload requested */ TC_MQPRIO_HW_OFFLOAD_TCS, /* offload TCs, no queue counts */ + TC_MQPRIO_HW_OFFLOAD_DCB, /* offload shared by DCB */ __TC_MQPRIO_HW_OFFLOAD_MAX };
When a driver supports both dcb and hardware offloaded mqprio, and user is running mqprio and dcb tool concurrently, the configuration set by each tool may be conflicted with each other because the dcb and mqprio may be using the same hardwere offload component and share the tc system in the network stack. This patch adds a new offload type to indicate that the underlying driver offload prio mapping as part of DCB. If the driver would be incapable of that it would refuse the offload. User would then have to explicitly request that qdisc offload. Signed-off-by: Yunsheng Lin <linyunsheng@huawei.com> Suggested-by: Yuval Mintz <yuvalm@mellanox.com> --- include/uapi/linux/pkt_sched.h | 1 + 1 file changed, 1 insertion(+)