Message ID | 20171010133546.98061-1-antony@phenome.org |
---|---|
State | Superseded |
Delegated to: | Jagannadha Sutradharudu Teki |
Headers | show |
Series | [U-Boot,v4,1/2] arm64: sun50i-h5.dtsi : add h5 & a64 compatible to mmc[0-2] | expand |
Shouldn't we just be syncing changes to the DT from the kernel? On Tue, Oct 10, 2017 at 2:35 PM, Antony Antony <antony@phenome.org> wrote: > add more specific, Allwinner H5 SoC, compaitable to mmc0,1,2 > current one comes from sun8i-h3.dtsi > compatible = "allwinner,sun7i-a20-mmc", "allwinner,sun5i-a13-mmc"; > > Signed-off-by: Antony Antony <antony@phenome.org> > --- > arch/arm/dts/sun50i-h5.dtsi | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/arch/arm/dts/sun50i-h5.dtsi b/arch/arm/dts/sun50i-h5.dtsi > index 4904c18..1f4c1d1 100644 > --- a/arch/arm/dts/sun50i-h5.dtsi > +++ b/arch/arm/dts/sun50i-h5.dtsi > @@ -75,3 +75,15 @@ > &gic { > compatible = "arm,gic-400"; > }; > + > +&mmc0 { > + compatible = "allwinner,sun50i-h5-mmc", "allwinner,sun50i-a64-mmc"; > +}; > + > +&mmc1 { > + compatible = "allwinner,sun50i-h5-mmc", "allwinner,sun50i-a64-mmc"; > +}; > + > +&mmc2 { > + compatible = "allwinner,sun50i-h5-mmc", "allwinner,sun50i-a64-mmc"; > +}; > -- > 2.7.4 > > _______________________________________________ > U-Boot mailing list > U-Boot@lists.denx.de > https://lists.denx.de/listinfo/u-boot
On Tue, Oct 10, 2017 at 7:18 PM, Peter Robinson <pbrobinson@gmail.com> wrote:
> Shouldn't we just be syncing changes to the DT from the kernel?
And add last merge commit details on commit message.
thanks!
On Tue, Oct 10, 2017 at 07:21:57PM +0530, Jagan Teki wrote: > On Tue, Oct 10, 2017 at 7:18 PM, Peter Robinson <pbrobinson@gmail.com> wrote: > > Shouldn't we just be syncing changes to the DT from the kernel? > I guess syncing could possibly solve the problem! Kernel DTSI got the compiltables I need from the begining. The diff looks big to me. I am not sure yet, I understand all changes. Anyone who would like to sync the two files? Or willing to help me? diff ~/u-boot/arch/arm/dts/sun50i-h5.dtsi ~/linux/arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi > And add last merge commit details on commit message. A good point. I am wondering what is the practice for this u-boot commit message. I do not see commit IDs mentioned. A few commits seems to mention kernel version in the commit message. -antony
On Tue, Oct 10, 2017 at 10:48 PM, Antony Antony <antony@phenome.org> wrote: > On Tue, Oct 10, 2017 at 07:21:57PM +0530, Jagan Teki wrote: >> On Tue, Oct 10, 2017 at 7:18 PM, Peter Robinson <pbrobinson@gmail.com> wrote: >> > Shouldn't we just be syncing changes to the DT from the kernel? >> > > I guess syncing could possibly solve the problem! Kernel DTSI got the > compiltables I need from the begining. > > The diff looks big to me. I am not sure yet, I understand all changes. > Anyone who would like to sync the two files? Or willing to help me? > > diff ~/u-boot/arch/arm/dts/sun50i-h5.dtsi > ~/linux/arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi > >> And add last merge commit details on commit message. > > A good point. I am wondering what is the practice for this u-boot commit > message. I do not see commit IDs mentioned. A few commits seems to mention > kernel version in the commit message. Getting merge ID details can help to check what details got synced, not a big deal. thanks!
diff --git a/arch/arm/dts/sun50i-h5.dtsi b/arch/arm/dts/sun50i-h5.dtsi index 4904c18..1f4c1d1 100644 --- a/arch/arm/dts/sun50i-h5.dtsi +++ b/arch/arm/dts/sun50i-h5.dtsi @@ -75,3 +75,15 @@ &gic { compatible = "arm,gic-400"; }; + +&mmc0 { + compatible = "allwinner,sun50i-h5-mmc", "allwinner,sun50i-a64-mmc"; +}; + +&mmc1 { + compatible = "allwinner,sun50i-h5-mmc", "allwinner,sun50i-a64-mmc"; +}; + +&mmc2 { + compatible = "allwinner,sun50i-h5-mmc", "allwinner,sun50i-a64-mmc"; +};
add more specific, Allwinner H5 SoC, compaitable to mmc0,1,2 current one comes from sun8i-h3.dtsi compatible = "allwinner,sun7i-a20-mmc", "allwinner,sun5i-a13-mmc"; Signed-off-by: Antony Antony <antony@phenome.org> --- arch/arm/dts/sun50i-h5.dtsi | 12 ++++++++++++ 1 file changed, 12 insertions(+)