| Message ID | 1507502807-19767-1-git-send-email-chris.gekas@gmail.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
| Series | qed: Delete redundant check on dcb_app priority | expand |
> dcb_app priority is unsigned thus checking whether it is less than zero > is redundant. > > Signed-off-by: Christos Gkekas <chris.gekas@gmail.com> Thanks Acked-By: Tomer Tayar <Tomer.Tayar@cavium.com>
From: Christos Gkekas <chris.gekas@gmail.com> Date: Sun, 8 Oct 2017 23:46:47 +0100 > dcb_app priority is unsigned thus checking whether it is less than zero > is redundant. > > Signed-off-by: Christos Gkekas <chris.gekas@gmail.com> Applied to net-next.
diff --git a/drivers/net/ethernet/qlogic/qed/qed_dcbx.c b/drivers/net/ethernet/qlogic/qed/qed_dcbx.c index 8f6ccc0..6e15d3c 100644 --- a/drivers/net/ethernet/qlogic/qed/qed_dcbx.c +++ b/drivers/net/ethernet/qlogic/qed/qed_dcbx.c @@ -2308,7 +2308,7 @@ static int qed_dcbnl_ieee_setapp(struct qed_dev *cdev, struct dcb_app *app) DP_VERBOSE(hwfn, QED_MSG_DCB, "selector = %d protocol = %d pri = %d\n", app->selector, app->protocol, app->priority); - if (app->priority < 0 || app->priority >= QED_MAX_PFC_PRIORITIES) { + if (app->priority >= QED_MAX_PFC_PRIORITIES) { DP_INFO(hwfn, "Invalid priority %d\n", app->priority); return -EINVAL; }
dcb_app priority is unsigned thus checking whether it is less than zero is redundant. Signed-off-by: Christos Gkekas <chris.gekas@gmail.com> --- drivers/net/ethernet/qlogic/qed/qed_dcbx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)