From patchwork Sun Oct 8 22:46:47 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christos Gkekas X-Patchwork-Id: 823046 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="MxFbQpBB"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3y9JQy0bdCz9t3Z for ; Mon, 9 Oct 2017 09:47:06 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753522AbdJHWqy (ORCPT ); Sun, 8 Oct 2017 18:46:54 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:53596 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752060AbdJHWqw (ORCPT ); Sun, 8 Oct 2017 18:46:52 -0400 Received: by mail-wm0-f66.google.com with SMTP id q132so18952914wmd.2; Sun, 08 Oct 2017 15:46:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=ZNcBmC30M9IejU0NXf4iqjfc5K933pWMsKIF3rQEQH0=; b=MxFbQpBBxirPqRcP+D13IZ0Xuns3tB0GqmeeYKFovNCFUeDSJJqXtCDZN6KiB1JwhF CYifGSw8kIllbtu6f6W+wN+MT4FnakZ58X8oBEWK5OfclL3ZREg6fotZHtDx4XZ+y+Gb KkTHFLikAhD1kbnCEZHIwEM497Zvvinv3v5VhzzyDHIUYJDxlRa1O5ej8yT0NGl3WP95 WxJ9B6pIUHRYYM1Vx2nLTwnfyyADwmCmt8BqEYOYKXdqWLRS3pBSW3j1m0HUZyjMnY30 V81iYUXkcANeUxntSzvnAtvWSbk39GDjT1+gIuCmwRMnsQ5mVTrF+HHdHKvawg2EtbJH ocFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=ZNcBmC30M9IejU0NXf4iqjfc5K933pWMsKIF3rQEQH0=; b=WhlFedUzB+UKqComFgAa0gcwyBPi4sWF7DUx4BZfL4icPIMbLMPy9W5vCAWo5fcS0Z kQEUKWLT7S7a3BT5oYrM2sULwquSSTVYlAFVozUkgBvo/Ek83G9hdTc0FtYioQ7X3arS Abt518gH16f4HFizNsduSVJAnXmYdJGkgPxwNY+oBTOp7/v1CxnmClVvwuzWukyaZ1cx yVAS2+oG8zOOdOGEUJoLGBwBtRfa9oAAUcbHZjPjNvrQyDTesAK8iGfSd8VdHUcqrVkY f7BbZk3rdPtJfarpJrDvOH2x6Sn8nzMF081ij2XWSV4NkjfpmIxGajrAZ9h1QRnUvfzh O33g== X-Gm-Message-State: AMCzsaXrEcVjvSvOE5aemWvdiidPbm8i0Gd1vRkTBtnS29LE4FLh0NyA XN03y6Cqmb8Ufq7OC2bXT8HoaVkHg90= X-Google-Smtp-Source: AOwi7QAPujh0S5ulZqdMWlsUDVA7X9NBtXAPRurfV20uslqCOmL4GLIHG4ImTwqGQ5vwG93H+RDwvA== X-Received: by 10.28.145.197 with SMTP id t188mr6292688wmd.136.1507502811265; Sun, 08 Oct 2017 15:46:51 -0700 (PDT) Received: from inspiron ([2a02:c7d:5e0c:c300:61ec:ecf7:55fa:ca9a]) by smtp.gmail.com with ESMTPSA id 9sm4909002wml.24.2017.10.08.15.46.50 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sun, 08 Oct 2017 15:46:50 -0700 (PDT) From: Christos Gkekas To: Ariel Elior , everest-linux-l2@cavium.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Christos Gkekas Subject: [PATCH] qed: Delete redundant check on dcb_app priority Date: Sun, 8 Oct 2017 23:46:47 +0100 Message-Id: <1507502807-19767-1-git-send-email-chris.gekas@gmail.com> X-Mailer: git-send-email 2.7.4 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org dcb_app priority is unsigned thus checking whether it is less than zero is redundant. Signed-off-by: Christos Gkekas Acked-By: Tomer Tayar --- drivers/net/ethernet/qlogic/qed/qed_dcbx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/qlogic/qed/qed_dcbx.c b/drivers/net/ethernet/qlogic/qed/qed_dcbx.c index 8f6ccc0..6e15d3c 100644 --- a/drivers/net/ethernet/qlogic/qed/qed_dcbx.c +++ b/drivers/net/ethernet/qlogic/qed/qed_dcbx.c @@ -2308,7 +2308,7 @@ static int qed_dcbnl_ieee_setapp(struct qed_dev *cdev, struct dcb_app *app) DP_VERBOSE(hwfn, QED_MSG_DCB, "selector = %d protocol = %d pri = %d\n", app->selector, app->protocol, app->priority); - if (app->priority < 0 || app->priority >= QED_MAX_PFC_PRIORITIES) { + if (app->priority >= QED_MAX_PFC_PRIORITIES) { DP_INFO(hwfn, "Invalid priority %d\n", app->priority); return -EINVAL; }