Message ID | AANLkTi=sNROOU7U5dtygf20EniW67JNM9ezYn2nFLaM-@mail.gmail.com |
---|---|
State | Accepted |
Delegated to: | Tim Gardner |
Headers | show |
On 11/18/2010 03:26 PM, Manoj Iyer wrote: > git://kernel.ubuntu.com/git/manjo/ubuntu-maverick.git lp677210 You haven't figured out the path encoding yet. If you pay attention to the results of your 'git request-pull' command, it will tell you if things are not right. Your upstream pull request is similarly borked. git://kernel.ubuntu.com/manjo/ubuntu-maverick.git lp677210 Acked-by: Tim Gardner <tim.gardner@canonical.com>
Tim, Thanks for pointing that out, sorry my bad. will send ping upstream with correction as well. On Thu, Nov 18, 2010 at 10:24 PM, Tim Gardner <tim.gardner@canonical.com> wrote: > On 11/18/2010 03:26 PM, Manoj Iyer wrote: >> >> git://kernel.ubuntu.com/git/manjo/ubuntu-maverick.git lp677210 > > You haven't figured out the path encoding yet. If you pay attention to the > results of your 'git request-pull' command, it will tell you if things are > not right. Your upstream pull request is similarly borked. > > git://kernel.ubuntu.com/manjo/ubuntu-maverick.git lp677210 > > Acked-by: Tim Gardner <tim.gardner@canonical.com> > > -- > Tim Gardner tim.gardner@canonical.com >
On 2010-11-18 23:26, Manoj Iyer wrote: > SRU JUSTIFICATION > =================== > No sound is played though external headphones on Thinkpad Edge 11. > This patch adds quick to enable that. > > SRU TESTING > ============= > This patch was tested by me on a thinkpad edge 11 and found to work. A > test kernel is available in > http://kernel.ubuntu.com/~manjo/maveric/lp675728/ > > The following changes since commit 9b07876e0a5eddb635ca4c11240980b9795582ee: > Manoj Iyer (1): > UBUNTU: SAUCE: Enable jack sense for Thinkpad Edge 11 > > are available in the git repository at: > > git://kernel.ubuntu.com/git/manjo/ubuntu-maverick.git lp677210 > > > From 9b07876e0a5eddb635ca4c11240980b9795582ee Mon Sep 17 00:00:00 2001 > From: Manoj Iyer<manoj.iyer@canonical.com> > Date: Thu, 18 Nov 2010 22:18:16 +0000 > Subject: [PATCH] UBUNTU: SAUCE: Enable jack sense for Thinkpad Edge 11 > > submitted upstream http://lkml.org/lkml/2010/11/18/605 Hi Manoj and thanks for the patch! The recommended upstream in this case is to send your patch to the alsa-devel mailinglist, with cc to Takashi Iwai <tiwai@suse.de> (don't forget the last one or it won't get picked up). As for the patch itself, I have no objections. Regression risk is very low as Conexant doesn't have much of an generic/auto-parser anyway. Acked-by: David Henningsson <david.henningsson@canonical.com>
On 11/18/2010 03:26 PM, Manoj Iyer wrote: > SRU JUSTIFICATION > =================== > No sound is played though external headphones on Thinkpad Edge 11. > This patch adds quick to enable that. > > SRU TESTING > ============= > This patch was tested by me on a thinkpad edge 11 and found to work. A > test kernel is available in > http://kernel.ubuntu.com/~manjo/maveric/lp675728/ > > The following changes since commit 9b07876e0a5eddb635ca4c11240980b9795582ee: > Manoj Iyer (1): > UBUNTU: SAUCE: Enable jack sense for Thinkpad Edge 11 > > are available in the git repository at: > > git://kernel.ubuntu.com/git/manjo/ubuntu-maverick.git lp677210 > > > From 9b07876e0a5eddb635ca4c11240980b9795582ee Mon Sep 17 00:00:00 2001 > From: Manoj Iyer<manoj.iyer@canonical.com> > Date: Thu, 18 Nov 2010 22:18:16 +0000 > Subject: [PATCH] UBUNTU: SAUCE: Enable jack sense for Thinkpad Edge 11 > > submitted upstream http://lkml.org/lkml/2010/11/18/605 > > BugLink: http://bugs.launchpad.net/bugs/677210 > > Signed-off-by: Manoj Iyer<manoj.iyer@canonical.com> > --- > sound/pci/hda/patch_conexant.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/sound/pci/hda/patch_conexant.c b/sound/pci/hda/patch_conexant.c > index 15ba418..301d51f 100644 > --- a/sound/pci/hda/patch_conexant.c > +++ b/sound/pci/hda/patch_conexant.c > @@ -3038,6 +3038,7 @@ static struct snd_pci_quirk cxt5066_cfg_tbl[] = { > SND_PCI_QUIRK(0x17aa, 0x20f2, "Lenovo T400s", CXT5066_THINKPAD), > SND_PCI_QUIRK(0x17aa, 0x21b2, "Thinkpad X100e", CXT5066_IDEAPAD), > SND_PCI_QUIRK(0x17aa, 0x21b3, "Thinkpad Edge 13 (197)", > CXT5066_IDEAPAD), > + SND_PCI_QUIRK(0x17aa, 0x21c8, "Thinkpad Edge 11", CXT5066_THINKPAD), > SND_PCI_QUIRK(0x17aa, 0x21b4, "Thinkpad Edge", CXT5066_IDEAPAD), > SND_PCI_QUIRK(0x17aa, 0x3a0d, "ideapad", CXT5066_IDEAPAD), > SND_PCI_QUIRK(0x17aa, 0x215e, "Lenovo Thinkpad", CXT5066_THINKPAD), pulled and pushed to master-next