diff mbox

[U-Boot] driver: net: fsl-mc: Update fsl_mc_ldpaa_exit() path

Message ID 1492074318-22277-1-git-send-email-yogeshnarayan.gaur@nxp.com
State Superseded
Delegated to: York Sun
Headers show

Commit Message

Yogesh Narayan Gaur April 13, 2017, 9:05 a.m. UTC
Earlier when MC is loaded but DPL is not deployed results in FDT fix-up
code execution hang.
For this case now print message on console and returns success instead of
return -ENODEV.
This update allows to continue fdt fixup execution.

Signed-off-by: Yogesh Gaur <yogeshnarayan.gaur@nxp.com>
Signed-off-by: Priyanka Jain <Priyanka.jain@nxp.com>
---
 drivers/net/fsl-mc/mc.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

Comments

Prabhakar Kushwaha April 14, 2017, 8:55 a.m. UTC | #1
> -----Original Message-----

> From: U-Boot [mailto:u-boot-bounces@lists.denx.de] On Behalf Of Yogesh Gaur

> Sent: Thursday, April 13, 2017 2:35 PM

> To: u-boot@lists.denx.de; york sun <york.sun@nxp.com>

> Cc: Priyanka Jain <priyanka.jain@nxp.com>; Yogesh Narayan Gaur

> <yogeshnarayan.gaur@nxp.com>

> Subject: [U-Boot] [PATCH] driver: net: fsl-mc: Update fsl_mc_ldpaa_exit() path

> 

> Earlier when MC is loaded but DPL is not deployed results in FDT fix-up

> code execution hang.

> For this case now print message on console and returns success instead of

> return -ENODEV.

> This update allows to continue fdt fixup execution.

> 

> Signed-off-by: Yogesh Gaur <yogeshnarayan.gaur@nxp.com>

> Signed-off-by: Priyanka Jain <Priyanka.jain@nxp.com>

> ---

>  drivers/net/fsl-mc/mc.c | 7 ++++---

>  1 file changed, 4 insertions(+), 3 deletions(-)

> 

> diff --git a/drivers/net/fsl-mc/mc.c b/drivers/net/fsl-mc/mc.c

> index 079082a..f1a40a3 100644

> --- a/drivers/net/fsl-mc/mc.c

> +++ b/drivers/net/fsl-mc/mc.c

> @@ -1268,10 +1268,11 @@ int fsl_mc_ldpaa_exit(bd_t *bd)

>  	if (bd && get_mc_boot_status() != 0)

>  		return 0;

> 

> +	/* For case MC is loaded but DPL is not deployed, return success and

> +	 * print message on console. Else FDT fix-up code execution hanged. */

>  	if (bd && !get_mc_boot_status() && get_dpl_apply_status() == -1) {

> -		printf("ERROR: fsl-mc: DPL is not applied\n");

> -		err = -ENODEV;

> -		return err;

> +		printf("fsl-mc: MC is loaded but DPL is not deployed\n");


Also add information like DPAA2 ethernet will not work in Linux

--prabhakar
diff mbox

Patch

diff --git a/drivers/net/fsl-mc/mc.c b/drivers/net/fsl-mc/mc.c
index 079082a..f1a40a3 100644
--- a/drivers/net/fsl-mc/mc.c
+++ b/drivers/net/fsl-mc/mc.c
@@ -1268,10 +1268,11 @@  int fsl_mc_ldpaa_exit(bd_t *bd)
 	if (bd && get_mc_boot_status() != 0)
 		return 0;
 
+	/* For case MC is loaded but DPL is not deployed, return success and
+	 * print message on console. Else FDT fix-up code execution hanged. */
 	if (bd && !get_mc_boot_status() && get_dpl_apply_status() == -1) {
-		printf("ERROR: fsl-mc: DPL is not applied\n");
-		err = -ENODEV;
-		return err;
+		printf("fsl-mc: MC is loaded but DPL is not deployed\n");
+		return 0;
 	}
 
 	if (bd && !get_mc_boot_status() && !get_dpl_apply_status())