| Message ID | 20170208124346.26917-1-sjg@chromium.org |
|---|---|
| State | Accepted |
| Commit | 5d3be0f81ca7668ac04ee0f0b7d82e123c7f59b5 |
| Delegated to: | Minkyu Kang |
| Headers | show |
On 02/08/2017 09:43 PM, Simon Glass wrote: > We don't ever search for these so there is no need for a 4KB alignment. > It just wastes space. > > Drop this and use the standard 4-byte alignment. > > Signed-off-by: Simon Glass <sjg@chromium.org> Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com> Best Regards, Jaehoon Chung > --- > > board/samsung/common/exynos-uboot-spl.lds | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/board/samsung/common/exynos-uboot-spl.lds b/board/samsung/common/exynos-uboot-spl.lds > index 4a933c87e9..8c497792ee 100644 > --- a/board/samsung/common/exynos-uboot-spl.lds > +++ b/board/samsung/common/exynos-uboot-spl.lds > @@ -38,8 +38,7 @@ SECTIONS > } >.sram > . = ALIGN(4); > > - /* Align .machine_param on 256 byte boundary for easier searching */ > - .machine_param ALIGN(0x100) : { *(.machine_param) } >.sram > + .machine_param : { *(.machine_param) } >.sram > . = ALIGN(4); > > __image_copy_end = .; >
Dear Simon Glass, On 9 February 2017 at 17:31, Jaehoon Chung <jh80.chung@samsung.com> wrote: > On 02/08/2017 09:43 PM, Simon Glass wrote: > > We don't ever search for these so there is no need for a 4KB alignment. > > It just wastes space. > > > > Drop this and use the standard 4-byte alignment. > > > > Signed-off-by: Simon Glass <sjg@chromium.org> > > Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com> > > applied to u-boot-samsung. Thanks, Minkyu Kang.
diff --git a/board/samsung/common/exynos-uboot-spl.lds b/board/samsung/common/exynos-uboot-spl.lds index 4a933c87e9..8c497792ee 100644 --- a/board/samsung/common/exynos-uboot-spl.lds +++ b/board/samsung/common/exynos-uboot-spl.lds @@ -38,8 +38,7 @@ SECTIONS } >.sram . = ALIGN(4); - /* Align .machine_param on 256 byte boundary for easier searching */ - .machine_param ALIGN(0x100) : { *(.machine_param) } >.sram + .machine_param : { *(.machine_param) } >.sram . = ALIGN(4); __image_copy_end = .;
We don't ever search for these so there is no need for a 4KB alignment. It just wastes space. Drop this and use the standard 4-byte alignment. Signed-off-by: Simon Glass <sjg@chromium.org> --- board/samsung/common/exynos-uboot-spl.lds | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)