| Message ID | 1468258732-8378-5-git-send-email-apatterson@sightlogix.com |
|---|---|
| State | Accepted |
| Delegated to: | Simon Glass |
| Headers | show |
Hi Sandy, On 11 July 2016 at 11:38, Sandy Patterson <apatterson@sightlogix.com> wrote: > I am not sure why this limit is changing. But my kernel > doesn't load when it's above 256. This was testing on the > rock2 board. > > Signed-off-by: Sandy Patterson <apatterson@sightlogix.com> > --- > > include/configs/rk3288_common.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Is this patch not needed now? > > diff --git a/include/configs/rk3288_common.h b/include/configs/rk3288_common.h > index 9d50d83..b88e7e5 100644 > --- a/include/configs/rk3288_common.h > +++ b/include/configs/rk3288_common.h > @@ -97,11 +97,11 @@ > > #include <config_distro_bootcmd.h> > > -/* Linux fails to load the fdt if it's loaded above 512M on a Rock 2 board, so > +/* Linux fails to load the fdt if it's loaded above 256M on a Rock 2 board, so > * limit the fdt reallocation to that */ > #define CONFIG_EXTRA_ENV_SETTINGS \ > - "fdt_high=0x1fffffff\0" \ > - "initrd_high=0x1fffffff\0" \ > + "fdt_high=0x0fffffff\0" \ > + "initrd_high=0x0fffffff\0" \ > ENV_MEM_LAYOUT_SETTINGS \ > ROCKCHIP_DEVICE_SETTINGS \ > BOOTENV > -- > 1.9.1 > Regards, Simon
On Sat, Aug 27, 2016 at 12:06 PM, Simon Glass <sjg@chromium.org> wrote: > Hi Sandy, > > On 11 July 2016 at 11:38, Sandy Patterson <apatterson@sightlogix.com> > wrote: > > I am not sure why this limit is changing. But my kernel > > doesn't load when it's above 256. This was testing on the > > rock2 board. > > > > Signed-off-by: Sandy Patterson <apatterson@sightlogix.com> > > --- > > > > include/configs/rk3288_common.h | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > Is this patch not needed now? > I just retested with the latest from u-boot.git/master . This patch is still required for booing on rock2. I tested with the same mainline kernel version as before (4.7.0-rc6). I don't know why, and I haven't tried searching back through the history to see if it used to work and what changed, sorry. > > > > > diff --git a/include/configs/rk3288_common.h b/include/configs/rk3288_ > common.h > > index 9d50d83..b88e7e5 100644 > > --- a/include/configs/rk3288_common.h > > +++ b/include/configs/rk3288_common.h > > @@ -97,11 +97,11 @@ > > > > #include <config_distro_bootcmd.h> > > > > -/* Linux fails to load the fdt if it's loaded above 512M on a Rock 2 > board, so > > +/* Linux fails to load the fdt if it's loaded above 256M on a Rock 2 > board, so > > * limit the fdt reallocation to that */ > > #define CONFIG_EXTRA_ENV_SETTINGS \ > > - "fdt_high=0x1fffffff\0" \ > > - "initrd_high=0x1fffffff\0" \ > > + "fdt_high=0x0fffffff\0" \ > > + "initrd_high=0x0fffffff\0" \ > > ENV_MEM_LAYOUT_SETTINGS \ > > ROCKCHIP_DEVICE_SETTINGS \ > > BOOTENV > > -- > > 1.9.1 > > > > Regards, > Simon >
On 27 August 2016 at 11:03, Sandy Patterson <apatterson@sightlogix.com> wrote: > > > On Sat, Aug 27, 2016 at 12:06 PM, Simon Glass <sjg@chromium.org> wrote: >> >> Hi Sandy, >> >> On 11 July 2016 at 11:38, Sandy Patterson <apatterson@sightlogix.com> >> wrote: >> > I am not sure why this limit is changing. But my kernel >> > doesn't load when it's above 256. This was testing on the >> > rock2 board. >> > >> > Signed-off-by: Sandy Patterson <apatterson@sightlogix.com> >> > --- >> > >> > include/configs/rk3288_common.h | 6 +++--- >> > 1 file changed, 3 insertions(+), 3 deletions(-) >> >> Is this patch not needed now? > > > I just retested with the latest from u-boot.git/master . This patch is still > required for booing on rock2. I tested with the same mainline kernel version > as before (4.7.0-rc6). I don't know why, and I haven't tried searching back > through the history to see if it used to work and what changed, sorry. Still not tested tags for this. Updated commit subject and: Applied to u-boot-rockchip, thanks!
diff --git a/include/configs/rk3288_common.h b/include/configs/rk3288_common.h index 9d50d83..b88e7e5 100644 --- a/include/configs/rk3288_common.h +++ b/include/configs/rk3288_common.h @@ -97,11 +97,11 @@ #include <config_distro_bootcmd.h> -/* Linux fails to load the fdt if it's loaded above 512M on a Rock 2 board, so +/* Linux fails to load the fdt if it's loaded above 256M on a Rock 2 board, so * limit the fdt reallocation to that */ #define CONFIG_EXTRA_ENV_SETTINGS \ - "fdt_high=0x1fffffff\0" \ - "initrd_high=0x1fffffff\0" \ + "fdt_high=0x0fffffff\0" \ + "initrd_high=0x0fffffff\0" \ ENV_MEM_LAYOUT_SETTINGS \ ROCKCHIP_DEVICE_SETTINGS \ BOOTENV
I am not sure why this limit is changing. But my kernel doesn't load when it's above 256. This was testing on the rock2 board. Signed-off-by: Sandy Patterson <apatterson@sightlogix.com> --- include/configs/rk3288_common.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)