| Message ID | 46b7f0adce308bf807e169fa8c8348c4f349a4b2.1467624132.git.yann.morin.1998@free.fr |
|---|---|
| State | Accepted |
| Headers | show |
>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes: > Keep the existing sub-menus, because there are a lot of entries in those > sub-menus. Using comments to separate them is not a totally satifactory > solution. > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr> I'm not quite sure I think this is an improvement. We used to have: [ ] collectd Which when selected becomes: [*] collectd match plugins ---> misc plugins ---> read plugins ---> target plugins ---> write plugins ---> Which looks sensible to me. With the change we instead have: [ ] collectd ---- (and if you press enter you get to an empty menu). When enabled you again have to press enter to get to the submenus.
Peter, All, On 2016-07-04 17:14 +0200, Peter Korsgaard spake thusly: > >>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes: > > > Keep the existing sub-menus, because there are a lot of entries in those > > sub-menus. Using comments to separate them is not a totally satifactory > > solution. > > > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr> > > I'm not quite sure I think this is an improvement. We used to have: > > [ ] collectd > > Which when selected becomes: > > [*] collectd > match plugins ---> > misc plugins ---> > read plugins ---> > target plugins ---> > write plugins ---> > > Which looks sensible to me. > > With the change we instead have: > > [ ] collectd ---- You did notice the trailing '---' which means that the menu is empty, I guess? ;-) But as we discussed live about this series: meh... ;-) Regards, Yann E. MORIN. > (and if you press enter you get to an empty menu). When enabled you > again have to press enter to get to the submenus. > > -- > Bye, Peter Korsgaard
>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes: Hi, >> Which looks sensible to me. >> >> With the change we instead have: >> >> [ ] collectd ---- > You did notice the trailing '---' which means that the menu is empty, I > guess? ;-) Yes. I do find it quite stupid that enter isn't just a no-op when the option isn't enabled, but I guess that's just kconfig :/
diff --git a/package/collectd/Config.in b/package/collectd/Config.in index 71301ec..6405af6 100644 --- a/package/collectd/Config.in +++ b/package/collectd/Config.in @@ -1,4 +1,4 @@ -config BR2_PACKAGE_COLLECTD +menuconfig BR2_PACKAGE_COLLECTD bool "collectd" # Uses fork() depends on BR2_USE_MMU @@ -39,6 +39,7 @@ config BR2_PACKAGE_COLLECTD_VALUE bool "value" help Select values by their data sources' values. + endmenu menu "misc plugins"
Keep the existing sub-menus, because there are a lot of entries in those sub-menus. Using comments to separate them is not a totally satifactory solution. Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr> --- package/collectd/Config.in | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)