| Message ID | 20160609191844.b5f0e43009f6d5dc129b7c54@gmail.com |
|---|---|
| State | Accepted |
| Commit | 51c14cd128f4355514397dc3c8647fb14f7d8ff4 |
| Delegated to: | Tom Rini |
| Headers | show |
On Thu, Jun 09, 2016 at 07:18:44PM -0700, Teddy Reed wrote: > This allows a board to configure verified boot within the SPL using > a FIT or FIT with external data. It also allows the SPL to perform > signature verification without needing relocation. > > The board configuration will need to add the following feature defines: > CONFIG_SPL_CRYPTO_SUPPORT > CONFIG_SPL_HASH_SUPPORT > CONFIG_SPL_SHA256 > > In this example, SHA256 is the only selected hashing algorithm. > > And the following booleans: > CONFIG_SPL=y > CONFIG_SPL_DM=y > CONFIG_SPL_LOAD_FIT=y > CONFIG_SPL_FIT=y > CONFIG_SPL_OF_CONTROL=y > CONFIG_SPL_OF_LIBFDT=y > CONFIG_SPL_FIT_SIGNATURE=y > > Signed-off-by: Teddy Reed <teddy.reed@gmail.com> > Acked-by: Simon Glass <sjg@chromium.org> Applies cleanly now and builds without issues. Acked-by: Andreas Dannenberg <dannenberg@ti.com>
Hi Teddy, > -----Original Message----- > From: Andreas Dannenberg [mailto:dannenberg@ti.com] > Sent: Friday, June 10, 2016 8:15 AM > To: Teddy Reed <teddy.reed@gmail.com> > Cc: u-boot@lists.denx.de; sjg@chromium.org; Sumit Garg > <sumit.garg@nxp.com> > Subject: Re: [PATCH v2] verified-boot: Minimal support for booting U-Boot > proper from SPL > > On Thu, Jun 09, 2016 at 07:18:44PM -0700, Teddy Reed wrote: > > This allows a board to configure verified boot within the SPL using a > > FIT or FIT with external data. It also allows the SPL to perform > > signature verification without needing relocation. > > > > The board configuration will need to add the following feature defines: > > CONFIG_SPL_CRYPTO_SUPPORT > > CONFIG_SPL_HASH_SUPPORT > > CONFIG_SPL_SHA256 > > > > In this example, SHA256 is the only selected hashing algorithm. > > > > And the following booleans: > > CONFIG_SPL=y > > CONFIG_SPL_DM=y > > CONFIG_SPL_LOAD_FIT=y > > CONFIG_SPL_FIT=y > > CONFIG_SPL_OF_CONTROL=y > > CONFIG_SPL_OF_LIBFDT=y > > CONFIG_SPL_FIT_SIGNATURE=y > > > > Signed-off-by: Teddy Reed <teddy.reed@gmail.com> > > Acked-by: Simon Glass <sjg@chromium.org> > > Applies cleanly now and builds without issues. > > Acked-by: Andreas Dannenberg <dannenberg@ti.com> Acked-by: Sumit Garg <sumit.garg@nxp.com>
On Thu, Jun 09, 2016 at 07:18:44PM -0700, Teddy Reed wrote: > This allows a board to configure verified boot within the SPL using > a FIT or FIT with external data. It also allows the SPL to perform > signature verification without needing relocation. > > The board configuration will need to add the following feature defines: > CONFIG_SPL_CRYPTO_SUPPORT > CONFIG_SPL_HASH_SUPPORT > CONFIG_SPL_SHA256 > > In this example, SHA256 is the only selected hashing algorithm. > > And the following booleans: > CONFIG_SPL=y > CONFIG_SPL_DM=y > CONFIG_SPL_LOAD_FIT=y > CONFIG_SPL_FIT=y > CONFIG_SPL_OF_CONTROL=y > CONFIG_SPL_OF_LIBFDT=y > CONFIG_SPL_FIT_SIGNATURE=y > > Signed-off-by: Teddy Reed <teddy.reed@gmail.com> > Acked-by: Simon Glass <sjg@chromium.org> > Acked-by: Andreas Dannenberg <dannenberg@ti.com> > Acked-by: Sumit Garg <sumit.garg@nxp.com> Applied to u-boot/master, thanks!
diff --git a/Kconfig b/Kconfig index 4b46216..817f4f0 100644 --- a/Kconfig +++ b/Kconfig @@ -183,6 +183,11 @@ config FIT verified boot (secure boot using RSA). This option enables that feature. +config SPL_FIT + bool "Support Flattened Image Tree within SPL" + depends on FIT + depends on SPL + config FIT_VERBOSE bool "Display verbose messages on FIT boot" depends on FIT @@ -205,6 +210,12 @@ config FIT_SIGNATURE format support in this case, enable it using CONFIG_IMAGE_FORMAT_LEGACY. +config SPL_FIT_SIGNATURE + bool "Enable signature verification of FIT firmware within SPL" + depends on SPL_FIT + depends on SPL_DM + select SPL_RSA + config FIT_BEST_MATCH bool "Select the best match for the kernel device tree" depends on FIT diff --git a/common/Makefile b/common/Makefile index 1557a04..97c59fe 100644 --- a/common/Makefile +++ b/common/Makefile @@ -93,6 +93,7 @@ obj-$(CONFIG_USB_KEYBOARD) += usb_kbd.o endif # !CONFIG_SPL_BUILD ifdef CONFIG_SPL_BUILD +obj-$(CONFIG_SPL_HASH_SUPPORT) += hash.o obj-$(CONFIG_ENV_IS_IN_FLASH) += env_flash.o obj-$(CONFIG_SPL_YMODEM_SUPPORT) += xyzModem.o obj-$(CONFIG_SPL_NET_SUPPORT) += miiphyutil.o diff --git a/drivers/Makefile b/drivers/Makefile index f6295d2..db5317c 100644 --- a/drivers/Makefile +++ b/drivers/Makefile @@ -10,6 +10,7 @@ obj-$(CONFIG_$(SPL_)RAM) += ram/ ifdef CONFIG_SPL_BUILD +obj-$(CONFIG_SPL_CRYPTO_SUPPORT) += crypto/ obj-$(CONFIG_SPL_I2C_SUPPORT) += i2c/ obj-$(CONFIG_SPL_GPIO_SUPPORT) += gpio/ obj-$(CONFIG_SPL_MMC_SUPPORT) += mmc/ diff --git a/drivers/crypto/rsa_mod_exp/mod_exp_sw.c b/drivers/crypto/rsa_mod_exp/mod_exp_sw.c index dc6c064..3817fb3 100644 --- a/drivers/crypto/rsa_mod_exp/mod_exp_sw.c +++ b/drivers/crypto/rsa_mod_exp/mod_exp_sw.c @@ -32,6 +32,7 @@ U_BOOT_DRIVER(mod_exp_sw) = { .name = "mod_exp_sw", .id = UCLASS_MOD_EXP, .ops = &mod_exp_ops_sw, + .flags = DM_FLAG_PRE_RELOC, }; U_BOOT_DEVICE(mod_exp_sw) = { diff --git a/lib/Makefile b/lib/Makefile index f77befe..f48d901 100644 --- a/lib/Makefile +++ b/lib/Makefile @@ -9,7 +9,6 @@ ifndef CONFIG_SPL_BUILD obj-$(CONFIG_EFI) += efi/ obj-$(CONFIG_EFI_LOADER) += efi_loader/ -obj-$(CONFIG_RSA) += rsa/ obj-$(CONFIG_LZMA) += lzma/ obj-$(CONFIG_LZO) += lzo/ obj-$(CONFIG_ZLIB) += zlib/ @@ -25,8 +24,6 @@ obj-y += crc8.o obj-y += crc16.o obj-$(CONFIG_ERRNO_STR) += errno_str.o obj-$(CONFIG_FIT) += fdtdec_common.o -obj-$(CONFIG_$(SPL_)OF_CONTROL) += fdtdec_common.o -obj-$(CONFIG_$(SPL_)OF_CONTROL) += fdtdec.o obj-$(CONFIG_TEST_FDTDEC) += fdtdec_test.o obj-$(CONFIG_GZIP) += gunzip.o obj-$(CONFIG_GZIP_COMPRESSED) += gzip.o @@ -39,15 +36,17 @@ obj-y += net_utils.o obj-$(CONFIG_PHYSMEM) += physmem.o obj-y += qsort.o obj-y += rc4.o -obj-$(CONFIG_SHA1) += sha1.o obj-$(CONFIG_SUPPORT_EMMC_RPMB) += sha256.o -obj-$(CONFIG_SHA256) += sha256.o obj-$(CONFIG_TPM) += tpm.o obj-$(CONFIG_RBTREE) += rbtree.o obj-$(CONFIG_BITREVERSE) += bitrev.o obj-y += list_sort.o endif +obj-$(CONFIG_$(SPL_)RSA) += rsa/ +obj-$(CONFIG_$(SPL_)SHA1) += sha1.o +obj-$(CONFIG_$(SPL_)SHA256) += sha256.o + obj-$(CONFIG_$(SPL_)OF_LIBFDT) += libfdt/ ifdef CONFIG_SPL_OF_CONTROL obj-$(CONFIG_OF_LIBFDT) += libfdt/ diff --git a/lib/rsa/Kconfig b/lib/rsa/Kconfig index 86df0a0..09ec358 100644 --- a/lib/rsa/Kconfig +++ b/lib/rsa/Kconfig @@ -13,6 +13,10 @@ config RSA option. The software based modular exponentiation is built into mkimage irrespective of this option. +config SPL_RSA + bool "Use RSA Library within SPL" + depends on RSA + if RSA config RSA_SOFTWARE_EXP bool "Enable driver for RSA Modular Exponentiation in software" diff --git a/lib/rsa/Makefile b/lib/rsa/Makefile index 6867e50..4b2c1ba 100644 --- a/lib/rsa/Makefile +++ b/lib/rsa/Makefile @@ -7,5 +7,5 @@ # SPDX-License-Identifier: GPL-2.0+ # -obj-$(CONFIG_FIT_SIGNATURE) += rsa-verify.o rsa-checksum.o +obj-$(CONFIG_$(SPL_)FIT_SIGNATURE) += rsa-verify.o rsa-checksum.o obj-$(CONFIG_RSA_SOFTWARE_EXP) += rsa-mod-exp.o