diff mbox

[v2,1/2] Add SVN repository support for u-boot

Message ID 1458234472-4741-2-git-send-email-susundberg@gmail.com
State Superseded
Headers show

Commit Message

Pauli Sundberg March 17, 2016, 5:07 p.m. UTC 
---
 boot/uboot/Config.in | 9 ++++++---
 boot/uboot/uboot.mk  | 4 +++-
 2 files changed, 9 insertions(+), 4 deletions(-)

Comments

Peter Korsgaard March 25, 2016, 10:15 p.m. UTC | #1 
>>>>> "Pauli" == Pauli Sundberg <susundberg@gmail.com> writes:

You forgot to add your signed-off-by (git commit -s), so I cannot apply
this. Care to add that (and fix the below) and resend?

 > ---
 >  boot/uboot/Config.in | 9 ++++++---
 >  boot/uboot/uboot.mk  | 4 +++-
 >  2 files changed, 9 insertions(+), 4 deletions(-)

 > diff --git a/boot/uboot/Config.in b/boot/uboot/Config.in
 > index 0e79734..5800060 100644
 > --- a/boot/uboot/Config.in
 > +++ b/boot/uboot/Config.in
 > @@ -51,6 +51,9 @@ config BR2_TARGET_UBOOT_CUSTOM_TARBALL
 >  config BR2_TARGET_UBOOT_CUSTOM_GIT
 >  	bool "Custom Git repository"
 
 > +config BR2_TARGET_UBOOT_CUSTOM_SVN
 > +	bool "Custom SVN repository"
 > +
 >  config BR2_TARGET_UBOOT_CUSTOM_HG
 >  	bool "Custom Mercurial repository"

S still comes after H in the alphabet, so please add SVN after
_HG. While we're at it I think we should spell out Subversion instead of
SVN.

Thanks.
diff mbox

Patch

diff --git a/boot/uboot/Config.in b/boot/uboot/Config.in
index 0e79734..5800060 100644
--- a/boot/uboot/Config.in
+++ b/boot/uboot/Config.in
@@ -51,6 +51,9 @@  config BR2_TARGET_UBOOT_CUSTOM_TARBALL
 config BR2_TARGET_UBOOT_CUSTOM_GIT
 	bool "Custom Git repository"
 
+config BR2_TARGET_UBOOT_CUSTOM_SVN
+	bool "Custom SVN repository"
+
 config BR2_TARGET_UBOOT_CUSTOM_HG
 	bool "Custom Mercurial repository"
 
@@ -64,7 +67,7 @@  config BR2_TARGET_UBOOT_CUSTOM_TARBALL_LOCATION
 	string "URL of custom U-Boot tarball"
 	depends on BR2_TARGET_UBOOT_CUSTOM_TARBALL
 
-if BR2_TARGET_UBOOT_CUSTOM_GIT || BR2_TARGET_UBOOT_CUSTOM_HG
+if BR2_TARGET_UBOOT_CUSTOM_GIT || BR2_TARGET_UBOOT_CUSTOM_HG || BR2_TARGET_UBOOT_CUSTOM_SVN
 
 config BR2_TARGET_UBOOT_CUSTOM_REPO_URL
 	string "URL of custom repository"
@@ -76,7 +79,7 @@  config BR2_TARGET_UBOOT_CUSTOM_REPO_VERSION
 	default BR2_TARGET_UBOOT_CUSTOM_GIT_VERSION \
 		if BR2_TARGET_UBOOT_CUSTOM_GIT_VERSION != ""  # legacy
 	help
-	  Revision to use in the typical format used by Git/Mercurial
+	  Revision to use in the typical format used by Git/Mercurial/Svn
 	  E.G. a sha id, a tag, branch, ..
 
 endif
@@ -88,7 +91,7 @@  config BR2_TARGET_UBOOT_VERSION
 		if BR2_TARGET_UBOOT_CUSTOM_VERSION
 	default "custom"	if BR2_TARGET_UBOOT_CUSTOM_TARBALL
 	default BR2_TARGET_UBOOT_CUSTOM_REPO_VERSION \
-		if BR2_TARGET_UBOOT_CUSTOM_GIT || BR2_TARGET_UBOOT_CUSTOM_HG
+		if BR2_TARGET_UBOOT_CUSTOM_GIT || BR2_TARGET_UBOOT_CUSTOM_HG || BR2_TARGET_UBOOT_CUSTOM_SVN
 
 config BR2_TARGET_UBOOT_PATCH
 	string "Custom U-Boot patches"
diff --git a/boot/uboot/uboot.mk b/boot/uboot/uboot.mk
index f9a3ff8..e82135c 100644
--- a/boot/uboot/uboot.mk
+++ b/boot/uboot/uboot.mk
@@ -3,7 +3,6 @@ 
 # uboot
 #
 ################################################################################
-
 UBOOT_VERSION = $(call qstrip,$(BR2_TARGET_UBOOT_VERSION))
 UBOOT_BOARD_NAME = $(call qstrip,$(BR2_TARGET_UBOOT_BOARDNAME))
 
@@ -24,6 +23,9 @@  UBOOT_SITE_METHOD = git
 else ifeq ($(BR2_TARGET_UBOOT_CUSTOM_HG),y)
 UBOOT_SITE = $(call qstrip,$(BR2_TARGET_UBOOT_CUSTOM_REPO_URL))
 UBOOT_SITE_METHOD = hg
+else ifeq ($(BR2_TARGET_UBOOT_CUSTOM_SVN),y)
+UBOOT_SITE = $(call qstrip,$(BR2_TARGET_UBOOT_CUSTOM_REPO_URL))
+UBOOT_SITE_METHOD = svn
 else
 # Handle stable official U-Boot versions
 UBOOT_SITE = ftp://ftp.denx.de/pub/u-boot