diff mbox

[U-Boot] arm: socfpga: cyclone5_socdk: Enable qspiload console command

Message ID 1450713017-3357-1-git-send-email-clsee@altera.com
State Superseded
Delegated to: Marek Vasut
Headers show

Commit Message

Chin Liang See Dec. 21, 2015, 3:50 p.m. UTC
Enabling qspiload command which will load the kernel
image and dtb from UBIFS within MTD partition labeled
UBI.

Signed-off-by: Chin Liang See <clsee@altera.com>
Cc: Dinh Nguyen <dinguyen@opensource.altera.com>
Cc: Dinh Nguyen <dinh.linux@gmail.com>
Cc: Pavel Machek <pavel@denx.de>
Cc: Marek Vasut <marex@denx.de>
Cc: Stefan Roese <sr@denx.de>
---
 include/configs/socfpga_cyclone5_socdk.h | 1 +
 1 file changed, 1 insertion(+)

Comments

Marek Vasut Dec. 21, 2015, 11:13 p.m. UTC | #1
On Monday, December 21, 2015 at 04:50:17 PM, Chin Liang See wrote:
> Enabling qspiload command which will load the kernel
> image and dtb from UBIFS within MTD partition labeled
> UBI.
> 
> Signed-off-by: Chin Liang See <clsee@altera.com>
> Cc: Dinh Nguyen <dinguyen@opensource.altera.com>
> Cc: Dinh Nguyen <dinh.linux@gmail.com>
> Cc: Pavel Machek <pavel@denx.de>
> Cc: Marek Vasut <marex@denx.de>
> Cc: Stefan Roese <sr@denx.de>
> ---
>  include/configs/socfpga_cyclone5_socdk.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/configs/socfpga_cyclone5_socdk.h
> b/include/configs/socfpga_cyclone5_socdk.h index 21b35d8..61450cb 100644
> --- a/include/configs/socfpga_cyclone5_socdk.h
> +++ b/include/configs/socfpga_cyclone5_socdk.h
> @@ -70,6 +70,7 @@
>  	"mmcload=mmc rescan;" \
>  		"load mmc 0:1 ${loadaddr} ${bootimage};" \
>  		"load mmc 0:1 ${fdt_addr} ${fdtimage}\0" \
> +	"qspiload=sf probe; mtdparts default;run ubiload\0" \

&& instead of ; please . Also, I believe these four patches you sent are 
supposed to be a series, right ?

>  	"qspiroot=/dev/mtdblock0\0" \
>  	"qspirootfstype=jffs2\0" \
>  	"qspiboot=setenv bootargs " CONFIG_BOOTARGS \

Best regards,
Marek Vasut
Chin Liang See Dec. 22, 2015, 12:23 a.m. UTC | #2
On Tue, 2015-12-22 at 00:13 +0100, Marek Vasut wrote:
> On Monday, December 21, 2015 at 04:50:17 PM, Chin Liang See wrote:
> > Enabling qspiload command which will load the kernel
> > image and dtb from UBIFS within MTD partition labeled
> > UBI.
> > 
> > Signed-off-by: Chin Liang See <clsee@altera.com>
> > Cc: Dinh Nguyen <dinguyen@opensource.altera.com>
> > Cc: Dinh Nguyen <dinh.linux@gmail.com>
> > Cc: Pavel Machek <pavel@denx.de>
> > Cc: Marek Vasut <marex@denx.de>
> > Cc: Stefan Roese <sr@denx.de>
> > ---
> >  include/configs/socfpga_cyclone5_socdk.h | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/include/configs/socfpga_cyclone5_socdk.h
> > b/include/configs/socfpga_cyclone5_socdk.h index 21b35d8..61450cb
> > 100644
> > --- a/include/configs/socfpga_cyclone5_socdk.h
> > +++ b/include/configs/socfpga_cyclone5_socdk.h
> > @@ -70,6 +70,7 @@
> >  	"mmcload=mmc rescan;" \
> >  		"load mmc 0:1 ${loadaddr} ${bootimage};" \
> >  		"load mmc 0:1 ${fdt_addr} ${fdtimage}\0" \
> > +	"qspiload=sf probe; mtdparts default;run ubiload\0" \
> 
> && instead of ; please . Also, I believe these four patches you sent
> are 
> supposed to be a series, right ?

Will change this too. Yup, let me make it series as I was testing each
patch and sending out.

Thanks
Chin Liang

> 
> >  	"qspiroot=/dev/mtdblock0\0" \
> >  	"qspirootfstype=jffs2\0" \
> >  	"qspiboot=setenv bootargs " CONFIG_BOOTARGS \
> 
> Best regards,
> Marek Vasut
Marek Vasut Dec. 22, 2015, 12:24 a.m. UTC | #3
On Tuesday, December 22, 2015 at 01:23:14 AM, Chin Liang See wrote:
> On Tue, 2015-12-22 at 00:13 +0100, Marek Vasut wrote:
> > On Monday, December 21, 2015 at 04:50:17 PM, Chin Liang See wrote:
> > > Enabling qspiload command which will load the kernel
> > > image and dtb from UBIFS within MTD partition labeled
> > > UBI.
> > > 
> > > Signed-off-by: Chin Liang See <clsee@altera.com>
> > > Cc: Dinh Nguyen <dinguyen@opensource.altera.com>
> > > Cc: Dinh Nguyen <dinh.linux@gmail.com>
> > > Cc: Pavel Machek <pavel@denx.de>
> > > Cc: Marek Vasut <marex@denx.de>
> > > Cc: Stefan Roese <sr@denx.de>
> > > ---
> > > 
> > >  include/configs/socfpga_cyclone5_socdk.h | 1 +
> > >  1 file changed, 1 insertion(+)
> > > 
> > > diff --git a/include/configs/socfpga_cyclone5_socdk.h
> > > b/include/configs/socfpga_cyclone5_socdk.h index 21b35d8..61450cb
> > > 100644
> > > --- a/include/configs/socfpga_cyclone5_socdk.h
> > > +++ b/include/configs/socfpga_cyclone5_socdk.h
> > > @@ -70,6 +70,7 @@
> > > 
> > >  	"mmcload=mmc rescan;" \
> > >  	
> > >  		"load mmc 0:1 ${loadaddr} ${bootimage};" \
> > >  		"load mmc 0:1 ${fdt_addr} ${fdtimage}\0" \
> > > 
> > > +	"qspiload=sf probe; mtdparts default;run ubiload\0" \
> > 
> > && instead of ; please . Also, I believe these four patches you sent
> > are
> > supposed to be a series, right ?
> 
> Will change this too. Yup, let me make it series as I was testing each
> patch and sending out.

Thanks!

Best regards,
Marek Vasut
diff mbox

Patch

diff --git a/include/configs/socfpga_cyclone5_socdk.h b/include/configs/socfpga_cyclone5_socdk.h
index 21b35d8..61450cb 100644
--- a/include/configs/socfpga_cyclone5_socdk.h
+++ b/include/configs/socfpga_cyclone5_socdk.h
@@ -70,6 +70,7 @@ 
 	"mmcload=mmc rescan;" \
 		"load mmc 0:1 ${loadaddr} ${bootimage};" \
 		"load mmc 0:1 ${fdt_addr} ${fdtimage}\0" \
+	"qspiload=sf probe; mtdparts default;run ubiload\0" \
 	"qspiroot=/dev/mtdblock0\0" \
 	"qspirootfstype=jffs2\0" \
 	"qspiboot=setenv bootargs " CONFIG_BOOTARGS \