Message ID | 566F69EB.9000700@freescale.com |
---|---|
State | Accepted |
Delegated to: | Tom Rini |
Headers | show |
On Tue, Dec 15, 2015 at 09:16:27AM +0800, York Sun wrote: > Tom, > > The following changes since commit 5076c64a08d2083af5a7761b12a30116ef0da967: > > Merge branch 'master' of git://git.denx.de/u-boot-spi (2015-12-11 15:07:44 -0500) > > are available in the git repository at: > > > git://git.denx.de/u-boot-fsl-qoriq.git master > > for you to fetch changes up to 989c5f0a8f8694ac92eb0d6cff8745ae8659364f: > > armv8: Add sata support on Layerscape ARMv8 board (2015-12-15 08:57:35 +0800) > Applied to u-boot/master, thanks!
Tom, Please hold on pushing to repository. I did my test on powerpc and arm SoCs and all passed. But my local build just failed on uintptr_t. I am tracing it now. York On 12/16/2015 07:29 AM, Tom Rini wrote: > On Tue, Dec 15, 2015 at 09:16:27AM +0800, York Sun wrote: > >> Tom, >> >> The following changes since commit 5076c64a08d2083af5a7761b12a30116ef0da967: >> >> Merge branch 'master' of git://git.denx.de/u-boot-spi (2015-12-11 15:07:44 -0500) >> >> are available in the git repository at: >> >> >> git://git.denx.de/u-boot-fsl-qoriq.git master >> >> for you to fetch changes up to 989c5f0a8f8694ac92eb0d6cff8745ae8659364f: >> >> armv8: Add sata support on Layerscape ARMv8 board (2015-12-15 08:57:35 +0800) >> > > Applied to u-boot/master, thanks! >
Tom, This issue is caused by 32-bit host has uintptr_t defined in /usr/include/stdint.h as "unsigned int". I am working on a solution. In the meantime, how do we deal with this PR? York On 12/16/2015 09:40 AM, York Sun wrote: > Tom, > > Please hold on pushing to repository. I did my test on powerpc and arm SoCs and > all passed. But my local build just failed on uintptr_t. I am tracing it now. > > York > > > On 12/16/2015 07:29 AM, Tom Rini wrote: >> On Tue, Dec 15, 2015 at 09:16:27AM +0800, York Sun wrote: >> >>> Tom, >>> >>> The following changes since commit 5076c64a08d2083af5a7761b12a30116ef0da967: >>> >>> Merge branch 'master' of git://git.denx.de/u-boot-spi (2015-12-11 15:07:44 -0500) >>> >>> are available in the git repository at: >>> >>> >>> git://git.denx.de/u-boot-fsl-qoriq.git master >>> >>> for you to fetch changes up to 989c5f0a8f8694ac92eb0d6cff8745ae8659364f: >>> >>> armv8: Add sata support on Layerscape ARMv8 board (2015-12-15 08:57:35 +0800) >>> >> >> Applied to u-boot/master, thanks! >>
On Wed, Dec 16, 2015 at 09:48:59AM +0800, York Sun wrote: > Tom, > > This issue is caused by 32-bit host has uintptr_t defined in > /usr/include/stdint.h as "unsigned int". > > I am working on a solution. In the meantime, how do we deal with this PR? And then what fails... sandbox?
On 12/16/2015 09:59 AM, Tom Rini wrote: > On Wed, Dec 16, 2015 at 09:48:59AM +0800, York Sun wrote: > >> Tom, >> >> This issue is caused by 32-bit host has uintptr_t defined in >> /usr/include/stdint.h as "unsigned int". >> >> I am working on a solution. In the meantime, how do we deal with this PR? > > And then what fails... sandbox? > Not only. When I compile powerpc targets on a 32-bit host, all fail, due to stdint.h has a different typedef. York
On 12/16/2015 10:01 AM, York Sun wrote: > > > On 12/16/2015 09:59 AM, Tom Rini wrote: >> On Wed, Dec 16, 2015 at 09:48:59AM +0800, York Sun wrote: >> >>> Tom, >>> >>> This issue is caused by 32-bit host has uintptr_t defined in >>> /usr/include/stdint.h as "unsigned int". >>> >>> I am working on a solution. In the meantime, how do we deal with this PR? >> >> And then what fails... sandbox? >> > > Not only. When I compile powerpc targets on a 32-bit host, all fail, due to > stdint.h has a different typedef. > Tom, I think the original proposal of moving typedef of uintptr_t from compiler.h to types.h may be flawed. U-boot builds host tools, which may have different size than the target. Would it be appropriate to abandon this change, and to include compiler.h whenever uintptr_t is needed? York