| Message ID | 1224137292.26782.5.camel@dwillia2-linux.ch.intel.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
Dan Williams wrote: > On Wed, 2008-10-15 at 22:02 -0700, David Miller wrote: > >>> drivers/dma/ioat_dca.c: In function 'dca_enabled_in_bios': >>> drivers/dma/ioat_dca.c:81: error: implicit declaration of function 'cpuid_eax' >>> drivers/dma/ioat_dca.c: In function 'system_has_dca_enabled': >>> drivers/dma/ioat_dca.c:91: error: implicit declaration of function 'boot_cpu_has' >>> drivers/dma/ioat_dca.c:91: error: 'X86_FEATURE_DCA' undeclared (first use in this function) >>> drivers/dma/ioat_dca.c:91: error: (Each undeclared identifier is reported only once >>> drivers/dma/ioat_dca.c:91: error: for each function it appears in.) >>> drivers/dma/ioat_dca.c: In function 'ioat_dca_get_tag': >>> drivers/dma/ioat_dca.c:190: error: implicit declaration of function 'cpu_physical_id' >>> >> Known issue. I tried to ping Jeff Garzik about doing a driver bug fix run in >> order to fix this, but he hasn't shown any signs of life. >> >> So I'll do it myself later tonight. :-/ >> >> > The following seems to fix this up... > > ---snip---> > ixgbe, myri10ge: INTEL_IOATDMA can only be selected when X86=y > There's already a completely different fix queued in netdev patchworks (for myri10ge only right now, to be duplicated for Intel drivers). The idea is to stop having almost-unrelated drivers select each other directly, let people select which drivers they really want, and have Kconfig handle modules/builtin-stuff correctly. See http://patchwork.ozlabs.org/patch/4506/ Brice
From: Brice Goglin <brice@myri.com> Date: Thu, 16 Oct 2008 08:55:08 +0200 > Dan Williams wrote: > > On Wed, 2008-10-15 at 22:02 -0700, David Miller wrote: > > > >>> drivers/dma/ioat_dca.c: In function 'dca_enabled_in_bios': > >>> drivers/dma/ioat_dca.c:81: error: implicit declaration of function 'cpuid_eax' > >>> drivers/dma/ioat_dca.c: In function 'system_has_dca_enabled': > >>> drivers/dma/ioat_dca.c:91: error: implicit declaration of function 'boot_cpu_has' > >>> drivers/dma/ioat_dca.c:91: error: 'X86_FEATURE_DCA' undeclared (first use in this function) > >>> drivers/dma/ioat_dca.c:91: error: (Each undeclared identifier is reported only once > >>> drivers/dma/ioat_dca.c:91: error: for each function it appears in.) > >>> drivers/dma/ioat_dca.c: In function 'ioat_dca_get_tag': > >>> drivers/dma/ioat_dca.c:190: error: implicit declaration of function 'cpu_physical_id' > >>> > >> Known issue. I tried to ping Jeff Garzik about doing a driver bug fix run in > >> order to fix this, but he hasn't shown any signs of life. > >> > >> So I'll do it myself later tonight. :-/ > >> > >> > > The following seems to fix this up... > > > > ---snip---> > > ixgbe, myri10ge: INTEL_IOATDMA can only be selected when X86=y > > > > There's already a completely different fix queued in netdev patchworks > (for myri10ge only right now, to be duplicated for Intel drivers). The > idea is to stop having almost-unrelated drivers select each other > directly, let people select which drivers they really want, and have > Kconfig handle modules/builtin-stuff correctly. See > http://patchwork.ozlabs.org/patch/4506/ Right, my plan was to duplicate this for the other drivers.
On Wed, Oct 15, 2008 at 11:58 PM, David Miller <davem@davemloft.net> wrote: >> There's already a completely different fix queued in netdev patchworks >> (for myri10ge only right now, to be duplicated for Intel drivers). The >> idea is to stop having almost-unrelated drivers select each other >> directly, let people select which drivers they really want, and have >> Kconfig handle modules/builtin-stuff correctly. See >> http://patchwork.ozlabs.org/patch/4506/ > > Right, my plan was to duplicate this for the other drivers. The work is already done for ixgbe and igb, and we have it in testing. It should be in your inbox today or tomorrow. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig index 1d8af33..84983f8 100644 --- a/drivers/net/Kconfig +++ b/drivers/net/Kconfig @@ -2410,7 +2410,7 @@ config IXGBE tristate "Intel(R) 10GbE PCI Express adapters support" depends on PCI && INET select INET_LRO - select INTEL_IOATDMA + select INTEL_IOATDMA if X86 ---help--- This driver supports Intel(R) 10GbE PCI Express family of adapters. For more information on how to identify your adapter, go @@ -2462,7 +2462,7 @@ config MYRI10GE select FW_LOADER select CRC32 select INET_LRO - select INTEL_IOATDMA + select INTEL_IOATDMA if X86 ---help--- This driver supports Myricom Myri-10G Dual Protocol interface in Ethernet mode. If the eeprom on your board is not recent enough,