Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/840482/?format=api
{ "id": 840482, "url": "http://patchwork.ozlabs.org/api/patches/840482/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20171122185622.29785.67698.stgit@localhost.localdomain/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20171122185622.29785.67698.stgit@localhost.localdomain>", "list_archive_url": null, "date": "2017-11-22T18:56:22", "name": "[jkirsher/next-queue,02/16] ixgbe: Perform reinit any time number of VFs change", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "da21ce01ab6aa7201c3eaab1d70aa0786cc1144f", "submitter": { "id": 252, "url": "http://patchwork.ozlabs.org/api/people/252/?format=api", "name": "Alexander Duyck", "email": "alexander.duyck@gmail.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20171122185622.29785.67698.stgit@localhost.localdomain/mbox/", "series": [ { "id": 14756, "url": "http://patchwork.ozlabs.org/api/series/14756/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=14756", "date": "2017-11-22T18:56:10", "name": "ixgbe/fm10k: macvlan fixes", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/14756/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/840482/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/840482/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.136; helo=silver.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"smwGjWAM\"; dkim-atps=neutral" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yhsXd51ypz9s1h\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 23 Nov 2017 06:12:33 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 03D852F7F9;\n\tWed, 22 Nov 2017 19:12:32 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id ZirEgKYvudCJ; Wed, 22 Nov 2017 19:12:30 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 844CC2D00E;\n\tWed, 22 Nov 2017 19:12:30 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 853241C2314\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 22 Nov 2017 18:56:25 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 7CCAD88AA8\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 22 Nov 2017 18:56:25 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id FWUP860-OLWK for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 22 Nov 2017 18:56:24 +0000 (UTC)", "from mail-pg0-f65.google.com (mail-pg0-f65.google.com\n\t[74.125.83.65])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id 79EAB88AA0\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 22 Nov 2017 18:56:24 +0000 (UTC)", "by mail-pg0-f65.google.com with SMTP id u3so12954718pgn.7\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 22 Nov 2017 10:56:24 -0800 (PST)", "from localhost.localdomain ([2001:470:b:9c3:9e5c:8eff:fe4f:f2d0])\n\tby smtp.gmail.com with ESMTPSA id\n\ta23sm20009605pfa.177.2017.11.22.10.56.22\n\tfor <intel-wired-lan@lists.osuosl.org>\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 22 Nov 2017 10:56:23 -0800 (PST)" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=subject:from:to:date:message-id:in-reply-to:references:user-agent\n\t:mime-version:content-transfer-encoding;\n\tbh=69AR0qoIOOeZKEBqFB1X3QH2xwxrDR+qJsBit8ejwT8=;\n\tb=smwGjWAM954EJ3mQf4IepDSIJGS1QYbFFowcuk9z5zt7LVGBVwDFFDZE4hTVb9e9Po\n\thhoXXS+PrXqQMOxWFhNI8bDbNW5XW8TXIva8r9kqayxjJU2cmqqKga+QvbaM+gWnyzLR\n\t0jdvcy2UKyjoWPO4+SJnt7OyTvlRFc4d17B2iI0vjRZJ2zsOwZNoCw2H26jdYhuheW8y\n\tOf2G3W5KZoGG2ey/Vi95E2ifkpSlVTQGxXYS5gzYKhr0y5pJLWzuf0H6DOkVlLB58J7Y\n\tXtaoAml3J/3YJlBmlur5NXV3WW1ofEW8bWOKuOpc6piyT/AdjdIfGN6HNBrzqL/av+RO\n\tyuRg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:from:to:date:message-id:in-reply-to\n\t:references:user-agent:mime-version:content-transfer-encoding;\n\tbh=69AR0qoIOOeZKEBqFB1X3QH2xwxrDR+qJsBit8ejwT8=;\n\tb=cKL+VryuzcX5H61xd2w4co9dW8jdNUwKtQwZsgOtfGPAlDP9yZoGE3e/Gnb9+/WA5W\n\ttpfdZxqdgsSoqJCBi+MD3s71jyCCsgE+FxfLVhD7EYfE6jfnRV7HlruS/gLNxnuWITot\n\tKFBty2k1Vx79aItabohIUYnNSCdfTowTLQ3/7D5BQHQUVxt+PnAsQXzRqiKE1Eiaym7t\n\t1wR1hPXRbti7jZo0ibppz6GKBlAWfzTpx+XdfhH4N3ooxxJqwx+GRn3c9zsIIiXWNtXb\n\tdik1NiclaWfUKeqypEDHmTtC1QXLZYyIbCQ49wjORmfdFFtd0g5RhhtrVbJQVS5ilmia\n\tEsGQ==", "X-Gm-Message-State": "AJaThX4OqfOebeHwnmBD8+fq+rhNPwq9sII1/Tmlaw6OfxnalyadWd/d\n\t0SuzNzj+1dSIjhvoU6UqcsQgIQvd", "X-Google-Smtp-Source": "AGs4zMZQgSFpBLHTUeiuAQKBEpE93ygzAkDCUldnNr1x4SOTzuAkFiV6m36oXq6olfWO/xSVTG+41A==", "X-Received": "by 10.99.43.6 with SMTP id r6mr21502000pgr.353.1511376983744;\n\tWed, 22 Nov 2017 10:56:23 -0800 (PST)", "From": "Alexander Duyck <alexander.duyck@gmail.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Wed, 22 Nov 2017 10:56:22 -0800", "Message-ID": "<20171122185622.29785.67698.stgit@localhost.localdomain>", "In-Reply-To": "<20171122185256.29785.93548.stgit@localhost.localdomain>", "References": "<20171122185256.29785.93548.stgit@localhost.localdomain>", "User-Agent": "StGit/0.17.1-dirty", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [jkirsher/next-queue PATCH 02/16] ixgbe: Perform\n\treinit any time number of VFs change", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Alexander Duyck <alexander.h.duyck@intel.com>\n\nIf the number of VFs are changed we need to reinitialize the part since the\noffset for the device and the number of pools will be incorrect. Without\nthis change we can end up seeing Tx hangs and dropped Rx frames for\nincoming traffic.\n\nIn addition we should drop the code that is arbitrarily changing the\ndefault pool and queue configuration. Instead we should wait until the port\nis reset and reconfigured via ixgbe_sriov_reinit.\n\nSigned-off-by: Alexander Duyck <alexander.h.duyck@intel.com>\n---\n drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c | 19 +++----------------\n 1 file changed, 3 insertions(+), 16 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c\nindex 112d24c6c9ce..15d89258fbc3 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c\n@@ -227,9 +227,6 @@ void ixgbe_enable_sriov(struct ixgbe_adapter *adapter, unsigned int max_vfs)\n int ixgbe_disable_sriov(struct ixgbe_adapter *adapter)\n {\n \tunsigned int num_vfs = adapter->num_vfs, vf;\n-\tstruct ixgbe_hw *hw = &adapter->hw;\n-\tu32 gpie;\n-\tu32 vmdctl;\n \tint rss;\n \n \t/* set num VFs to 0 to prevent access to vfinfo */\n@@ -271,18 +268,6 @@ int ixgbe_disable_sriov(struct ixgbe_adapter *adapter)\n \tpci_disable_sriov(adapter->pdev);\n #endif\n \n-\t/* turn off device IOV mode */\n-\tIXGBE_WRITE_REG(hw, IXGBE_GCR_EXT, 0);\n-\tgpie = IXGBE_READ_REG(hw, IXGBE_GPIE);\n-\tgpie &= ~IXGBE_GPIE_VTMODE_MASK;\n-\tIXGBE_WRITE_REG(hw, IXGBE_GPIE, gpie);\n-\n-\t/* set default pool back to 0 */\n-\tvmdctl = IXGBE_READ_REG(hw, IXGBE_VT_CTL);\n-\tvmdctl &= ~IXGBE_VT_CTL_POOL_MASK;\n-\tIXGBE_WRITE_REG(hw, IXGBE_VT_CTL, vmdctl);\n-\tIXGBE_WRITE_FLUSH(hw);\n-\n \t/* Disable VMDq flag so device will be set in VM mode */\n \tif (adapter->ring_feature[RING_F_VMDQ].limit == 1) {\n \t\tadapter->flags &= ~IXGBE_FLAG_VMDQ_ENABLED;\n@@ -378,13 +363,15 @@ static int ixgbe_pci_sriov_disable(struct pci_dev *dev)\n \tint err;\n #ifdef CONFIG_PCI_IOV\n \tu32 current_flags = adapter->flags;\n+\tint prev_num_vf = pci_num_vf(dev);\n #endif\n \n \terr = ixgbe_disable_sriov(adapter);\n \n \t/* Only reinit if no error and state changed */\n #ifdef CONFIG_PCI_IOV\n-\tif (!err && current_flags != adapter->flags)\n+\tif (!err && (current_flags != adapter->flags ||\n+\t\t prev_num_vf != pci_num_vf(dev)))\n \t\tixgbe_sriov_reinit(adapter);\n #endif\n \n", "prefixes": [ "jkirsher/next-queue", "02/16" ] }