Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/817895/?format=api
{ "id": 817895, "url": "http://patchwork.ozlabs.org/api/patches/817895/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-mtd/patch/20170924105924.23923-3-vigneshr@ti.com/", "project": { "id": 3, "url": "http://patchwork.ozlabs.org/api/projects/3/?format=api", "name": "Linux MTD development", "link_name": "linux-mtd", "list_id": "linux-mtd.lists.infradead.org", "list_email": "linux-mtd@lists.infradead.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170924105924.23923-3-vigneshr@ti.com>", "list_archive_url": null, "date": "2017-09-24T10:59:21", "name": "[v3,2/5] mtd: spi-nor: cadence-quadspi: add a delay in write sequence", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "627e71d2822efa8d50e2cf6f8746752096237db0", "submitter": { "id": 65039, "url": "http://patchwork.ozlabs.org/api/people/65039/?format=api", "name": "Raghavendra, Vignesh", "email": "vigneshr@ti.com" }, "delegate": { "id": 63396, "url": "http://patchwork.ozlabs.org/api/users/63396/?format=api", "username": "cpitchen", "first_name": "Cyrille", "last_name": "Pitchen", "email": "cyrille.pitchen@atmel.com" }, "mbox": "http://patchwork.ozlabs.org/project/linux-mtd/patch/20170924105924.23923-3-vigneshr@ti.com/mbox/", "series": [ { "id": 4811, "url": "http://patchwork.ozlabs.org/api/series/4811/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-mtd/list/?series=4811", "date": "2017-09-24T10:59:19", "name": "K2G: Add QSPI support", "version": 3, "mbox": "http://patchwork.ozlabs.org/series/4811/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/817895/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/817895/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org; spf=none (mailfrom)\n\tsmtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133;\n\thelo=bombadil.infradead.org;\n\tenvelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"aF9dYpnN\"; \n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ti.com header.i=@ti.com header.b=\"m2Pw73VV\";\n\tdkim-atps=neutral" ], "Received": [ "from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y0PVs4QYtz9sDB\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSun, 24 Sep 2017 21:04:37 +1000 (AEST)", "from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dw4i4-0007PW-Kc; Sun, 24 Sep 2017 11:04:28 +0000", "from fllnx210.ext.ti.com ([198.47.19.17])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dw4dr-0002sx-NH; Sun, 24 Sep 2017 11:00:15 +0000", "from dflxv15.itg.ti.com ([128.247.5.124])\n\tby fllnx210.ext.ti.com (8.15.1/8.15.1) with ESMTP id v8OAxFNw016734; \n\tSun, 24 Sep 2017 05:59:15 -0500", "from DLEE108.ent.ti.com (dlee108.ent.ti.com [157.170.170.38])\n\tby dflxv15.itg.ti.com (8.14.3/8.13.8) with ESMTP id v8OAxE4M016020;\n\tSun, 24 Sep 2017 05:59:14 -0500", "from DLEE110.ent.ti.com (157.170.170.21) by DLEE108.ent.ti.com\n\t(157.170.170.38) with Microsoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.1.845.34;\n\tSun, 24 Sep 2017 05:59:14 -0500", "from dflp33.itg.ti.com (10.64.6.16) by DLEE110.ent.ti.com\n\t(157.170.170.21) with Microsoft SMTP Server (version=TLS1_0,\n\tcipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.845.34 via Frontend\n\tTransport; Sun, 24 Sep 2017 05:59:14 -0500", "from a0132425.india.ti.com (ileax41-snat.itg.ti.com\n\t[10.172.224.153])\n\tby dflp33.itg.ti.com (8.14.3/8.13.8) with ESMTP id v8OAx4DF027688;\n\tSun, 24 Sep 2017 05:59:11 -0500" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:\n\tMessage-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=QCCsJqojZE0ROx4Zmf8rvQqz6CtsuZarZCCkKsSR8q4=;\n\tb=aF9dYpnNcPInt6\n\t77EQeicdkuQ+PwBvWZ1/lCkm1/AscIKSkCb7UK+WwbN3+YM3GE2Qv/dI93bHnOMNP6kJQP/4o6pH7\n\tM5H/BrauovLbvucAfBpJV+HLS1icg3kCDRAQdTAQIjWZH5afajpf+pJsm/dNxi8qrY3TbVGV3Jbr4\n\tBL8gpGre+5xFOm/eKnSyL+Gzu6Z0py8Nx7lcfvBO/MU2c1r33YH9peP8nkSTL/1UPN1AGURwcHeW9\n\t3msjjbgd164AcVyLU3OOdURX8YP92BOwM6af4n6Ik4lvEWrJlNf2AcZ7/cUMqx63IT3YHAnLFMe9H\n\t6cdcP97w8eo0fX00V0cw==;", "v=1; a=rsa-sha256; c=relaxed/simple; d=ti.com;\n\ts=ti-com-17Q1; t=1506250755;\n\tbh=VTrUFuSzMFedvGvdMXW9f+qRu+aa4AK9ARmeuHvKoIM=;\n\th=From:To:CC:Subject:Date:In-Reply-To:References;\n\tb=m2Pw73VV7nDD29XNYUwQ58Z5GicwbvwWWPt/8BV/KP+6jqyv9YwxP1eCndoyE0Nwb\n\tOM7/HJBAvnMPgVLlPUbQD7BHkV7CyznCRxrMZLlmV1ir5TgDhFn/RN0npxMi4lZG4q\n\tS1Kpa+pVKLWOQs2/U6kEIsA+RhAiGze/tgv8GL5U=" ], "From": "Vignesh R <vigneshr@ti.com>", "To": "Marek Vasut <marek.vasut@gmail.com>, Cyrille Pitchen\n\t<cyrille.pitchen@wedev4u.fr>", "Subject": "[PATCH v3 2/5] mtd: spi-nor: cadence-quadspi: add a delay in write\n\tsequence", "Date": "Sun, 24 Sep 2017 16:29:21 +0530", "Message-ID": "<20170924105924.23923-3-vigneshr@ti.com>", "X-Mailer": "git-send-email 2.14.1", "In-Reply-To": "<20170924105924.23923-1-vigneshr@ti.com>", "References": "<20170924105924.23923-1-vigneshr@ti.com>", "MIME-Version": "1.0", "X-EXCLAIMER-MD-CONFIG": "e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180", "X-CRM114-Version": "20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ", "X-CRM114-CacheID": "sfid-20170924_040008_114846_37B61882 ", "X-CRM114-Status": "GOOD ( 11.58 )", "X-Spam-Score": "-2.0 (--)", "X-Spam-Report": "SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-2.0 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/,\n\tno trust [198.47.19.17 listed in list.dnswl.org]\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t-0.0 RP_MATCHES_RCVD Envelope sender domain matches handover relay\n\tdomain\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature\n\t0.1 DKIM_SIGNED Message has a DKIM or DK signature,\n\tnot necessarily valid\n\t-0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n\tauthor's domain", "X-BeenThere": "linux-mtd@lists.infradead.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "Linux MTD discussion mailing list <linux-mtd.lists.infradead.org>", "List-Unsubscribe": "<http://lists.infradead.org/mailman/options/linux-mtd>,\n\t<mailto:linux-mtd-request@lists.infradead.org?subject=unsubscribe>", "List-Archive": "<http://lists.infradead.org/pipermail/linux-mtd/>", "List-Post": "<mailto:linux-mtd@lists.infradead.org>", "List-Help": "<mailto:linux-mtd-request@lists.infradead.org?subject=help>", "List-Subscribe": "<http://lists.infradead.org/mailman/listinfo/linux-mtd>,\n\t<mailto:linux-mtd-request@lists.infradead.org?subject=subscribe>", "Cc": "Boris Brezillon <boris.brezillon@free-electrons.com>,\n\tVignesh R <vigneshr@ti.com>, devicetree@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,\n\tlinux-mtd@lists.infradead.org,\n\tBrian Norris <computersforpeace@gmail.com>, \n\tDavid Woodhouse <dwmw2@infradead.org>,\n\tlinux-arm-kernel <linux-arm-kernel@lists.infradead.org>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Sender": "\"linux-mtd\" <linux-mtd-bounces@lists.infradead.org>", "Errors-To": "linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org" }, "content": "As per 66AK2G02 TRM[1] SPRUHY8F section 11.15.5.3 Indirect Access\nController programming sequence, a delay equal to couple of QSPI master\nclock(~5ns) is required after setting CQSPI_REG_INDIRECTWR_START bit and\nwriting data to the flash. Introduce a quirk flag CQSPI_NEEDS_WR_DELAY\nto handle this and set this flag for TI 66AK2G SoC.\n\n[1]http://www.ti.com/lit/ug/spruhy8f/spruhy8f.pdf\n\nSigned-off-by: Vignesh R <vigneshr@ti.com>\n---\n\nv3:\nFix build warnings reported by kbuild test bot.\n\n drivers/mtd/spi-nor/cadence-quadspi.c | 27 ++++++++++++++++++++++++++-\n 1 file changed, 26 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/mtd/spi-nor/cadence-quadspi.c b/drivers/mtd/spi-nor/cadence-quadspi.c\nindex 53c7d8e0327a..5cd5d6f7303f 100644\n--- a/drivers/mtd/spi-nor/cadence-quadspi.c\n+++ b/drivers/mtd/spi-nor/cadence-quadspi.c\n@@ -38,6 +38,9 @@\n #define CQSPI_NAME\t\t\t\"cadence-qspi\"\n #define CQSPI_MAX_CHIPSELECT\t\t16\n \n+/* Quirks */\n+#define CQSPI_NEEDS_WR_DELAY\t\tBIT(0)\n+\n struct cqspi_st;\n \n struct cqspi_flash_pdata {\n@@ -76,6 +79,7 @@ struct cqspi_st {\n \tu32\t\t\tfifo_depth;\n \tu32\t\t\tfifo_width;\n \tu32\t\t\ttrigger_address;\n+\tu32\t\t\twr_delay;\n \tstruct cqspi_flash_pdata f_pdata[CQSPI_MAX_CHIPSELECT];\n };\n \n@@ -608,6 +612,15 @@ static int cqspi_indirect_write_execute(struct spi_nor *nor,\n \treinit_completion(&cqspi->transfer_complete);\n \twritel(CQSPI_REG_INDIRECTWR_START_MASK,\n \t reg_base + CQSPI_REG_INDIRECTWR);\n+\t/*\n+\t * As per 66AK2G02 TRM SPRUHY8F section 11.15.5.3 Indirect Access\n+\t * Controller programming sequence, couple of cycles of\n+\t * QSPI_REF_CLK delay is required for the above bit to\n+\t * be internally synchronized by the QSPI module. Provide 5\n+\t * cycles of delay.\n+\t */\n+\tif (cqspi->wr_delay)\n+\t\tndelay(cqspi->wr_delay);\n \n \twhile (remaining > 0) {\n \t\twrite_bytes = remaining > page_size ? page_size : remaining;\n@@ -1156,6 +1169,7 @@ static int cqspi_probe(struct platform_device *pdev)\n \tstruct cqspi_st *cqspi;\n \tstruct resource *res;\n \tstruct resource *res_ahb;\n+\tunsigned long data;\n \tint ret;\n \tint irq;\n \n@@ -1213,6 +1227,10 @@ static int cqspi_probe(struct platform_device *pdev)\n \t}\n \n \tcqspi->master_ref_clk_hz = clk_get_rate(cqspi->clk);\n+\tdata = (unsigned long)of_device_get_match_data(dev);\n+\tif (data & CQSPI_NEEDS_WR_DELAY)\n+\t\tcqspi->wr_delay = 5 * DIV_ROUND_UP(NSEC_PER_SEC,\n+\t\t\t\t\t\t cqspi->master_ref_clk_hz);\n \n \tret = devm_request_irq(dev, irq, cqspi_irq_handler, 0,\n \t\t\t pdev->name, cqspi);\n@@ -1284,7 +1302,14 @@ static const struct dev_pm_ops cqspi__dev_pm_ops = {\n #endif\n \n static const struct of_device_id cqspi_dt_ids[] = {\n-\t{.compatible = \"cdns,qspi-nor\",},\n+\t{\n+\t\t.compatible = \"cdns,qspi-nor\",\n+\t\t.data = (void *)0,\n+\t},\n+\t{\n+\t\t.compatible = \"ti,k2g-qspi\",\n+\t\t.data = (void *)CQSPI_NEEDS_WR_DELAY,\n+\t},\n \t{ /* end of table */ }\n };\n \n", "prefixes": [ "v3", "2/5" ] }