Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/817518/?format=api
{ "id": 817518, "url": "http://patchwork.ozlabs.org/api/patches/817518/?format=api", "web_url": "http://patchwork.ozlabs.org/project/openvswitch/patch/1506088063-20920-2-git-send-email-billy.o.mahony@intel.com/", "project": { "id": 47, "url": "http://patchwork.ozlabs.org/api/projects/47/?format=api", "name": "Open vSwitch", "link_name": "openvswitch", "list_id": "ovs-dev.openvswitch.org", "list_email": "ovs-dev@openvswitch.org", "web_url": "http://openvswitch.org/", "scm_url": "git@github.com:openvswitch/ovs.git", "webscm_url": "https://github.com/openvswitch/ovs", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1506088063-20920-2-git-send-email-billy.o.mahony@intel.com>", "list_archive_url": null, "date": "2017-09-22T13:47:42", "name": "[ovs-dev,RFC,1/2] dpif-netdev: Fix per packet cycles statistics.", "commit_ref": null, "pull_url": null, "state": "rfc", "archived": false, "hash": "966d3392c2a07c9a575f758b1b56373f40620124", "submitter": { "id": 71090, "url": "http://patchwork.ozlabs.org/api/people/71090/?format=api", "name": "Billy O'Mahony", "email": "billy.o.mahony@intel.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/openvswitch/patch/1506088063-20920-2-git-send-email-billy.o.mahony@intel.com/mbox/", "series": [ { "id": 4631, "url": "http://patchwork.ozlabs.org/api/series/4631/?format=api", "web_url": "http://patchwork.ozlabs.org/project/openvswitch/list/?series=4631", "date": "2017-09-22T13:47:41", "name": "EMC load-shedding", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/4631/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/817518/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/817518/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<ovs-dev-bounces@openvswitch.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "dev@openvswitch.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "ovs-dev@mail.linuxfoundation.org" ], "Authentication-Results": "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xzFDz5mJmz9s06\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 22 Sep 2017 23:48:35 +1000 (AEST)", "from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id A60A1BCF;\n\tFri, 22 Sep 2017 13:47:59 +0000 (UTC)", "from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id 5164499F\n\tfor <dev@openvswitch.org>; Fri, 22 Sep 2017 13:47:56 +0000 (UTC)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id D09D246A\n\tfor <dev@openvswitch.org>; Fri, 22 Sep 2017 13:47:55 +0000 (UTC)", "from fmsmga006.fm.intel.com ([10.253.24.20])\n\tby orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t22 Sep 2017 06:47:55 -0700", "from sivswdev01.ir.intel.com (HELO localhost.localdomain)\n\t([10.237.217.45])\n\tby fmsmga006.fm.intel.com with ESMTP; 22 Sep 2017 06:47:54 -0700" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.42,427,1500966000\"; d=\"scan'208\";a=\"154870329\"", "From": "Billy O'Mahony <billy.o.mahony@intel.com>", "To": "dev@openvswitch.org", "Date": "Fri, 22 Sep 2017 14:47:42 +0100", "Message-Id": "<1506088063-20920-2-git-send-email-billy.o.mahony@intel.com>", "X-Mailer": "git-send-email 1.7.0.7", "In-Reply-To": "<1506088063-20920-1-git-send-email-billy.o.mahony@intel.com>", "References": "<1506088063-20920-1-git-send-email-billy.o.mahony@intel.com>", "X-Spam-Status": "No, score=-5.0 required=5.0 tests=RCVD_IN_DNSWL_HI,\n\tRP_MATCHES_RCVD autolearn=disabled version=3.3.1", "X-Spam-Checker-Version": "SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org", "Cc": "i.maximets@samsung.com", "Subject": "[ovs-dev] [RFC 1/2] dpif-netdev: Fix per packet cycles statistics.", "X-BeenThere": "ovs-dev@openvswitch.org", "X-Mailman-Version": "2.1.12", "Precedence": "list", "List-Id": "<ovs-dev.openvswitch.org>", "List-Unsubscribe": "<https://mail.openvswitch.org/mailman/options/ovs-dev>,\n\t<mailto:ovs-dev-request@openvswitch.org?subject=unsubscribe>", "List-Archive": "<http://mail.openvswitch.org/pipermail/ovs-dev/>", "List-Post": "<mailto:ovs-dev@openvswitch.org>", "List-Help": "<mailto:ovs-dev-request@openvswitch.org?subject=help>", "List-Subscribe": "<https://mail.openvswitch.org/mailman/listinfo/ovs-dev>,\n\t<mailto:ovs-dev-request@openvswitch.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Sender": "ovs-dev-bounces@openvswitch.org", "Errors-To": "ovs-dev-bounces@openvswitch.org" }, "content": "From: Ilya Maximets <i.maximets@samsung.com>\n\nDP_STAT_LOOKUP_HIT statistics used mistakenly for calculation\nof total number of packets. This leads to completely wrong\nper packet cycles statistics.\n\nFor example:\n\n\temc hits:0\n\tmegaflow hits:253702308\n\tavg. subtable lookups per hit:1.50\n\tmiss:0\n\tlost:0\n\tavg cycles per packet: 248.32 (157498766585/634255770)\n\n\tIn this case 634255770 total_packets value used for avg\n\tper packet calculation:\n\n\t total_packets = 'megaflow hits' + 'megaflow hits' * 1.5\n\n\tThe real value should be 524.38 (157498766585/253702308)\n\nFix that by summing only stats that reflects match/not match.\nIt's decided to make direct summing of required values instead of\ndisabling some stats in a loop to make calculations more clear and\navoid similar issues in the future.\n\nCC: Jan Scheurich <jan.scheurich@ericsson.com>\nFixes: 3453b4d62a98 (\"dpif-netdev: dpcls per in_port with sorted subtables\")\nSigned-off-by: Ilya Maximets <i.maximets@samsung.com>\nAcked-by: Jan Scheurich <jan.scheurich@ericsson.com>\n---\n lib/dpif-netdev.c | 11 +++++------\n 1 file changed, 5 insertions(+), 6 deletions(-)", "diff": "diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c\nindex 071ec14..e3a5590 100644\n--- a/lib/dpif-netdev.c\n+++ b/lib/dpif-netdev.c\n@@ -796,7 +796,7 @@ pmd_info_show_stats(struct ds *reply,\n unsigned long long stats[DP_N_STATS],\n uint64_t cycles[PMD_N_CYCLES])\n {\n- unsigned long long total_packets = 0;\n+ unsigned long long total_packets;\n uint64_t total_cycles = 0;\n int i;\n \n@@ -812,13 +812,12 @@ pmd_info_show_stats(struct ds *reply,\n } else {\n stats[i] = 0;\n }\n-\n- if (i != DP_STAT_LOST) {\n- /* Lost packets are already included in DP_STAT_MISS */\n- total_packets += stats[i];\n- }\n }\n \n+ /* Sum of all the matched and not matched packets gives the total. */\n+ total_packets = stats[DP_STAT_EXACT_HIT] + stats[DP_STAT_MASKED_HIT]\n+ + stats[DP_STAT_MISS];\n+\n for (i = 0; i < PMD_N_CYCLES; i++) {\n if (cycles[i] > pmd->cycles_zero[i]) {\n cycles[i] -= pmd->cycles_zero[i];\n", "prefixes": [ "ovs-dev", "RFC", "1/2" ] }