[{"id":1773795,"web_url":"http://patchwork.ozlabs.org/comment/1773795/","msgid":"","list_archive_url":null,"date":"2017-09-22T17:52:33","subject":"Re: [ovs-dev] [RFC 1/2] dpif-netdev: Fix per packet cycles\n\tstatistics.","submitter":{"id":68212,"url":"http://patchwork.ozlabs.org/api/people/68212/","name":"Darrell Ball","email":"dball@vmware.com"},"content":"Hi Billy\n\nMaybe you need to rebase your branch; this patch was applied a couple weeks ago.\n\nThanks Darrell\n\nOn 9/22/17, 6:47 AM, \"Billy O'Mahony\" wrote:\n\n From: Ilya Maximets \n \n DP_STAT_LOOKUP_HIT statistics used mistakenly for calculation\n of total number of packets. This leads to completely wrong\n per packet cycles statistics.\n \n For example:\n \n \temc hits:0\n \tmegaflow hits:253702308\n \tavg. subtable lookups per hit:1.50\n \tmiss:0\n \tlost:0\n \tavg cycles per packet: 248.32 (157498766585/634255770)\n \n \tIn this case 634255770 total_packets value used for avg\n \tper packet calculation:\n \n \t total_packets = 'megaflow hits' + 'megaflow hits' * 1.5\n \n \tThe real value should be 524.38 (157498766585/253702308)\n \n Fix that by summing only stats that reflects match/not match.\n It's decided to make direct summing of required values instead of\n disabling some stats in a loop to make calculations more clear and\n avoid similar issues in the future.\n \n CC: Jan Scheurich \n Fixes: 3453b4d62a98 (\"dpif-netdev: dpcls per in_port with sorted subtables\")\n Signed-off-by: Ilya Maximets \n Acked-by: Jan Scheurich \n ---\n lib/dpif-netdev.c | 11 +++++------\n 1 file changed, 5 insertions(+), 6 deletions(-)\n \n diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c\n index 071ec14..e3a5590 100644\n --- a/lib/dpif-netdev.c\n +++ b/lib/dpif-netdev.c\n @@ -796,7 +796,7 @@ pmd_info_show_stats(struct ds *reply,\n unsigned long long stats[DP_N_STATS],\n uint64_t cycles[PMD_N_CYCLES])\n {\n - unsigned long long total_packets = 0;\n + unsigned long long total_packets;\n uint64_t total_cycles = 0;\n int i;\n \n @@ -812,13 +812,12 @@ pmd_info_show_stats(struct ds *reply,\n } else {\n stats[i] = 0;\n }\n -\n - if (i != DP_STAT_LOST) {\n - /* Lost packets are already included in DP_STAT_MISS */\n - total_packets += stats[i];\n - }\n }\n \n + /* Sum of all the matched and not matched packets gives the total. */\n + total_packets = stats[DP_STAT_EXACT_HIT] + stats[DP_STAT_MASKED_HIT]\n + + stats[DP_STAT_MISS];\n +\n for (i = 0; i < PMD_N_CYCLES; i++) {\n if (cycles[i] > pmd->cycles_zero[i]) {\n cycles[i] -= pmd->cycles_zero[i];\n -- \n 2.7.4","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","ovs-dev@mail.linuxfoundation.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=onevmw.onmicrosoft.com\n\theader.i=@onevmw.onmicrosoft.com header.b=\"Dqxh/4LS\"; \n\tdkim-atps=neutral","spf=none (sender IP is )\n\tsmtp.mailfrom=dball@vmware.com; "],"Received":["from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xzLfm6YbTz9t3Z\n\tfor ;\n\tSat, 23 Sep 2017 03:52:48 +1000 (AEST)","from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id E70CAAB5;\n\tFri, 22 Sep 2017 17:52:38 +0000 (UTC)","from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id A1ECBA81\n\tfor ; Fri, 22 Sep 2017 17:52:37 +0000 (UTC)","from NAM01-BN3-obe.outbound.protection.outlook.com\n\t(mail-bn3nam01on0074.outbound.protection.outlook.com [104.47.33.74])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id A6891CA\n\tfor ; Fri, 22 Sep 2017 17:52:36 +0000 (UTC)","from MWHPR05MB3406.namprd05.prod.outlook.com (10.174.175.155) by\n\tMWHPR05MB3405.namprd05.prod.outlook.com (10.174.175.154) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id\n\t15.20.77.5; Fri, 22 Sep 2017 17:52:33 +0000","from MWHPR05MB3406.namprd05.prod.outlook.com ([10.174.175.155]) by\n\tMWHPR05MB3406.namprd05.prod.outlook.com ([10.174.175.155]) with\n\tmapi id 15.20.0077.007; Fri, 22 Sep 2017 17:52:33 +0000"],"X-Greylist":"whitelisted by SQLgrey-1.7.6","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=onevmw.onmicrosoft.com; s=selector1-vmware-com;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version;\n\tbh=lfSH2htdOhgd3an03YxJXHnDcvaBmgleyPFJOCidYHk=;\n\tb=Dqxh/4LSogrFIxKcqVpvLg9D1LIhUO9eqwdVmBZ15yHAP6tr8HoXJcJrop4eFjfXyGCAueLD2AQFhclfdcK0UWmIr3+R87EjBxZBtpqfuL8CyOhOY65k/09nSdRN/a2cUEIpsHpJgVqeJ+/A33UqfBUehmNWjxM8bqsYykctLUU=","From":"Darrell Ball ","To":"Billy O'Mahony , \"dev@openvswitch.org\"\n\t","Thread-Topic":"[RFC 1/2] dpif-netdev: Fix per packet cycles statistics.","Thread-Index":"AQHTM6lm6BLsGKWM0EyTlqL31HsWXqLBL84A","Date":"Fri, 22 Sep 2017 17:52:33 +0000","Message-ID":"","References":"<1506088063-20920-1-git-send-email-billy.o.mahony@intel.com>\n\t<1506088063-20920-2-git-send-email-billy.o.mahony@intel.com>","In-Reply-To":"<1506088063-20920-2-git-send-email-billy.o.mahony@intel.com>","Accept-Language":"en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","user-agent":"Microsoft-MacOutlook/f.26.0.170902","authentication-results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=onevmw.onmicrosoft.com\n\theader.i=@onevmw.onmicrosoft.com header.b=\"Dqxh/4LS\"; \n\tdkim-atps=neutral","spf=none (sender IP is )\n\tsmtp.mailfrom=dball@vmware.com; "],"x-originating-ip":"[73.162.236.45]","x-ms-publictraffictype":"Email","x-microsoft-exchange-diagnostics":"1; MWHPR05MB3405;\n\t20:U19uBWETscN/xC4BnbiLsMoWS50ZmnGMKCu1LBqH0LkD5vXnBxIh25yaDB8z2O/qNkCtrPJz1AwvYXzcnU5Aj/v9VKBp3ToTxcLo+oJTjGyWc868U6Xsb5XdSswvlHwiyKzMa+JF6zt1eMU62AVLRKruE69dYGNnnDCCudQdBSg=","x-ms-exchange-antispam-srfa-diagnostics":"SSOS;","x-ms-office365-filtering-correlation-id":"2e61b02b-9e3a-4cfa-e836-08d501e2b3f1","x-microsoft-antispam":"UriScan:; BCL:0; PCL:0;\n\tRULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);\n\tSRVR:MWHPR05MB3405; ","x-ms-traffictypediagnostic":"MWHPR05MB3405:","x-exchange-antispam-report-test":"UriScan:(37575265505322)(7411616537696)(228905959029699); ","x-microsoft-antispam-prvs":"","x-exchange-antispam-report-cfa-test":"BCL:0; PCL:0;\n\tRULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(3002001)(100000703101)(100105400095)(93006095)(93001095)(10201501046)(6041248)(20161123555025)(20161123560025)(20161123564025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);\n\tSRVR:MWHPR05MB3405; BCL:0; PCL:0;\n\tRULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);\n\tSRVR:MWHPR05MB3405; ","x-forefront-prvs":"0438F90F17","x-forefront-antispam-report":"SFV:NSPM;\n\tSFS:(10009020)(6009001)(346002)(376002)(199003)(377454003)(24454002)(189002)(25786009)(229853002)(2900100001)(36756003)(54356999)(53936002)(4326008)(8936002)(2950100002)(6512007)(101416001)(99286003)(189998001)(50986999)(106356001)(316002)(6246003)(14454004)(53546010)(77096006)(305945005)(58126008)(7736002)(110136005)(2906002)(66066001)(2501003)(33656002)(81166006)(105586002)(83506001)(6486002)(6436002)(97736004)(3660700001)(478600001)(68736007)(3280700002)(83716003)(5660300001)(6116002)(81156014)(76176999)(54906003)(6506006)(3846002)(8676002)(102836003)(82746002)(86362001);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:MWHPR05MB3405;\n\tH:MWHPR05MB3406.namprd05.prod.outlook.com; FPR:; SPF:None;\n\tPTR:InfoNoRecords; A:1; MX:1; LANG:en; ","received-spf":"None (protection.outlook.com: vmware.com does not designate\n\tpermitted sender hosts)","spamdiagnosticoutput":"1:99","spamdiagnosticmetadata":"NSPM","Content-ID":"<6150B10C8C1CFA47B851F5E497019CEB@namprd05.prod.outlook.com>","MIME-Version":"1.0","X-OriginatorOrg":"vmware.com","X-MS-Exchange-CrossTenant-originalarrivaltime":"22 Sep 2017 17:52:33.1942\n\t(UTC)","X-MS-Exchange-CrossTenant-fromentityheader":"Hosted","X-MS-Exchange-CrossTenant-id":"b39138ca-3cee-4b4a-a4d6-cd83d9dd62f0","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"MWHPR05MB3405","X-Spam-Status":"No, score=0.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,\n\tRCVD_IN_DNSWL_NONE autolearn=disabled version=3.3.1","X-Spam-Checker-Version":"SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org","Cc":"\"i.maximets@samsung.com\" ","Subject":"Re: [ovs-dev] [RFC 1/2] dpif-netdev: Fix per packet cycles\n\tstatistics.","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.12","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"ovs-dev-bounces@openvswitch.org","Errors-To":"ovs-dev-bounces@openvswitch.org"}}]