Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 817330,
    "url": "http://patchwork.ozlabs.org/api/patches/817330/?format=api",
    "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/20170922061008.14723-4-fw@strlen.de/",
    "project": {
        "id": 7,
        "url": "http://patchwork.ozlabs.org/api/projects/7/?format=api",
        "name": "Linux network development",
        "link_name": "netdev",
        "list_id": "netdev.vger.kernel.org",
        "list_email": "netdev@vger.kernel.org",
        "web_url": null,
        "scm_url": null,
        "webscm_url": null,
        "list_archive_url": "",
        "list_archive_url_format": "",
        "commit_url_format": ""
    },
    "msgid": "<20170922061008.14723-4-fw@strlen.de>",
    "list_archive_url": null,
    "date": "2017-09-22T06:10:05",
    "name": "[net-next,v2,3/6] rtnetlink: add helper to dump qdisc name",
    "commit_ref": null,
    "pull_url": null,
    "state": "rejected",
    "archived": true,
    "hash": "f4b23847b4119c686ba82d791dd979bf93713309",
    "submitter": {
        "id": 1025,
        "url": "http://patchwork.ozlabs.org/api/people/1025/?format=api",
        "name": "Florian Westphal",
        "email": "fw@strlen.de"
    },
    "delegate": {
        "id": 34,
        "url": "http://patchwork.ozlabs.org/api/users/34/?format=api",
        "username": "davem",
        "first_name": "David",
        "last_name": "Miller",
        "email": "davem@davemloft.net"
    },
    "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/20170922061008.14723-4-fw@strlen.de/mbox/",
    "series": [
        {
            "id": 4543,
            "url": "http://patchwork.ozlabs.org/api/series/4543/?format=api",
            "web_url": "http://patchwork.ozlabs.org/project/netdev/list/?series=4543",
            "date": "2017-09-22T06:10:02",
            "name": "rtnetlink: preparation patches for further rtnl lock pushdown/removal",
            "version": 2,
            "mbox": "http://patchwork.ozlabs.org/series/4543/mbox/"
        }
    ],
    "comments": "http://patchwork.ozlabs.org/api/patches/817330/comments/",
    "check": "pending",
    "checks": "http://patchwork.ozlabs.org/api/patches/817330/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<netdev-owner@vger.kernel.org>",
        "X-Original-To": "patchwork-incoming@ozlabs.org",
        "Delivered-To": "patchwork-incoming@ozlabs.org",
        "Authentication-Results": "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)",
        "Received": [
            "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xz33z1xzBz9sNc\n\tfor <patchwork-incoming@ozlabs.org>;\n\tFri, 22 Sep 2017 16:10:07 +1000 (AEST)",
            "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751883AbdIVGKE (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tFri, 22 Sep 2017 02:10:04 -0400",
            "from Chamillionaire.breakpoint.cc ([146.0.238.67]:41590 \"EHLO\n\tChamillionaire.breakpoint.cc\" rhost-flags-OK-OK-OK-OK)\n\tby vger.kernel.org with ESMTP id S1751795AbdIVGKB (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Fri, 22 Sep 2017 02:10:01 -0400",
            "from fw by Chamillionaire.breakpoint.cc with local (Exim 4.84_2)\n\t(envelope-from <fw@breakpoint.cc>)\n\tid 1dvH6l-0003Zn-Qo; Fri, 22 Sep 2017 08:06:39 +0200"
        ],
        "From": "Florian Westphal <fw@strlen.de>",
        "To": "<netdev@vger.kernel.org>",
        "Cc": "Florian Westphal <fw@strlen.de>",
        "Subject": "[PATCH net-next v2 3/6] rtnetlink: add helper to dump qdisc name",
        "Date": "Fri, 22 Sep 2017 08:10:05 +0200",
        "Message-Id": "<20170922061008.14723-4-fw@strlen.de>",
        "X-Mailer": "git-send-email 2.13.5",
        "In-Reply-To": "<20170922061008.14723-1-fw@strlen.de>",
        "References": "<20170922061008.14723-1-fw@strlen.de>",
        "Sender": "netdev-owner@vger.kernel.org",
        "Precedence": "bulk",
        "List-ID": "<netdev.vger.kernel.org>",
        "X-Mailing-List": "netdev@vger.kernel.org"
    },
    "content": "We can use rcu here to make this safe even if we would not hold rtnl:\nqdisc_destroy uses call_rcu to free the Qdisc struct.\n\nSigned-off-by: Florian Westphal <fw@strlen.de>\n---\n net/core/rtnetlink.c | 16 ++++++++++++++--\n 1 file changed, 14 insertions(+), 2 deletions(-)",
    "diff": "diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c\nindex c801212ee40e..ad3f27da37a8 100644\n--- a/net/core/rtnetlink.c\n+++ b/net/core/rtnetlink.c\n@@ -1332,6 +1332,19 @@ static int nla_put_iflink(struct sk_buff *skb, const struct net_device *dev)\n \treturn nla_put_u32(skb, IFLA_LINK, ifindex);\n }\n \n+static int nla_put_qdisc(struct sk_buff *skb, struct net_device *dev)\n+{\n+\tstruct Qdisc *q;\n+\tint ret = 0;\n+\n+\trcu_read_lock();\n+\tq = READ_ONCE(dev->qdisc);\n+\tif (q)\n+\t\tret = nla_put_string(skb, IFLA_QDISC, q->ops->id);\n+\trcu_read_unlock();\n+\treturn ret;\n+}\n+\n static int rtnl_fill_ifinfo(struct sk_buff *skb, struct net_device *dev,\n \t\t\t    int type, u32 pid, u32 seq, u32 change,\n \t\t\t    unsigned int flags, u32 ext_filter_mask,\n@@ -1372,8 +1385,7 @@ static int rtnl_fill_ifinfo(struct sk_buff *skb, struct net_device *dev,\n \t    nla_put_iflink(skb, dev) ||\n \t    put_master_ifindex(skb, dev) ||\n \t    nla_put_u8(skb, IFLA_CARRIER, netif_carrier_ok(dev)) ||\n-\t    (dev->qdisc &&\n-\t     nla_put_string(skb, IFLA_QDISC, dev->qdisc->ops->id)) ||\n+\t    nla_put_qdisc(skb, dev) ||\n \t    (dev->ifalias &&\n \t     nla_put_string(skb, IFLA_IFALIAS, dev->ifalias)) ||\n \t    nla_put_u32(skb, IFLA_CARRIER_CHANGES,\n",
    "prefixes": [
        "net-next",
        "v2",
        "3/6"
    ]
}