[{"id":1774047,"web_url":"http://patchwork.ozlabs.org/comment/1774047/","msgid":"","list_archive_url":null,"date":"2017-09-23T17:03:11","subject":"Re: [PATCH net-next v2 3/6] rtnetlink: add helper to dump qdisc name","submitter":{"id":6918,"url":"http://patchwork.ozlabs.org/api/people/6918/","name":"David Ahern","email":"dsahern@gmail.com"},"content":"On 9/22/17 12:10 AM, Florian Westphal wrote:\n> We can use rcu here to make this safe even if we would not hold rtnl:\n> qdisc_destroy uses call_rcu to free the Qdisc struct.\n> \n> Signed-off-by: Florian Westphal \n> ---\n> net/core/rtnetlink.c | 16 ++++++++++++++--\n> 1 file changed, 14 insertions(+), 2 deletions(-)\n\nReviewed-by: David Ahern ","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"psfNQ+cz\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xzxW84B8lz9tX4\n\tfor ;\n\tSun, 24 Sep 2017 03:03:16 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751465AbdIWRDO (ORCPT );\n\tSat, 23 Sep 2017 13:03:14 -0400","from mail-pg0-f67.google.com ([74.125.83.67]:34587 \"EHLO\n\tmail-pg0-f67.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750778AbdIWRDN (ORCPT\n\t); Sat, 23 Sep 2017 13:03:13 -0400","by mail-pg0-f67.google.com with SMTP id u18so2460167pgo.1\n\tfor ; Sat, 23 Sep 2017 10:03:13 -0700 (PDT)","from dsa-mb.local ([2601:282:800:7292:34fb:fcb:e9c2:fef8])\n\tby smtp.googlemail.com with ESMTPSA id\n\tp88sm4886533pfi.174.2017.09.23.10.03.12\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tSat, 23 Sep 2017 10:03:12 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=subject:to:references:from:message-id:date:user-agent:mime-version\n\t:in-reply-to:content-language:content-transfer-encoding;\n\tbh=3QSBWm784loAzJa00fwNokKlX8sjIw3YAhn6cJlzNrY=;\n\tb=psfNQ+czuWSCtdG2Cmvt0XJtiXUgNglD5HPhvbVZWmW7a6TjjlsPlifLIyxvyEiMka\n\tV1RMLMmrB/CJKC/6mL5ey6GbqH9bJXZscuLp+4Op1uKerbujqGF09/FTL7Y7qka5TEVS\n\tN3uZjkYUMaIXPIQXaf3FqjwEqV2p1U/Op+Zk/zNKzEHNcOl7NSv4dPe98xetoVp9dzRn\n\tOSCMIQAwlepO/NqT2Z2EorN7rFJN2+QlUiKB7wAmTmcCgEGOJKKHgdhgQDN2h4feB/FQ\n\tHPesdZAlpZo3Rg4n66doRbH+EQuqMWCvwdH+EJo8NmT4FeKryGB8WnRO+1FhKbK5sNKk\n\t6Xqg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=3QSBWm784loAzJa00fwNokKlX8sjIw3YAhn6cJlzNrY=;\n\tb=e2HLC0qD4guvnPAnXRer+20dpHRsRwSCleHrYaGQ/2/hHaiTPLxGrezr+6UCFB/lOz\n\t5Np0oqY698r3DelzocLP6icmw/simcgtS/GJ8Tmfaqhn4o13zYV00GdbNR28iBLc6GGd\n\t9s4lrCn4Ru004Dxy2U5rGu+KNbacAvn3WEKtMckvbjgWeXkXtYcC8nYPJVVlBVJpaNKA\n\tAqkwXq0beHeBD36fmUYYCjBp/1orYuKA/2QJlhzakT2ujCK3S1xJBWUMZ0gqxWFqFkSG\n\t/1OUcIjCtm/0YMc8xt3Pzr1h4dnbKw7zJFKv86g44cnrz/57evBP4bE/kY1l3cKoiqyy\n\tROkw==","X-Gm-Message-State":"AHPjjUivXH+KxrhyYiQ8WR+4gnwdDTgobfNU2zvdbth0ulXATxatRnj3\n\t32vqweurkBJZeOss5eSZ0fTw5A==","X-Google-Smtp-Source":"AOwi7QCUhF3AE2MmL9Mr8C9CR29WH09IJqGyFq3zFRTGge3PWuo5OFUwqLj9V0v7/4gupfgKV0vQSw==","X-Received":"by 10.84.129.226 with SMTP id b89mr2697658plb.42.1506186192988; \n\tSat, 23 Sep 2017 10:03:12 -0700 (PDT)","Subject":"Re: [PATCH net-next v2 3/6] rtnetlink: add helper to dump qdisc name","To":"Florian Westphal , netdev@vger.kernel.org","References":"<20170922061008.14723-1-fw@strlen.de>\n\t<20170922061008.14723-4-fw@strlen.de>","From":"David Ahern ","Message-ID":"","Date":"Sat, 23 Sep 2017 11:03:11 -0600","User-Agent":"Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0)\n\tGecko/20100101 Thunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170922061008.14723-4-fw@strlen.de>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1774062,"web_url":"http://patchwork.ozlabs.org/comment/1774062/","msgid":"<1506187888.29839.181.camel@edumazet-glaptop3.roam.corp.google.com>","list_archive_url":null,"date":"2017-09-23T17:31:28","subject":"Re: [PATCH net-next v2 3/6] rtnetlink: add helper to dump qdisc name","submitter":{"id":2404,"url":"http://patchwork.ozlabs.org/api/people/2404/","name":"Eric Dumazet","email":"eric.dumazet@gmail.com"},"content":"On Fri, 2017-09-22 at 08:10 +0200, Florian Westphal wrote:\n> We can use rcu here to make this safe even if we would not hold rtnl:\n> qdisc_destroy uses call_rcu to free the Qdisc struct.\n\n\nWhere do you see call_rcu() called from qdisc_destroy() ?\n\nYou missed this commit I guess\n\n752fbcc33405d6f8249465e4b2c4e420091bb825\n(\"net_sched: no need to free qdisc in RCU callback\")","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"Y6yQt1J1\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xzy7s0WwVz9t16\n\tfor ;\n\tSun, 24 Sep 2017 03:31:36 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751521AbdIWRbb (ORCPT );\n\tSat, 23 Sep 2017 13:31:31 -0400","from mail-pf0-f195.google.com ([209.85.192.195]:34010 \"EHLO\n\tmail-pf0-f195.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750916AbdIWRba (ORCPT\n\t); Sat, 23 Sep 2017 13:31:30 -0400","by mail-pf0-f195.google.com with SMTP id g65so1815436pfe.1\n\tfor ; Sat, 23 Sep 2017 10:31:30 -0700 (PDT)","from [192.168.86.171] (c-67-180-167-114.hsd1.ca.comcast.net.\n\t[67.180.167.114]) by smtp.googlemail.com with ESMTPSA id\n\te76sm5027693pfd.149.2017.09.23.10.31.29\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tSat, 23 Sep 2017 10:31:29 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=message-id:subject:from:to:cc:date:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=NeK0ckwvdFJVMcv8rGqjpg1KkMk0AFsRF02RFudcs80=;\n\tb=Y6yQt1J1uEi1tfRAXIEpHUdTmskFe/+4KWMGjSKiStyRWr+LIAMTQa0C2HKYX1WV9T\n\t4oBMw8ZMDh6cjtpay2k6q34iBak3EXMKeLrW2RM+bVDqdjxVZPqs6tefbpwxGSweLdkr\n\t04rzKTfnNKQ+lMPeWc601uaLF0mR+Uu9AEJdWJlT92c3gmhpJowGNxsxlkvl/dXq8q/j\n\tyDTkO2tUuvyJuRChjGPHJEAFsStREtdaWM8+MZB90H8G2vCBISGzhvU1DoeIOxp/mclN\n\t/Jh1NLB8+t+OZXLIY+DGfZ3KpikdJOUpAKdBb5KjfM/LfrULEn5WsOBUfLN/P0sQ5lwJ\n\tbzEg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=NeK0ckwvdFJVMcv8rGqjpg1KkMk0AFsRF02RFudcs80=;\n\tb=InxdiFLnePeG1uIVxGrHgvxWGHVGUOaR2K1EnqdOb+aRYgR28WosE4/fcC2Z2gRfsL\n\tBJq4vFEAoeVqpx617VPXXWez/qLJpTiSFBYXaoTg2Slf6l0Qu5QnTkaPlrYxSbGXX0xF\n\tDiEeCykycAPew3THg2pxM5m5Ezu0mnh+Is7tgyUp/oTIU1YpTQSpDt8TDCN4s8AqE8oY\n\tTbXz1dnwSJBvyLwhDNZrXehnkeuH4IyQjAuDImRthHxs6sOi38XGXoUxfGmfQZ3X8Ddi\n\t3AjspAyKHsQ4k0ENPSJyCuHk7niipgbLyvC5HQ8DLr6BhE/7PGTVYL3QX31XCdH1wgPu\n\tvZSQ==","X-Gm-Message-State":"AHPjjUgjeumNh44PUOHm9ukifb+El9hwLrLQVmzAqU58NOa00sdKd1RC\n\txwl8d/XpQJG1jYZHnTT0Od6+kQ==","X-Google-Smtp-Source":"AOwi7QAcBUJGmw242wVCPtT2QClN9jSLFqYXbaFuPbwkweB9EkA2EV45X/qWhhvj36KIbuJgdvwcBQ==","X-Received":"by 10.84.240.196 with SMTP id l4mr2666082plt.399.1506187890302; \n\tSat, 23 Sep 2017 10:31:30 -0700 (PDT)","Message-ID":"<1506187888.29839.181.camel@edumazet-glaptop3.roam.corp.google.com>","Subject":"Re: [PATCH net-next v2 3/6] rtnetlink: add helper to dump qdisc name","From":"Eric Dumazet ","To":"Florian Westphal ","Cc":"netdev@vger.kernel.org","Date":"Sat, 23 Sep 2017 10:31:28 -0700","In-Reply-To":"<20170922061008.14723-4-fw@strlen.de>","References":"<20170922061008.14723-1-fw@strlen.de>\n\t<20170922061008.14723-4-fw@strlen.de>","Content-Type":"text/plain; charset=\"UTF-8\"","X-Mailer":"Evolution 3.10.4-0ubuntu2 ","Mime-Version":"1.0","Content-Transfer-Encoding":"7bit","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1774073,"web_url":"http://patchwork.ozlabs.org/comment/1774073/","msgid":"<20170923183847.GC4324@breakpoint.cc>","list_archive_url":null,"date":"2017-09-23T18:38:47","subject":"Re: [PATCH net-next v2 3/6] rtnetlink: add helper to dump qdisc name","submitter":{"id":1025,"url":"http://patchwork.ozlabs.org/api/people/1025/","name":"Florian Westphal","email":"fw@strlen.de"},"content":"Eric Dumazet wrote:\n> On Fri, 2017-09-22 at 08:10 +0200, Florian Westphal wrote:\n> > We can use rcu here to make this safe even if we would not hold rtnl:\n> > qdisc_destroy uses call_rcu to free the Qdisc struct.\n> \n> \n> Where do you see call_rcu() called from qdisc_destroy() ?\n> \n> You missed this commit I guess\n> \n> 752fbcc33405d6f8249465e4b2c4e420091bb825\n> (\"net_sched: no need to free qdisc in RCU callback\")\n\nIndeed, I did, patch dropped, thanks for the heads-up.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xzzjP4Gmtz9t1t\n\tfor ;\n\tSun, 24 Sep 2017 04:42:17 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751462AbdIWSmM (ORCPT );\n\tSat, 23 Sep 2017 14:42:12 -0400","from Chamillionaire.breakpoint.cc ([146.0.238.67]:46770 \"EHLO\n\tChamillionaire.breakpoint.cc\" rhost-flags-OK-OK-OK-OK)\n\tby vger.kernel.org with ESMTP id S1750916AbdIWSmL (ORCPT\n\t); Sat, 23 Sep 2017 14:42:11 -0400","from fw by Chamillionaire.breakpoint.cc with local (Exim 4.84_2)\n\t(envelope-from )\n\tid 1dvpKB-0002lt-A6; Sat, 23 Sep 2017 20:38:47 +0200"],"Date":"Sat, 23 Sep 2017 20:38:47 +0200","From":"Florian Westphal ","To":"Eric Dumazet ","Cc":"Florian Westphal , netdev@vger.kernel.org","Subject":"Re: [PATCH net-next v2 3/6] rtnetlink: add helper to dump qdisc name","Message-ID":"<20170923183847.GC4324@breakpoint.cc>","References":"<20170922061008.14723-1-fw@strlen.de>\n\t<20170922061008.14723-4-fw@strlen.de>\n\t<1506187888.29839.181.camel@edumazet-glaptop3.roam.corp.google.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<1506187888.29839.181.camel@edumazet-glaptop3.roam.corp.google.com>","User-Agent":"Mutt/1.5.23 (2014-03-12)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]