Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/816804/?format=api
{ "id": 816804, "url": "http://patchwork.ozlabs.org/api/patches/816804/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/1b556b3a2fd12c566912541f3c969d4bdc5dde9c.1505915085.git.igor.russkikh@aquantia.com/", "project": { "id": 7, "url": "http://patchwork.ozlabs.org/api/projects/7/?format=api", "name": "Linux network development", "link_name": "netdev", "list_id": "netdev.vger.kernel.org", "list_email": "netdev@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1b556b3a2fd12c566912541f3c969d4bdc5dde9c.1505915085.git.igor.russkikh@aquantia.com>", "list_archive_url": null, "date": "2017-09-21T10:53:39", "name": "[net,1/4] net:ethernet:aquantia: Setup max_mtu in ndev to enable jumbo frames", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "be42b2921f6a918ffbb65feb0f725dc8485bb50c", "submitter": { "id": 72409, "url": "http://patchwork.ozlabs.org/api/people/72409/?format=api", "name": "Igor Russkikh", "email": "igor.russkikh@aquantia.com" }, "delegate": { "id": 34, "url": "http://patchwork.ozlabs.org/api/users/34/?format=api", "username": "davem", "first_name": "David", "last_name": "Miller", "email": "davem@davemloft.net" }, "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/1b556b3a2fd12c566912541f3c969d4bdc5dde9c.1505915085.git.igor.russkikh@aquantia.com/mbox/", "series": [ { "id": 4355, "url": "http://patchwork.ozlabs.org/api/series/4355/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/list/?series=4355", "date": "2017-09-21T10:53:38", "name": "net:ethernet:aquantia: Atlantic driver bugfixes and improvements", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/4355/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/816804/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/816804/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<netdev-owner@vger.kernel.org>", "X-Original-To": "patchwork-incoming@ozlabs.org", "Delivered-To": "patchwork-incoming@ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=AQUANTIA1COM.onmicrosoft.com\n\theader.i=@AQUANTIA1COM.onmicrosoft.com header.b=\"OHjJX12H\"; \n\tdkim-atps=neutral", "spf=none (sender IP is )\n\tsmtp.mailfrom=Igor.Russkikh@aquantia.com; " ], "Received": [ "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xyYQd70G7z9t3Z\n\tfor <patchwork-incoming@ozlabs.org>;\n\tThu, 21 Sep 2017 20:54:33 +1000 (AEST)", "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751706AbdIUKyb (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tThu, 21 Sep 2017 06:54:31 -0400", "from mail-co1nam03on0053.outbound.protection.outlook.com\n\t([104.47.40.53]:28608\n\t\"EHLO NAM03-CO1-obe.outbound.protection.outlook.com\"\n\trhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP\n\tid S1751605AbdIUKy2 (ORCPT <rfc822;netdev@vger.kernel.org>);\n\tThu, 21 Sep 2017 06:54:28 -0400", "from ubuntubox.rdc.aquantia.com (95.79.108.179) by\n\tBY2PR0701MB1958.namprd07.prod.outlook.com (10.163.155.16) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id\n\t15.20.77.7; Thu, 21 Sep 2017 10:54:25 +0000" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=AQUANTIA1COM.onmicrosoft.com; s=selector1-aquantia-com;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version;\n\tbh=6vh9cmZBrtFLlpJZjDaiHhgLnjsvRywm1wt0Rl5gC+E=;\n\tb=OHjJX12HnmfXt0IYh/P2KRJ8+pRv2P2t9DlrSTwpFL4AqgTDfvVOooyIoXIY/2OtU0DhbnuEkkx2RIPs7U/o8pN3w9nhM8wBl7WOLHPTivin8KzhPKI7ZXS7vOGXNEw0dQxUVdArHh18ouEk50gfVcqZC8bGVFzzj5SmB8bujPQ=", "From": "Igor Russkikh <igor.russkikh@aquantia.com>", "To": "\"David S . Miller\" <davem@davemloft.net>", "Cc": "netdev@vger.kernel.org, David Arcari <darcari@redhat.com>,\n\tPavel Belous <Pavel.Belous@aquantia.com>,\n\tNadezhda Krupnina <Nadezhda.Krupnina@aquantia.com>,\n\tSimon Edelhaus <simon.edelhaus@aquantia.com>,\n\tIgor Russkikh <igor.russkikh@aquantia.com>", "Subject": "[PATCH net 1/4] net:ethernet:aquantia: Setup max_mtu in ndev to\n\tenable jumbo frames", "Date": "Thu, 21 Sep 2017 13:53:39 +0300", "Message-Id": "<1b556b3a2fd12c566912541f3c969d4bdc5dde9c.1505915085.git.igor.russkikh@aquantia.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<cover.1505915085.git.igor.russkikh@aquantia.com>", "References": "<cover.1505915085.git.igor.russkikh@aquantia.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[95.79.108.179]", "X-ClientProxiedBy": "VI1PR0501CA0018.eurprd05.prod.outlook.com (10.172.9.156)\n\tTo\n\tBY2PR0701MB1958.namprd07.prod.outlook.com (10.163.155.16)", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-Correlation-Id": "5160551b-b5fb-4d54-f85d-08d500df20df", "X-Microsoft-Antispam": "UriScan:; BCL:0; PCL:0;\n\tRULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);\n\tSRVR:BY2PR0701MB1958; ", "X-Microsoft-Exchange-Diagnostics": [ "1; BY2PR0701MB1958;\n\t3:huVNBIQIFhJsOsbYLLo62CGrDlqx1XvTXTxviJqUw/vTynVUO6QBJgMHBGUhTlZvIBJpBwLyLRnf7a+j0ixYGRDfckyafR1/Y/odk1dBKch9SNJqBYRt6MCV5IS80UGFsf8KKeAJMzwd/OGl67gVdqwtyzLPEHveyCSl2u+AsnAxzuB3r+E1lXUjtjWRe5NzoK9kDhZsfF+TCZyaqjmKVDkJcLftsmFxPFIlOlF1c2Y5DSbr6jZZvimz+F04VKe+;\n\t25:5n+web+eiOpmoGvxeRqG0Ud7eMuf+tjF+y7X1on932G3NMZkzIHkKBuWLYpEX+77SXfRu1Rl6J/kTaOo0e52JNZ91eZNZjEk+Mj/sKazAMpw81hIG5GNs+pa1ii4H1kTPMU3EW5oBaPkmYzFl6WljNVzDD6Xs0rGcXBdDqVgRPyzyroYu1fcuaYKrDX5vbuXoXAZTLtmDbNWBY3EO78XoPKNZ0FLj4V5Zqt8D7eaS7k3iVjZqBbviBFbrFxDBbOPn1MhTPmnfQgKoitTvQptk51jxAqXpVhQzpzxdPn1QEe2RCwGUbh6VqdZi7XPGPuH80Ej1d8xfGXlBqwrH8KMXQ==;\n\t31:TIRM0ydgt/A24CG2xqwP2OtkusbBwT9V5HflpMz90RLEqHgksXiZDuGI8W244o2fyh/v8RQ5rx5P/5q4kqkSMEGphWq4yBi7+n2OfZ8a67GNCjJNABhKZHgAmrPoGwJgR4xqvX9lS2RcEaU0i4WdNgrbPC/1j9xJxDZ0oMz3G1IMLBL4SyyaCmRW1mbtkn5X9wPwei3j+j1Uddmik/mHH+0SS03ZvoA4z0lvbG2x5I0=", "1; BY2PR0701MB1958;\n\t20:nNXTUstP2WkNdJJwQzMF5GtiEjxnF+V6WZA0Z1CT8IDRtTaZlANKGgzwrpheNR4wTwpPjq7WaYA02eAal9eCFR9WOhtDF8gcAnGcXdpAAGNUFOdeskx07JNGORwgeWVDf0YBCmenxYSvBqq6ZDG5jp0iJ6FGFV8a927TqjfjJkZPEyxTp7sdLXYOUaVfeEIb1Ei9tjCMRwugjpNAahN7H4s/Ak5PyRvpMNulK5vZcwNkl7x1Ck2G3KRnzZAHPFs7/e//e8ILV69fICqxKlhKhVx6QSG1qd2ISYs83m0sPgJXwE/FL12H0JgcAsm/qciaB9IHuMe7x+b7qCeSwSUJq4z3ClaRBfIn9rtU9R3cY/T2+TQbyGHcxkrtdtRLChbR8UmJ/7hySRs3szoDDJmPtOEyZo7cvOUa0X6biPkg3x+dgZGtbxHziHJgzlHV+fiLscE2je57QeGw9KTqFt0hiTMzobz481H4+1HshfTeLL3Iyg7RWUvlwmOtdh4PxYkx;\n\t4:MhGlj06GWmC/H3BlcgkiU181fPchRGfkBY6Lpdob2yF9NhuVW4NM/CTo/BxzRKiz1ExwfZp66A4kM2XClPeXKO7+lLPXECcnHXm2ptusiIErpDlj4FzCuXS666RFOEPDLaROkpMzebV8PD9SuGvIXzFdEKKNax6SGFqQFwRz2unmVXLtJtdNLIJo8d/aipNBqEbl8VGmD/lQzdxIRpe+tEovN/U6rerWlFVPk+lxp1Tj1FvzDWNXgim+bC6efuR7", "1; BY2PR0701MB1958;\n\t23:TlAKeYy7dAbsGDvxNZMm+s9OznYjFep866FJdQqNFoEyEkX+k5aZEje74WLYX+0ffyKwTcE1W6TfRJB5rOiCJNVXHoVjIF+7QLiKz1CSxwAGw7QyCgcDq9jUY4ztulzb58t1ownfNb1MRop/689A09s4rgLhy6BgZGWu5C+P5sPtbtLb/Z4aWdn3gEvXX3JxKmb7KnviRuFmLxnoy6PZuG3xlDuGJnRto+XxnjH+P5zfCYNoD0v7J9FiAd7ppfrdYfHUqUnexGd1JujufktiNEzxAgPRydYyp5EbtK2AJpqSJVOlpGaFOxqHheiWruVewG405WSX3z7gtE8bADijlOrXmgr5BmlUoQrlBRrjp8F6CrrM/sa3dp05cHFQr5w/Eke//PaO1vqw7+zzgd2Xu2eGTvHkD4Jm+vTlCG+ALqGXLxTj8I97+tGr5iTJCqmQdO1EVlTksqrBg4vr+Vt4gZkuE272lrXiLII8Ou4xms39wh551v/3QMtxGOcMFjOiv+WZrsQ2fHtoKiy9aUK2y39kqx5n2ayxdzXth4fkJP7984LeSArAR4zcZu/uUZp5LI2Yv3AWOHLicvK1CwGyP5SXPadB/FOs+OvrM/Qf8xqNCtSknZxqPTrjXC1qQ2S908d1KwEZ3pgnJ4Wfqo96hB/rkzJOXsR7Z4Y8hiS932Ima3WAA4VWkLqEZ9ZvfzCd9Tgdq8bNwatdt8McnGmh91Fn+wXeaV2lXga8Eb58KdgJVTKUy8G1/X0FkJosggQGkTti5fwn7/24wlEsg9HPsUaGpxqP3DH9yqT0R5BO+EEH2+FXgkj5MN8WFIJRKnhIwSsxwbIaGsA1hBA5G/v3MlrMzYGqj2TY+seQZ7IlYqFj2TZ2KuhHEm1i2CW8sps3/9mtlcbODY21OFUsVg2aQe64fenFNvXodpninJd+bossbrmUgwZ2GEnaX9EhsXMS7vGKmITI6+6OhzptKVA58stIOkfPCtDPX/OD+uw8xMUSl7AxvpHo08HjC8XEXMbHUqhrZRZ6coiFVElS0mjRfyXobNhmkY8tXKiPxl3frDGLDa0rKRo/qvEr3VdIbIsLnu11fGpNcfZJESs4xdiNQvwLoqoZSecc9fuTUszhOEWOKBeER3Xzcvl+B0/eSw4u", "1; BY2PR0701MB1958;\n\t6:ZIOeoEwG1fsP+ZBbyTZ9mv6AQjnM7D4PDKK1G+XUgfOMAIJMDnuqRyvi7JTmcaqfzChnsflofNolin5cY2UfWMy4F6gNnSo1FHHxLxbchamaDRTAv177/84IIbn+V8vjWtvTczTL21INRBkNHXbkU1heHX7S7gUWaIC+76kcPbI1Sndv5elNrI+4s3KABTPxWCxPERiOOGAest3LjvqxPdkbuVX3R93dnbso1zYlPNCzObTUHz/uHjqp8+7HKliGKvLJi4yzHqbPzztimS5MP5+on9sM7ZMUHYlF86sLbqoSeRgC8ZjwStu+PiwcNbJRmMENMkMukVpIXBpV79qZig==;\n\t5:/2heHC2bPDpNbY/EYSR52LM8ZB3XfFzay//OfjeupmVaooGiLsuOppX8MkH/hOcOkdcI35K7ccX5epkEg4vir3VTzsx9OhR9f2ycp2/cQj8cydsslf227HIpuTv1tYwjIfFe7g2Tof5/OrYD2GTvRg==;\n\t24:6K5z4ta7xrvF33x7NoGJyo8Dc2WXnlyMNVK/IHH0TARhjV63II8haRXXZWR1j7LuAgg93vLRLG9O4bdWvQY0n32DaKylFtub9k6OHSWnF1U=;\n\t7:KuLaC8vXwlrMmiZWr7SkdKyNzhNlll2N6L5aS35v7sWPBnrAMuG1x4QwDKfqpc5+cRyxJhfiUBIkTWElslrP41XDtJGWI1F+nyvAQVDiwPEmjij8AI5jw17jlfNj+7uKQqSkVjT1uIWRxzhdr80JDIUGL8BQKz+zWhu0N9Av4KvLy00L8XNPJE6lAuynoRBic3z6rLH7zo5Et2YcrJC46ejqdZREl7oW5F8gSJJCdxE=" ], "X-MS-TrafficTypeDiagnostic": "BY2PR0701MB1958:", "X-Exchange-Antispam-Report-Test": "UriScan:;", "X-Microsoft-Antispam-PRVS": "<BY2PR0701MB1958523CE2ABC579ADD8CEF498660@BY2PR0701MB1958.namprd07.prod.outlook.com>", "X-Exchange-Antispam-Report-CFA-Test": "BCL:0; PCL:0;\n\tRULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(100000703101)(100105400095)(10201501046)(3002001)(93006095)(93001095)(6041248)(20161123558100)(20161123555025)(20161123560025)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);\n\tSRVR:BY2PR0701MB1958; BCL:0; PCL:0;\n\tRULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);\n\tSRVR:BY2PR0701MB1958; ", "X-Forefront-PRVS": "04371797A5", "X-Forefront-Antispam-Report": "SFV:NSPM;\n\tSFS:(10009020)(6009001)(39830400002)(376002)(346002)(199003)(189002)(6486002)(189998001)(86362001)(81156014)(4326008)(33646002)(68736007)(8676002)(72206003)(478600001)(81166006)(16586007)(316002)(101416001)(16526017)(54906003)(36756003)(2950100002)(6666003)(6916009)(97736004)(5660300001)(50466002)(118296001)(48376002)(50226002)(76176999)(106356001)(2906002)(53936002)(25786009)(50986999)(105586002)(107886003)(5003940100001)(66066001)(8936002)(47776003)(6116002)(3846002)(305945005)(7736002);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:BY2PR0701MB1958;\n\tH:ubuntubox.rdc.aquantia.com; FPR:; SPF:None;\n\tPTR:InfoNoRecords; A:1; MX:1; LANG:en; ", "Received-SPF": "None (protection.outlook.com: aquantia.com does not designate\n\tpermitted sender hosts)", "SpamDiagnosticOutput": "1:99", "SpamDiagnosticMetadata": "NSPM", "X-OriginatorOrg": "aquantia.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "21 Sep 2017 10:54:25.0329\n\t(UTC)", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "83e2e134-991c-4ede-8ced-34d47e38e6b1", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "BY2PR0701MB1958", "Sender": "netdev-owner@vger.kernel.org", "Precedence": "bulk", "List-ID": "<netdev.vger.kernel.org>", "X-Mailing-List": "netdev@vger.kernel.org" }, "content": "Although hardware is capable for almost 16K MTU, without max_mtu field\ncorrectly set it only allows standard MTU to be used.\nThis patch enables max MTU, calculating it from hardware maximum frame size\nof 16352 octets (including FCS).\n\nFixes: 5513e16421cb (\"net: ethernet: aquantia: Fixes for aq_ndev_change_mtu\")\n\nSigned-off-by: Pavel Belous <Pavel.Belous@aquantia.com>\nSigned-off-by: Igor Russkikh <igor.russkikh@aquantia.com>\n---\n drivers/net/ethernet/aquantia/atlantic/aq_nic.c | 5 +++--\n drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_b0_internal.h | 2 +-\n 2 files changed, 4 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/aquantia/atlantic/aq_nic.c b/drivers/net/ethernet/aquantia/atlantic/aq_nic.c\nindex 6ac9e26..f281392 100644\n--- a/drivers/net/ethernet/aquantia/atlantic/aq_nic.c\n+++ b/drivers/net/ethernet/aquantia/atlantic/aq_nic.c\n@@ -214,7 +214,6 @@ struct aq_nic_s *aq_nic_alloc_cold(const struct net_device_ops *ndev_ops,\n \tSET_NETDEV_DEV(ndev, dev);\n \n \tndev->if_port = port;\n-\tndev->min_mtu = ETH_MIN_MTU;\n \tself->ndev = ndev;\n \n \tself->aq_pci_func = aq_pci_func;\n@@ -283,6 +282,8 @@ int aq_nic_ndev_init(struct aq_nic_s *self)\n \tself->ndev->features = aq_hw_caps->hw_features;\n \tself->ndev->priv_flags = aq_hw_caps->hw_priv_flags;\n \tself->ndev->mtu = aq_nic_cfg->mtu - ETH_HLEN;\n+\tself->ndev->min_mtu = ETH_MIN_MTU;\n+\tself->ndev->max_mtu = self->aq_hw_caps.mtu - ETH_FCS_LEN - ETH_HLEN;\n \n \treturn 0;\n }\n@@ -695,7 +696,7 @@ int aq_nic_set_mtu(struct aq_nic_s *self, int new_mtu)\n {\n \tint err = 0;\n \n-\tif (new_mtu > self->aq_hw_caps.mtu) {\n+\tif (new_mtu + ETH_FCS_LEN > self->aq_hw_caps.mtu) {\n \t\terr = -EINVAL;\n \t\tgoto err_exit;\n \t}\ndiff --git a/drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_b0_internal.h b/drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_b0_internal.h\nindex f3957e93..fcf89e2 100644\n--- a/drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_b0_internal.h\n+++ b/drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_b0_internal.h\n@@ -16,7 +16,7 @@\n \n #include \"../aq_common.h\"\n \n-#define HW_ATL_B0_MTU_JUMBO (16000U)\n+#define HW_ATL_B0_MTU_JUMBO 16352U\n #define HW_ATL_B0_MTU 1514U\n \n #define HW_ATL_B0_TX_RINGS 4U\n", "prefixes": [ "net", "1/4" ] }