[{"id":1772935,"web_url":"http://patchwork.ozlabs.org/comment/1772935/","msgid":"<20170921153619.GG27589@lunn.ch>","list_archive_url":null,"date":"2017-09-21T15:36:19","subject":"Re: [PATCH net 1/4] net:ethernet:aquantia: Setup max_mtu in ndev to\n\tenable jumbo frames","submitter":{"id":13608,"url":"http://patchwork.ozlabs.org/api/people/13608/","name":"Andrew Lunn","email":"andrew@lunn.ch"},"content":"> @@ -283,6 +282,8 @@ int aq_nic_ndev_init(struct aq_nic_s *self)\n> \tself->ndev->features = aq_hw_caps->hw_features;\n> \tself->ndev->priv_flags = aq_hw_caps->hw_priv_flags;\n> \tself->ndev->mtu = aq_nic_cfg->mtu - ETH_HLEN;\n> +\tself->ndev->min_mtu = ETH_MIN_MTU;\n\nThis is not required. It will default to ETH_MIN_MTU.\n\n Andrew\n\n> +\tself->ndev->max_mtu = self->aq_hw_caps.mtu - ETH_FCS_LEN - ETH_HLEN;\n> \n> \treturn 0;\n> }\n> @@ -695,7 +696,7 @@ int aq_nic_set_mtu(struct aq_nic_s *self, int new_mtu)\n> {\n> \tint err = 0;\n> \n> -\tif (new_mtu > self->aq_hw_caps.mtu) {\n> +\tif (new_mtu + ETH_FCS_LEN > self->aq_hw_caps.mtu) {\n\nIf you have set max_mtu correctly, this cannot happen. But it seems\nodd you don't have ETH_HLEN here, where as when setting max_mtu you\ndo.\n\n Andrew","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xyggr5wl1z9s06\n\tfor ;\n\tFri, 22 Sep 2017 01:36:24 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751862AbdIUPgW (ORCPT );\n\tThu, 21 Sep 2017 11:36:22 -0400","from vps0.lunn.ch ([185.16.172.187]:51422 \"EHLO vps0.lunn.ch\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1751602AbdIUPgW (ORCPT );\n\tThu, 21 Sep 2017 11:36:22 -0400","from andrew by vps0.lunn.ch with local (Exim 4.84_2)\n\t(envelope-from )\n\tid 1dv3WV-0000Pb-9R; Thu, 21 Sep 2017 17:36:19 +0200"],"Date":"Thu, 21 Sep 2017 17:36:19 +0200","From":"Andrew Lunn ","To":"Igor Russkikh ","Cc":"\"David S . Miller\" , netdev@vger.kernel.org,\n\tDavid Arcari ,\n\tPavel Belous ,\n\tNadezhda Krupnina ,\n\tSimon Edelhaus ","Subject":"Re: [PATCH net 1/4] net:ethernet:aquantia: Setup max_mtu in ndev to\n\tenable jumbo frames","Message-ID":"<20170921153619.GG27589@lunn.ch>","References":"\n\t<1b556b3a2fd12c566912541f3c969d4bdc5dde9c.1505915085.git.igor.russkikh@aquantia.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<1b556b3a2fd12c566912541f3c969d4bdc5dde9c.1505915085.git.igor.russkikh@aquantia.com>","User-Agent":"Mutt/1.5.23 (2014-03-12)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1773317,"web_url":"http://patchwork.ozlabs.org/comment/1773317/","msgid":"","list_archive_url":null,"date":"2017-09-22T07:24:30","subject":"Re: [PATCH net 1/4] net:ethernet:aquantia: Setup max_mtu in ndev to\n\tenable jumbo frames","submitter":{"id":72409,"url":"http://patchwork.ozlabs.org/api/people/72409/","name":"Igor Russkikh","email":"igor.russkikh@aquantia.com"},"content":">> \tself->ndev->mtu = aq_nic_cfg->mtu - ETH_HLEN;\n>> +\tself->ndev->min_mtu = ETH_MIN_MTU;\n> This is not required. It will default to ETH_MIN_MTU.\n\nThanks Andrew, true.\n\n>> +\tself->ndev->max_mtu = self->aq_hw_caps.mtu - ETH_FCS_LEN - ETH_HLEN;\n>> \n>> \treturn 0;\n>> }\n>> @@ -695,7 +696,7 @@ int aq_nic_set_mtu(struct aq_nic_s *self, int new_mtu)\n>> {\n>> \tint err = 0;\n>> \n>> -\tif (new_mtu > self->aq_hw_caps.mtu) {\n>> +\tif (new_mtu + ETH_FCS_LEN > self->aq_hw_caps.mtu) {\n> If you have set max_mtu correctly, this cannot happen. But it seems\n> odd you don't have ETH_HLEN here, where as when setting max_mtu you\n> do.\n\nI agree, thats an extra check. Will remove that.\nRegarding ETH_HLEN - the baseline code invokes this function with (new_mtu + ETH_HLEN)  - thats why this check does not add it. In general, that extra level of storage (aq_nic_cfg.mtu field) is almost useless, I'll cleanup this under a separate patchset.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=AQUANTIA1COM.onmicrosoft.com\n\theader.i=@AQUANTIA1COM.onmicrosoft.com header.b=\"Ic3EaeRz\"; \n\tdkim-atps=neutral","spf=none (sender IP is )\n\tsmtp.mailfrom=Igor.Russkikh@aquantia.com; "],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xz4kB55GPz9sNc\n\tfor ;\n\tFri, 22 Sep 2017 17:24:50 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751882AbdIVHYs (ORCPT );\n\tFri, 22 Sep 2017 03:24:48 -0400","from mail-by2nam01on0057.outbound.protection.outlook.com\n\t([104.47.34.57]:40304\n\t\"EHLO NAM01-BY2-obe.outbound.protection.outlook.com\"\n\trhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP\n\tid S1751795AbdIVHYq (ORCPT );\n\tFri, 22 Sep 2017 03:24:46 -0400","from [10.0.3.15] (95.79.108.179) by\n\tSN1PR0701MB1968.namprd07.prod.outlook.com (10.163.131.19) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id\n\t15.20.35.12; Fri, 22 Sep 2017 07:24:42 +0000"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=AQUANTIA1COM.onmicrosoft.com; s=selector1-aquantia-com;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version;\n\tbh=P4eB8DznjG6UCU3edKcM8ObpNH8gI3Bv/q/9OZfEYT4=;\n\tb=Ic3EaeRz9GimUPnGI9U8PgDrxN4B3JdgjADALwe7GDPhnZmmldiW7ZPy/jWAKJIvdrzS7YT3otfur0vNfDWMqIyTcotBnNdZAonIer82lqzdFJyQ7ey9T8f5KdacrtK/8TDe8QMXufaEESi8vAjbYkgtww5G9uL+BKNCyX8EJLY=","Subject":"Re: [PATCH net 1/4] net:ethernet:aquantia: Setup max_mtu in ndev to\n\tenable jumbo frames","To":"Andrew Lunn ","Cc":"\"David S . Miller\" , netdev@vger.kernel.org,\n\tDavid Arcari ,\n\tPavel Belous ,\n\tNadezhda Krupnina ,\n\tSimon Edelhaus ","References":"\n\t<1b556b3a2fd12c566912541f3c969d4bdc5dde9c.1505915085.git.igor.russkikh@aquantia.com>\n\t<20170921153619.GG27589@lunn.ch>","From":"Igor Russkikh ","Message-ID":"","Date":"Fri, 22 Sep 2017 10:24:30 +0300","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170921153619.GG27589@lunn.ch>","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"8bit","Content-Language":"en-US","X-Originating-IP":"[95.79.108.179]","X-ClientProxiedBy":"HE1PR0102CA0027.eurprd01.prod.exchangelabs.com\n\t(10.170.250.40) To SN1PR0701MB1968.namprd07.prod.outlook.com\n\t(10.163.131.19)","X-MS-PublicTrafficType":"Email","X-MS-Office365-Filtering-Correlation-Id":"e2de3829-1e55-45e7-4fa1-08d5018aff79","X-Microsoft-Antispam":"UriScan:; BCL:0; PCL:0;\n\tRULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);\n\tSRVR:SN1PR0701MB1968; ","X-Microsoft-Exchange-Diagnostics":["1; SN1PR0701MB1968;\n\t3:evqssTKY9ZS7rTBt5C/cNZLGbicx8pUl/zM6vgXKzj9p0DyqoP+5BpGGyq7lnfESby87/6knz/Ppe3gMghr4WwHgzj8yNL32eBMJNctZyXMNEiHCIhBDnp/qYAp+UeWLiYjljN/SC8NVp5fiyGGExm97bGAA4KsgX1uLzUycL8CCTmvWe4r65jWr7cc4LZRTWA9juWQkaiPgfl1tTidUsZfddqxdWtohYlJG348airKfM+HtWoa7suKbv8KZdS8y;\n\t25:N/mqnAF0VTinVOtfYQUZvB27BbQsjOoOFHyTOYSY9YEy71DdXhJ1RQaKrDUpOO43mN10T4EJNGVxwYiExJqaQlBvRx1K7aSCFqHCeNo6OKIAf3C6Cea8uckXgAoWXP2JhoIG1XE3lo3MUlpmLjc6oPJOLDZmqRU7AOQ1kvQaJnWFdJWQCxoAKDgmrqyWhMNKnwIT7GezA1Qn/0JrfW+62fJYVnqnSGOvlr6gI/H3yZ6cIb5Zzl72ZYS08/GFOIEsxqcEDFbOPfe8JZSgxnP9svN4I8AGXvSVuTt455ei0fhoovCwgLy9r7A2cNZHZ57bBopvCyVxDf3MQb0LSTfqwA==;\n\t31:yn9aP6E0QoA9CQFC2HRzQaAvE2T7SPr1OM51ci8fpzbW9Gqcw3aCH08znd9iPANFKwbzJXXvzURp5IvNoH1qJl+f5dtUKC9DfpYxBvQYryqh5OWL1wM9W2P7d5bjOQ/537GRvdGzc2a3aMHtqm+8QcGDxitsIE0gd0m8Am7ZQgPtBNkiss+EHMr1CATN8ZNPYsebMvXlx3cIBQ9TO8pfLaM7jMLDNPCb4hTrlNBqb8c=","1; SN1PR0701MB1968;\n\t20:STEYyva4Wfb5ShdwHxm9lZGcLE5uyqWpQE2DUq761nP+LOX59tpZ9PUWKkeSQIBZTx/I3Y6R3A7UhATirUApLqefovK6D+6sAKZEw8IwCAtMbJhkkA62cIpge6wGrPYWgTyzjY+jWV90CIUUfxyYFMEkT9OkgRhoegbhuyoaXy0mWPfVzqy5y3ogTHQCyoGdGqdKMRgdgNOwPLn523cpHzr1879E2FMHQuGxDC2aK7HdpnVWWvT4Cd7S5QlKVNRvq0f91HE8PhldO3RYuP1VdtW9z+2KzIWLOzSvNJU2hfQLtn1Sf0nNNQJLL8dg4Sl7XiqyDADVmbo1PGmSEOyZL7lSpviFwqwfJiUiEGkcvXrS/H5elsmnvSSZ4k3bWv5YLcKaG5ujaSC4zpsMja34MhWm22MOhqWd+bLxhyzz/BhmvfyjsONaL4WDWsHKmxZb5ZY6O7wI8/z0PFati6N3QoHsC04no2euK0rmsxh/hHd6dSSYWFZiIpWOm0aKcwjY;\n\t4:b4QQKcl6mJ6wFZn27oeD5wLULMVL9YyaeWM1kvbZY0Wu1f0ACmzOHiIb23ThPkNDH7ZmlSgCzb2vi4ZBpOI2qMe2jNjfnABfZd85YTQzWUvB1zU9oV0zJzS0vwrH53rgNorm4oRgF6FR7oadKy0EhamDbABO02nvG03yc64aCtEMG+xsCpv6+Sg/Pa9Nw/4dS4HccW5ZZfWhHbAWUmjKRnX3IQCUVwUd25cgnjaXTKHc9z5ZbRhiuH2ekuyqymEY","=?utf-8?q?1=3BSN1PR0701MB1968=3B23=3Awi?=\n\t=?utf-8?q?rwt75HotP1NUGqqEQMs5KWOdjS90ogQsrD6/shxUSXv6LpUaqdx0zvdm?=\n\t=?utf-8?q?KX8n82sJjyx3gTkAL+5XO4C5BEX5m2ulqppwRypSmmrzlgdXmJBQ5Vyo?=\n\t=?utf-8?q?fViaAgJb7py7hTZMr4iPYQp4l/yyH2+F8WeSVu9Kqqh5M8nB3yNlCJAC?=\n\t=?utf-8?q?tQwcJs210IAsqMm9Yo5XOMCJS/yrlAnXnM7GQLm628408vBtEvFWFGYQ?=\n\t=?utf-8?q?l5QCMArxi+u3UE/+F8AsXks6y+YqOJXsK2B9pqMtM/4anrsgid3pkYhy?=\n\t=?utf-8?q?2mc8XYXzLtrsuPdKj+VkGnrPxUzhNmCh6NLii8VBE8znQBFrnhac3ktB?=\n\t=?utf-8?q?YrylvZ0DPtx4B0OGQAAe+hxVX4/dJAUSu5iqWBbz/QcWTluCJhPeoeGo?=\n\t=?utf-8?q?C7klkLKOkz7CC2UMcibQ3CgS3XXlK6s/1vyV8b1vzcEcI6eBytHUqhSf?=\n\t=?utf-8?q?DYuEcmmeSFSNYyePxJoozlvz+hahucYGXWqacQUdquvqGdhezozsPiKl?=\n\t=?utf-8?q?sFgX5AmNFQ/oN0jNP67b9ox05Ez9xC6Hxswbsz8KBZsZTuKUuzjSAa6u?=\n\t=?utf-8?q?t36V7WkbUVltp1c2r5E/81ZoCbLHSxN2WrhwJg7IX9Pe8foFSlFcxYud?=\n\t=?utf-8?q?lRqAayQX68cN9kkOp6m/2/IB7BKxD/qkGlkwfj4qgq/6jce7lJviRCa0?=\n\t=?utf-8?q?vbXrbumG1pUCxDETXh5fGNyqkakKTAMl/jHQuNw782N6+g3XSzcFxON7?=\n\t=?utf-8?q?QsOjh5l7CLFQ+CGCQJQb7Vg0V2a6Rnsmeaj67Dwtw7E+YU8vck1l0Dwq?=\n\t=?utf-8?q?tEJj24y3/UFNEvTSnvAMzpIEMUi+WMZ7UELFFhhkRULcjAdJ6jqGzALM?=\n\t=?utf-8?q?bM5r2cB98lv7vN2UYBecPlVwPmEFdbAMe3QqlPwwtJD8CaNP0HSuxwNt?=\n\t=?utf-8?q?YA8r+UHW3m8IeVFElLoEVuKivM7BUswmdAt9M30v2v6qoeBgLO+o55z8?=\n\t=?utf-8?q?1G9GGsuxKxoyYt9B13u9fT0RL0FHDAnHXwJ/74fSurvYzcXz6pmyIb25?=\n\t=?utf-8?q?P84jwtEGgdlpxtmpNEMjD4txV34ZGN7TXSE5Kp7giqHcFAt3Rz3A/OjE?=\n\t=?utf-8?q?rtG6nXZr/HbgrSGv8eYTdI7JCmcayC2yqnPIGJ0pfKApqAz7Vr5M/njH?=\n\t=?utf-8?q?FqpMuV+GdrOusv4gjNZ8S4jJGdZJghCWz+h1yDmzOWqRg5gUoC3gCKd9?=\n\t=?utf-8?q?35NjhPJbl2wzEJbCvzui9WZMMcAW+qptP0yMbNerVBGAuv6YQHIspoGV?=\n\t=?utf-8?q?umXJyq6+97Zo7L/6L6aZL5mewblP9pJFXjVUF4A7PVaZUtTD0qm0+6oB?=\n\t=?utf-8?q?+gpF5Jf1kU+DoHlUsqOGFVv3UELTaEXadjsSH8Bi4FFvciDLxfYCalMr?=\n\t=?utf-8?q?xL0k21pypoLkjisBd056aXBciGbnYi7eLa1cFuh7Y=3D?=","1; SN1PR0701MB1968;\n\t6:nulQC8cBMyqA8eflipnUg3F1f3q/jnpmbl/mVZ6+TUohjyrDYBMdiazUT8sk5nDFAqFJqel+pEq5ej/r26U2zw70fIAfPTV1qyFJJGpRd2QIOLutCFes0hRO5SiC0GETVTOgECOEs4ZOFq8KBhGl6dvmGVNIAduzVkX4OyMtR2A42Q8YQdGbreGwXImvqg28NHCTmrplPU6qGZK3YiTsniDHRgxtMH+k5DEQAJdAGdCA0wal6I27yKVrfL0pPs+TrUwn/IxxoWSmGwkxsQ1y/ZxcVEzO+smSRa0OU9NZmIUtNynywJvaMMhQ8w6hpjjtl51FYr5vcix7cEwmBwogLA==;\n\t5:qXS/KQz/x1pcz1gzwGT4GceQ012UUJL4pO7Jq6KunHvHwOLCP0odUmWrYiXZJv7+sgNjsXnUtwHPsg/9GbeJmmQ3E+zd/T0RJ9FswR/yKaHqZSGRanOriInSXHKdIRf+pDHLCUyT5rgdK9+WVUCmzw==;\n\t24:peXP5+JCRR8VjmXxA8L8Ar0IHBa4nzY4CqySZQlyNGgrJj4EvUYtDn25j4Dgw0E8KEiAuVSmGPkz6jMB7YecykmdG/extEzbJjnCFE0UWIc=;\n\t7:g0b/Anh3EVsXi/aHXEuW0Z297O1oweCwMPGRBhn1gGTD2McYIg7EF+p6QkrCnpFgL9uFXhrl7AJhK30i36uELQSnBSagNv5BxnoP+y+qKReIhjN9Gwa6X4oKHi7ZdipeDUhYWEajjQPAXWWRvgGsZmW6SkRiFh0tVoyjf30+JARp3OgNPzYG+CWmMCpoWAEQCwp1xhlPkQUIGkklK5K/6P1ldv5I5XfAlm+azXE3+4s="],"X-MS-TrafficTypeDiagnostic":"SN1PR0701MB1968:","X-Exchange-Antispam-Report-Test":"UriScan:;","X-Microsoft-Antispam-PRVS":"","X-Exchange-Antispam-Report-CFA-Test":"BCL:0; PCL:0;\n\tRULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(3002001)(100000703101)(100105400095)(93006095)(93001095)(10201501046)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(20161123560025)(20161123564025)(20161123555025)(20161123562025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);\n\tSRVR:SN1PR0701MB1968; BCL:0; PCL:0;\n\tRULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);\n\tSRVR:SN1PR0701MB1968; ","X-Forefront-PRVS":"0438F90F17","X-Forefront-Antispam-Report":"SFV:NSPM;\n\tSFS:(10009020)(6049001)(6009001)(346002)(39830400002)(376002)(199003)(189002)(31696002)(65806001)(81166006)(76176999)(83506001)(8936002)(81156014)(50466002)(50986999)(6246003)(107886003)(25786009)(23676002)(8676002)(53936002)(54356999)(31686004)(16526017)(7736002)(36756003)(101416001)(4326008)(305945005)(478600001)(72206003)(316002)(58126008)(68736007)(16576012)(229853002)(2906002)(106356001)(6666003)(105586002)(2950100002)(6916009)(5660300001)(3846002)(6116002)(97736004)(65826007)(189998001)(65956001)(66066001)(33646002)(47776003)(64126003)(54906003)(77096006)(86362001)(90366009)(6486002)(2870700001);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:SN1PR0701MB1968; H:[10.0.3.15];\n\tFPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; ","Received-SPF":"None (protection.outlook.com: aquantia.com does not designate\n\tpermitted sender hosts)","SpamDiagnosticOutput":"1:99","SpamDiagnosticMetadata":"NSPM","X-OriginatorOrg":"aquantia.com","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"22 Sep 2017 07:24:42.3859\n\t(UTC)","X-MS-Exchange-CrossTenant-FromEntityHeader":"Hosted","X-MS-Exchange-CrossTenant-Id":"83e2e134-991c-4ede-8ced-34d47e38e6b1","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"SN1PR0701MB1968","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]