Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/816295/?format=api
{ "id": 816295, "url": "http://patchwork.ozlabs.org/api/patches/816295/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20170920114637.42004-18-aik@ozlabs.ru/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170920114637.42004-18-aik@ozlabs.ru>", "list_archive_url": null, "date": "2017-09-20T11:46:36", "name": "[qemu,v4,17/18] memory: Create FlatView directly", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "68c670be937361935cae94873b832a41a1eca023", "submitter": { "id": 7621, "url": "http://patchwork.ozlabs.org/api/people/7621/?format=api", "name": "Alexey Kardashevskiy", "email": "aik@ozlabs.ru" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20170920114637.42004-18-aik@ozlabs.ru/mbox/", "series": [ { "id": 4138, "url": "http://patchwork.ozlabs.org/api/series/4138/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=4138", "date": "2017-09-20T11:46:20", "name": "memory: Reduce memory use", "version": 4, "mbox": "http://patchwork.ozlabs.org/series/4138/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/816295/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/816295/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xy3HH1DJLz9s7B\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 21 Sep 2017 01:16:23 +1000 (AEST)", "from localhost ([::1]:48773 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dugjc-0003uB-Be\n\tfor incoming@patchwork.ozlabs.org; Wed, 20 Sep 2017 11:16:20 -0400", "from eggs.gnu.org ([2001:4830:134:3::10]:56359)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <aik@ozlabs.ru>) id 1dufmG-0003O6-NA\n\tfor qemu-devel@nongnu.org; Wed, 20 Sep 2017 10:15:01 -0400", "from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <aik@ozlabs.ru>) id 1dufmE-00058R-6u\n\tfor qemu-devel@nongnu.org; Wed, 20 Sep 2017 10:15:00 -0400", "from ozlabs.ru ([107.173.13.209]:59756)\n\tby eggs.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <aik@ozlabs.ru>) id 1dufmD-00057l-T7\n\tfor qemu-devel@nongnu.org; Wed, 20 Sep 2017 10:14:58 -0400", "from vpl1.ozlabs.ibm.com (localhost [IPv6:::1])\n\tby ozlabs.ru (Postfix) with ESMTP id 0D8173A60060;\n\tWed, 20 Sep 2017 07:48:16 -0400 (EDT)" ], "From": "Alexey Kardashevskiy <aik@ozlabs.ru>", "To": "qemu-devel@nongnu.org", "Date": "Wed, 20 Sep 2017 21:46:36 +1000", "Message-Id": "<20170920114637.42004-18-aik@ozlabs.ru>", "X-Mailer": "git-send-email 2.11.0", "In-Reply-To": "<20170920114637.42004-1-aik@ozlabs.ru>", "References": "<20170920114637.42004-1-aik@ozlabs.ru>", "X-detected-operating-system": "by eggs.gnu.org: GNU/Linux 3.x [fuzzy]", "X-Received-From": "107.173.13.209", "Subject": "[Qemu-devel] [PATCH qemu v4 17/18] memory: Create FlatView directly", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<http://lists.nongnu.org/archive/html/qemu-devel/>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Cc": "Alexey Kardashevskiy <aik@ozlabs.ru>, Paolo Bonzini <pbonzini@redhat.com>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "This avoids usual memory_region_transaction_commit() which rebuilds\nall FVs.\n\nOn POWER8 with 255 CPUs, 255 virtio-net, 40 PCI bridges guest this brings\ndown the boot time from 25s to 20s and reduces the amount of temporary FVs\nallocated during machine constructon (~800000 -> ~640000) and amount of\ntemporary dispatch trees (~370000 -> ~300000), the total memory footprint\ngoes down (18G -> 17G).\n\nSigned-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>\n---\n memory.c | 18 +++++++++++++++---\n 1 file changed, 15 insertions(+), 3 deletions(-)", "diff": "diff --git a/memory.c b/memory.c\nindex 25000d1035..d3b3581990 100644\n--- a/memory.c\n+++ b/memory.c\n@@ -1020,6 +1020,20 @@ static void flatview_set_to_address_space(AddressSpace *as)\n }\n }\n \n+static void flatview_update_topology_single(AddressSpace *as)\n+{\n+ MemoryRegion *physmr = memory_region_get_flatview_root(as->root);\n+ FlatView *new_view;\n+\n+ flatviews_init();\n+ new_view = g_hash_table_lookup(flat_views, physmr);\n+ if (!new_view) {\n+ new_view = generate_memory_topology(physmr);\n+ g_hash_table_insert(flat_views, physmr, new_view);\n+ }\n+ flatview_set_to_address_space(as);\n+}\n+\n void memory_region_transaction_begin(void)\n {\n qemu_flush_coalesced_mmio_buffer();\n@@ -2731,7 +2745,6 @@ void memory_region_invalidate_mmio_ptr(MemoryRegion *mr, hwaddr offset,\n void address_space_init(AddressSpace *as, MemoryRegion *root, const char *name)\n {\n memory_region_ref(root);\n- memory_region_transaction_begin();\n as->root = root;\n as->current_map = NULL;\n as->ioeventfd_nb = 0;\n@@ -2739,8 +2752,7 @@ void address_space_init(AddressSpace *as, MemoryRegion *root, const char *name)\n QTAILQ_INIT(&as->listeners);\n QTAILQ_INSERT_TAIL(&address_spaces, as, address_spaces_link);\n as->name = g_strdup(name ? name : \"anonymous\");\n- memory_region_update_pending |= root->enabled;\n- memory_region_transaction_commit();\n+ flatview_update_topology_single(as);\n }\n \n static void do_address_space_destroy(AddressSpace *as)\n", "prefixes": [ "qemu", "v4", "17/18" ] }