[{"id":1772093,"web_url":"http://patchwork.ozlabs.org/comment/1772093/","msgid":"<4fdf215f-de6f-7bb1-51e7-cdf2d0c076a0@redhat.com>","list_archive_url":null,"date":"2017-09-20T17:18:56","subject":"Re: [Qemu-devel] [PATCH qemu v4 17/18] memory: Create FlatView\n\tdirectly","submitter":{"id":2701,"url":"http://patchwork.ozlabs.org/api/people/2701/","name":"Paolo Bonzini","email":"pbonzini@redhat.com"},"content":"On 20/09/2017 13:46, Alexey Kardashevskiy wrote:\n> +static void flatview_update_topology_single(AddressSpace *as)\n\naddress_space_update_topology?\n\nThanks,\n\nPaolo\n\n> +{\n> + MemoryRegion *physmr = memory_region_get_flatview_root(as->root);\n> + FlatView *new_view;\n> +\n> + flatviews_init();\n> + new_view = g_hash_table_lookup(flat_views, physmr);\n> + if (!new_view) {\n> + new_view = generate_memory_topology(physmr);\n> + g_hash_table_insert(flat_views, physmr, new_view);\n> + }\n> + flatview_set_to_address_space(as);\n> +}\n> +\n> void memory_region_transaction_begin(void)\n> {\n> qemu_flush_coalesced_mmio_buffer();\n> @@ -2731,7 +2745,6 @@ void memory_region_invalidate_mmio_ptr(MemoryRegion *mr, hwaddr offset,\n> void address_space_init(AddressSpace *as, MemoryRegion *root, const char *name)\n> {\n> memory_region_ref(root);\n> - memory_region_transaction_begin();\n> as->root = root;\n> as->current_map = NULL;\n> as->ioeventfd_nb = 0;\n> @@ -2739,8 +2752,7 @@ void address_space_init(AddressSpace *as, MemoryRegion *root, const char *name)\n> QTAILQ_INIT(&as->listeners);\n> QTAILQ_INSERT_TAIL(&address_spaces, as, address_spaces_link);\n> as->name = g_strdup(name ? name : \"anonymous\");\n> - memory_region_update_pending |= root->enabled;\n> - memory_region_transaction_commit();\n> + flatview_update_topology_single(as);","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx08.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx08.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=pbonzini@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xy61m63M2z9s0Z\n\tfor ;\n\tThu, 21 Sep 2017 03:19:56 +1000 (AEST)","from localhost ([::1]:49882 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1duifC-0002LV-OV\n\tfor incoming@patchwork.ozlabs.org; Wed, 20 Sep 2017 13:19:54 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:49106)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1duieM-0002H7-FO\n\tfor qemu-devel@nongnu.org; Wed, 20 Sep 2017 13:19:07 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1duieJ-00036r-RQ\n\tfor qemu-devel@nongnu.org; Wed, 20 Sep 2017 13:19:02 -0400","from mx1.redhat.com ([209.132.183.28]:56116)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1duieJ-00036U-Kw\n\tfor qemu-devel@nongnu.org; Wed, 20 Sep 2017 13:18:59 -0400","from smtp.corp.redhat.com\n\t(int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id C1140C052424;\n\tWed, 20 Sep 2017 17:18:58 +0000 (UTC)","from [10.36.117.211] (ovpn-117-211.ams2.redhat.com [10.36.117.211])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 2815C5EDF2;\n\tWed, 20 Sep 2017 17:18:57 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com C1140C052424","To":"Alexey Kardashevskiy , qemu-devel@nongnu.org","References":"<20170920114637.42004-1-aik@ozlabs.ru>\n\t<20170920114637.42004-18-aik@ozlabs.ru>","From":"Paolo Bonzini ","Message-ID":"<4fdf215f-de6f-7bb1-51e7-cdf2d0c076a0@redhat.com>","Date":"Wed, 20 Sep 2017 19:18:56 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170920114637.42004-18-aik@ozlabs.ru>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.15","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.32]);\n\tWed, 20 Sep 2017 17:18:58 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH qemu v4 17/18] memory: Create FlatView\n\tdirectly","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]