Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/816230/?format=api
{ "id": 816230, "url": "http://patchwork.ozlabs.org/api/patches/816230/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20170920124507.18841-3-vsementsov@virtuozzo.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170920124507.18841-3-vsementsov@virtuozzo.com>", "list_archive_url": null, "date": "2017-09-20T12:45:06", "name": "[v3,2/3] block/nbd-client: simplify check in nbd_co_receive_reply", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "485cb3f46f06455accd2ac43159252d71433561b", "submitter": { "id": 66592, "url": "http://patchwork.ozlabs.org/api/people/66592/?format=api", "name": "Vladimir Sementsov-Ogievskiy", "email": "vsementsov@virtuozzo.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20170920124507.18841-3-vsementsov@virtuozzo.com/mbox/", "series": [ { "id": 4119, "url": "http://patchwork.ozlabs.org/api/series/4119/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=4119", "date": "2017-09-20T12:45:06", "name": "nbd client refactoring and fixing", "version": 3, "mbox": "http://patchwork.ozlabs.org/series/4119/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/816230/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/816230/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xy1Dn0VGbz9s7c\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 20 Sep 2017 23:44:09 +1000 (AEST)", "from localhost ([::1]:48164 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dufIN-00087D-2T\n\tfor incoming@patchwork.ozlabs.org; Wed, 20 Sep 2017 09:44:07 -0400", "from eggs.gnu.org ([2001:4830:134:3::10]:36994)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <vsementsov@virtuozzo.com>) id 1duf2H-0003Pj-Qo\n\tfor qemu-devel@nongnu.org; Wed, 20 Sep 2017 09:27:30 -0400", "from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <vsementsov@virtuozzo.com>) id 1duf2G-0004bc-P0\n\tfor qemu-devel@nongnu.org; Wed, 20 Sep 2017 09:27:29 -0400", "from mailhub.sw.ru ([195.214.232.25]:1516 helo=relay.sw.ru)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <vsementsov@virtuozzo.com>)\n\tid 1duf27-0004RB-DG; Wed, 20 Sep 2017 09:27:19 -0400", "from kvm.sw.ru (msk-vpn.virtuozzo.com [195.214.232.6])\n\tby relay.sw.ru (8.13.4/8.13.4) with ESMTP id v8KCj7vo016453;\n\tWed, 20 Sep 2017 15:45:08 +0300 (MSK)" ], "From": "Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>", "To": "qemu-block@nongnu.org, qemu-devel@nongnu.org", "Date": "Wed, 20 Sep 2017 15:45:06 +0300", "Message-Id": "<20170920124507.18841-3-vsementsov@virtuozzo.com>", "X-Mailer": "git-send-email 2.11.1", "In-Reply-To": "<20170920124507.18841-1-vsementsov@virtuozzo.com>", "References": "<20170920124507.18841-1-vsementsov@virtuozzo.com>", "X-detected-operating-system": "by eggs.gnu.org: OpenBSD 3.x [fuzzy]", "X-Received-From": "195.214.232.25", "Subject": "[Qemu-devel] [PATCH v3 2/3] block/nbd-client: simplify check in\n\tnbd_co_receive_reply", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<http://lists.nongnu.org/archive/html/qemu-devel/>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Cc": "kwolf@redhat.com, vsementsov@virtuozzo.com, mreitz@redhat.com,\n\tden@openvz.org, pbonzini@redhat.com", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "If we are woken up from while() loop in nbd_read_reply_entry\nhandles must be equal. If we are woken up from\nnbd_recv_coroutines_wake_all s->quit must be true, so we do\nnot need checking handles equality.\n\nSigned-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>\n---\n block/nbd-client.c | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)", "diff": "diff --git a/block/nbd-client.c b/block/nbd-client.c\nindex acd8e5d007..486bfff9f7 100644\n--- a/block/nbd-client.c\n+++ b/block/nbd-client.c\n@@ -189,9 +189,10 @@ static int nbd_co_receive_reply(NBDClientSession *s,\n s->requests[i].receiving = true;\n qemu_coroutine_yield();\n s->requests[i].receiving = false;\n- if (s->reply.handle != request->handle || !s->ioc || s->quit) {\n+ if (!s->ioc || s->quit) {\n ret = -EIO;\n } else {\n+ assert(s->reply.handle == request->handle);\n ret = -s->reply.error;\n if (qiov && s->reply.error == 0) {\n assert(request->len == iov_size(qiov->iov, qiov->niov));\n", "prefixes": [ "v3", "2/3" ] }