[{"id":1772024,"web_url":"http://patchwork.ozlabs.org/comment/1772024/","msgid":"<66ae5c45-476f-2fcc-4014-6b575d41fc89@redhat.com>","list_archive_url":null,"date":"2017-09-20T15:39:33","subject":"Re: [Qemu-devel] [PATCH v3 2/3] block/nbd-client: simplify check in\n\tnbd_co_receive_reply","submitter":{"id":6591,"url":"http://patchwork.ozlabs.org/api/people/6591/","name":"Eric Blake","email":"eblake@redhat.com"},"content":"On 09/20/2017 07:45 AM, Vladimir Sementsov-Ogievskiy wrote:\n> If we are woken up from while() loop in nbd_read_reply_entry\n> handles must be equal. If we are woken up from\n> nbd_recv_coroutines_wake_all s->quit must be true, so we do\n> not need checking handles equality.\n> \n> Signed-off-by: Vladimir Sementsov-Ogievskiy \n> ---\n> block/nbd-client.c | 3 ++-\n> 1 file changed, 2 insertions(+), 1 deletion(-)\n\nReviewed-by: Eric Blake \n\n> \n> diff --git a/block/nbd-client.c b/block/nbd-client.c\n> index acd8e5d007..486bfff9f7 100644\n> --- a/block/nbd-client.c\n> +++ b/block/nbd-client.c\n> @@ -189,9 +189,10 @@ static int nbd_co_receive_reply(NBDClientSession *s,\n> s->requests[i].receiving = true;\n> qemu_coroutine_yield();\n> s->requests[i].receiving = false;\n> - if (s->reply.handle != request->handle || !s->ioc || s->quit) {\n> + if (!s->ioc || s->quit) {\n> ret = -EIO;\n> } else {\n> + assert(s->reply.handle == request->handle);\n> ret = -s->reply.error;\n> if (qiov && s->reply.error == 0) {\n> assert(request->len == iov_size(qiov->iov, qiov->niov));\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=eblake@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xy4Q06PSZz9sPt\n\tfor ;\n\tThu, 21 Sep 2017 02:07:20 +1000 (AEST)","from localhost ([::1]:49273 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1duhWw-0004v7-HS\n\tfor incoming@patchwork.ozlabs.org; Wed, 20 Sep 2017 12:07:18 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:39360)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1duh6E-0007XF-Qg\n\tfor qemu-devel@nongnu.org; Wed, 20 Sep 2017 11:39:46 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1duh6D-0008Oc-Sa\n\tfor qemu-devel@nongnu.org; Wed, 20 Sep 2017 11:39:42 -0400","from mx1.redhat.com ([209.132.183.28]:58982)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1duh69-0008IV-2B; Wed, 20 Sep 2017 11:39:37 -0400","from smtp.corp.redhat.com\n\t(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id E3F8B129871;\n\tWed, 20 Sep 2017 15:39:35 +0000 (UTC)","from [10.10.124.97] (ovpn-124-97.rdu2.redhat.com [10.10.124.97])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id A68F560E3B;\n\tWed, 20 Sep 2017 15:39:34 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com E3F8B129871","To":"Vladimir Sementsov-Ogievskiy ,\n\tqemu-block@nongnu.org, qemu-devel@nongnu.org","References":"<20170920124507.18841-1-vsementsov@virtuozzo.com>\n\t<20170920124507.18841-3-vsementsov@virtuozzo.com>","From":"Eric Blake ","Openpgp":"url=http://people.redhat.com/eblake/eblake.gpg","Organization":"Red Hat, Inc.","Message-ID":"<66ae5c45-476f-2fcc-4014-6b575d41fc89@redhat.com>","Date":"Wed, 20 Sep 2017 10:39:33 -0500","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170920124507.18841-3-vsementsov@virtuozzo.com>","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\";\n\tboundary=\"3rJDA7tv1EQCaftgqhnf7qrhIGOqx0BVj\"","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.12","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.38]);\n\tWed, 20 Sep 2017 15:39:36 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","X-Content-Filtered-By":"Mailman/MimeDel 2.1.21","Subject":"Re: [Qemu-devel] [PATCH v3 2/3] block/nbd-client: simplify check in\n\tnbd_co_receive_reply","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"kwolf@redhat.com, pbonzini@redhat.com, den@openvz.org, mreitz@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]