Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/816021/?format=api
{ "id": 816021, "url": "http://patchwork.ozlabs.org/api/patches/816021/?format=api", "web_url": "http://patchwork.ozlabs.org/project/openbmc/patch/20170920053020.6860-5-andrew@aj.id.au/", "project": { "id": 56, "url": "http://patchwork.ozlabs.org/api/projects/56/?format=api", "name": "OpenBMC development", "link_name": "openbmc", "list_id": "openbmc.lists.ozlabs.org", "list_email": "openbmc@lists.ozlabs.org", "web_url": "http://github.com/openbmc/", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170920053020.6860-5-andrew@aj.id.au>", "list_archive_url": null, "date": "2017-09-20T05:30:20", "name": "[v2,4/4] watchdog: aspeed: Move init to arch_initcall", "commit_ref": null, "pull_url": null, "state": "not-applicable", "archived": true, "hash": "9849bf0ada7666a44f4be794de85a12781e2203b", "submitter": { "id": 68332, "url": "http://patchwork.ozlabs.org/api/people/68332/?format=api", "name": "Andrew Jeffery", "email": "andrew@aj.id.au" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/openbmc/patch/20170920053020.6860-5-andrew@aj.id.au/mbox/", "series": [ { "id": 4020, "url": "http://patchwork.ozlabs.org/api/series/4020/?format=api", "web_url": "http://patchwork.ozlabs.org/project/openbmc/list/?series=4020", "date": "2017-09-20T05:30:16", "name": "watchdog: aspeed: Retain enabled state and move to arch_initcall", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/4020/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/816021/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/816021/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<openbmc-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "openbmc@lists.ozlabs.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "openbmc@lists.ozlabs.org" ], "Received": [ "from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xxpL343dTz9s82\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 20 Sep 2017 15:32:59 +1000 (AEST)", "from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xxpL32wCfzDqYw\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 20 Sep 2017 15:32:59 +1000 (AEST)", "from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com\n\t[66.111.4.25])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xxpHz5zJyzDqXw;\n\tWed, 20 Sep 2017 15:31:11 +1000 (AEST)", "from compute4.internal (compute4.nyi.internal [10.202.2.44])\n\tby mailout.nyi.internal (Postfix) with ESMTP id B373821180;\n\tWed, 20 Sep 2017 01:31:09 -0400 (EDT)", "from frontend1 ([10.202.2.160])\n\tby compute4.internal (MEProxy); Wed, 20 Sep 2017 01:31:09 -0400", "from keelia.au.ibm.com (unknown [203.0.153.9])\n\tby mail.messagingengine.com (Postfix) with ESMTPA id 3BEDE7E5EE;\n\tWed, 20 Sep 2017 01:31:05 -0400 (EDT)" ], "Authentication-Results": [ "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=aj.id.au header.i=@aj.id.au header.b=\"sX/Kig6H\";\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=messagingengine.com\n\theader.i=@messagingengine.com header.b=\"gz5lg6Xq\"; \n\tdkim-atps=neutral", "lists.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=aj.id.au header.i=@aj.id.au header.b=\"sX/Kig6H\";\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=messagingengine.com\n\theader.i=@messagingengine.com header.b=\"gz5lg6Xq\"; \n\tdkim-atps=neutral", "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=aj.id.au\n\t(client-ip=66.111.4.25; helo=out1-smtp.messagingengine.com;\n\tenvelope-from=andrew@aj.id.au; receiver=<UNKNOWN>)", "lists.ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=aj.id.au header.i=@aj.id.au header.b=\"sX/Kig6H\";\n\tdkim=pass (2048-bit key;\n\tunprotected) header.d=messagingengine.com\n\theader.i=@messagingengine.com\n\theader.b=\"gz5lg6Xq\"; dkim-atps=neutral" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=aj.id.au; h=cc\n\t:date:from:in-reply-to:message-id:references:subject:to\n\t:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s=fm1; bh=piamhm\n\tGWU1D+LC3R+hmkfdOs2K30OTFSsDxNvKPm1ts=; b=sX/Kig6HZ4PLcTHeIoq6Pn\n\tvp82zEUmrLo8tb2sMIr97OrXZxWJ1AfidoU4dXrVc0mFElBl36Bu3j0CoMqY1ZjK\n\thlpSpM/C7EI3j5vLY/A7Nd5ie2kpU2B5ZUiApohcMl2Qyvb5/gWtHs2tH2D6wDO5\n\tRJ3vR94T83ED8rOD8vY/hn/XeRGncmufsgc/Drb8y0cxCx4UhxIya725ObbSaNxR\n\t8g2n/4QmPFETgBX6D1/aEXTstj/WDFBeRofsofx5xY/bfOKuN9MGvEoy7Iq2PaGF\n\tLpXd+66CaqcsDaRhKhW/dz69Lr3+F6OiWCdiRnEVkH58xvBdMl/aQSwC5eQmTENA\n\t==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n\tmessagingengine.com; h=cc:date:from:in-reply-to:message-id\n\t:references:subject:to:x-me-sender:x-me-sender:x-sasl-enc\n\t:x-sasl-enc; s=fm1; bh=piamhmGWU1D+LC3R+hmkfdOs2K30OTFSsDxNvKPm1\n\tts=; b=gz5lg6XqtzS4lyd/UbDsKLTOvqc1bsOfz18T8uPw95I5FIvYkTavrWIgR\n\twwJ5q4LnTW0qlsBQynkjMpjRX2tJ/lvsikaPlIvR+tvoacgs8V6teBE4WlV4wBGF\n\tBCbXdc7j1gVZRxflLO9DVU8iHqaBXgnAFC2vrxbHFJZNDv1N6Sb7STJiMBm8YIDo\n\tra5v3qsoHbShD/NtMfJHuXQHVFu32jx5vXeupO8uVmvA6ohM1w+emLu4ZaAl1AQh\n\tQ3kTE8VYdUJ2tFMvs8LBUzcZCHWRESz0+8ht82jTH5HOtMDRpbU3Diuac75HVa6e\n\tcRi58GTFSEtN8hGSFdGWdqqw/8xFg==" ], "X-ME-Sender": "<xms:Hf3BWdx-n3HQBornNOwQWzABmhsvVUI92nD7cEW9wdIVfvCLnCjRuw>", "X-Sasl-enc": "C+n/PyTIbKm3hP+ZGTOtMesS1c7tXyi/aDZf0Wo9tio8 1505885468", "From": "Andrew Jeffery <andrew@aj.id.au>", "To": "linux-watchdog@vger.kernel.org", "Subject": "[PATCH v2 4/4] watchdog: aspeed: Move init to arch_initcall", "Date": "Wed, 20 Sep 2017 15:00:20 +0930", "Message-Id": "<20170920053020.6860-5-andrew@aj.id.au>", "X-Mailer": "git-send-email 2.11.0", "In-Reply-To": "<20170920053020.6860-1-andrew@aj.id.au>", "References": "<20170920053020.6860-1-andrew@aj.id.au>", "X-BeenThere": "openbmc@lists.ozlabs.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Development list for OpenBMC <openbmc.lists.ozlabs.org>", "List-Unsubscribe": "<https://lists.ozlabs.org/options/openbmc>,\n\t<mailto:openbmc-request@lists.ozlabs.org?subject=unsubscribe>", "List-Archive": "<http://lists.ozlabs.org/pipermail/openbmc/>", "List-Post": "<mailto:openbmc@lists.ozlabs.org>", "List-Help": "<mailto:openbmc-request@lists.ozlabs.org?subject=help>", "List-Subscribe": "<https://lists.ozlabs.org/listinfo/openbmc>,\n\t<mailto:openbmc-request@lists.ozlabs.org?subject=subscribe>", "Cc": "ryan_chen@aspeedtech.com, linux-aspeed@lists.ozlabs.org,\n\tAndrew Jeffery <andrew@aj.id.au>, openbmc@lists.ozlabs.org,\n\tlinux-kernel@vger.kernel.org, wim@iguana.be, linux@roeck-us.net", "Errors-To": "openbmc-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org", "Sender": "\"openbmc\"\n\t<openbmc-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org>" }, "content": "Probing at device_initcall time lead to perverse cases where the\nwatchdog was probed after, say, I2C devices, which then leaves a\npotentially running watchdog at the mercy of I2C device behaviour and\nbus conditions.\n\nLoad the watchdog driver early to ensure that the kernel is patting it\nwell before initialising peripherals.\n\nSigned-off-by: Andrew Jeffery <andrew@aj.id.au>\n---\n drivers/watchdog/aspeed_wdt.c | 13 ++++++++++++-\n 1 file changed, 12 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/watchdog/aspeed_wdt.c b/drivers/watchdog/aspeed_wdt.c\nindex 6c6dd3f4c48d..ca5b91e2eb92 100644\n--- a/drivers/watchdog/aspeed_wdt.c\n+++ b/drivers/watchdog/aspeed_wdt.c\n@@ -316,7 +316,18 @@ static struct platform_driver aspeed_watchdog_driver = {\n \t\t.of_match_table = of_match_ptr(aspeed_wdt_of_table),\n \t},\n };\n-module_platform_driver(aspeed_watchdog_driver);\n+\n+static int __init aspeed_wdt_init(void)\n+{\n+\treturn platform_driver_register(&aspeed_watchdog_driver);\n+}\n+arch_initcall(aspeed_wdt_init);\n+\n+static void __exit aspeed_wdt_exit(void)\n+{\n+\tplatform_driver_unregister(&aspeed_watchdog_driver);\n+}\n+module_exit(aspeed_wdt_exit);\n \n MODULE_DESCRIPTION(\"Aspeed Watchdog Driver\");\n MODULE_LICENSE(\"GPL\");\n", "prefixes": [ "v2", "4/4" ] }