[{"id":1771606,"web_url":"http://patchwork.ozlabs.org/comment/1771606/","msgid":"","list_archive_url":null,"date":"2017-09-20T06:13:41","subject":"Re: [PATCH v2 4/4] watchdog: aspeed: Move init to arch_initcall","submitter":{"id":48628,"url":"http://patchwork.ozlabs.org/api/people/48628/","name":"Joel Stanley","email":"joel@jms.id.au"},"content":"On Wed, Sep 20, 2017 at 3:00 PM, Andrew Jeffery wrote:\n> Probing at device_initcall time lead to perverse cases where the\n> watchdog was probed after, say, I2C devices, which then leaves a\n> potentially running watchdog at the mercy of I2C device behaviour and\n> bus conditions.\n>\n> Load the watchdog driver early to ensure that the kernel is patting it\n> well before initialising peripherals.\n>\n> Signed-off-by: Andrew Jeffery \n\nI agree that we need to make sure the watchdog driver is loaded\nearlier. I think this is the correct method, but I'll defer to Guenter\non this one.\n\nCheers,\n\nJoel","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","openbmc@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","openbmc@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xxqFc2pRzz9s7h\n\tfor ;\n\tWed, 20 Sep 2017 16:14:12 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xxqFc155rzDqT0\n\tfor ;\n\tWed, 20 Sep 2017 16:14:12 +1000 (AEST)","from mail-lf0-x242.google.com (mail-lf0-x242.google.com\n\t[IPv6:2a00:1450:4010:c07::242])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xxqFS6l3YzDqBd;\n\tWed, 20 Sep 2017 16:14:04 +1000 (AEST)","by mail-lf0-x242.google.com with SMTP id q132so819556lfe.4;\n\tTue, 19 Sep 2017 23:14:04 -0700 (PDT)","by 10.25.103.82 with HTTP; Tue, 19 Sep 2017 23:13:41 -0700 (PDT)"],"Authentication-Results":["ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"msYZfayS\"; dkim-atps=neutral","lists.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"msYZfayS\"; dkim-atps=neutral","ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=gmail.com\n\t(client-ip=2a00:1450:4010:c07::242; helo=mail-lf0-x242.google.com;\n\tenvelope-from=joel.stan@gmail.com; receiver=)","lists.ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"msYZfayS\"; dkim-atps=neutral"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=gmsHScqLhMmUTnVg9k1tgfcQ0i5hvOXJ6NMV+zFkUP8=;\n\tb=msYZfaySRH2h4ZKMWrNjOoWY3cWTVIszC5iGst/KYcKqrEKIizXkPvpXLfLXx8Ks7s\n\tsEkqQ8ggo8p5mCbxRu9gnS8JcaU8XAVTEjlxC93XoN0flYv2vPszzb6M0RKVyDErgvq3\n\thLQASPEIYZ+B0HhmckgXupbdQOVamIYIlr4ttFaxK6ci3Xq/bwanEmWjhiCP4RrkZmrX\n\t9I89i+z01r0vIMFIhSBIDi5FkD4WNnKOipejsaMkEZZ7RIgsz4h2A9qhoLt2gLOu6VK1\n\ttNWlkb9QO/Joa2fBCU7kpUiStynaajDL30/DLUf+x+6Mrl26Smgn3bk4I+/4dskpXjvk\n\tDdrg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:sender:in-reply-to:references:from\n\t:date:message-id:subject:to:cc;\n\tbh=gmsHScqLhMmUTnVg9k1tgfcQ0i5hvOXJ6NMV+zFkUP8=;\n\tb=bmyZyF3CUWIaQ2q0iNYYa1sIzc2NtreS/D0B6GzAKGbxZgwFRhFwYHH9yqMqwbibb2\n\tUK9Tt8QTMhxQrPBv4zXo4llPO1NCUFMr5sIlPb3+Fmw4uTONyzlKLMOAzdq0htZzbgL+\n\ttWuQgy9AGi1XFZ31UTKemFM88KtpDXuK3TzWQV7wE5uJx4YGMOYSo09lGl4YIEDWapVr\n\tphHY6+CSoUixQDUiroziKS3GMNwMVnHLEZ/ick1yhVmz3T4tN7ZylAObtxY6bhcWcnDq\n\tx4dT0lr73NEwSYBS0oV1HDYhYEryQnUJ0G1VFDdw2xjzCr9TRjPaE6y8IBbjyBT7CRob\n\t0JoA==","X-Gm-Message-State":"AHPjjUjxBhuP6l8EwIX13iS1xIcyzJeRqWq+AG6AUC4/MeWZ3GVcsmQa\n\tfygwEZaie2NM5fpaF7/m3vgSG2QpAJSwQ8MweDE=","X-Google-Smtp-Source":"AOwi7QCtpsJv9JLwkHPWekG6EvD2/JofKhz2P+kcpPtT/Oay5FY0R7AX5ezE81GXRbgfvRcnlcdL6hO81J05+smk1QA=","X-Received":"by 10.25.23.38 with SMTP id n38mr384373lfi.104.1505888041616;\n\tTue, 19 Sep 2017 23:14:01 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170920053020.6860-5-andrew@aj.id.au>","References":"<20170920053020.6860-1-andrew@aj.id.au>\n\t<20170920053020.6860-5-andrew@aj.id.au>","From":"Joel Stanley ","Date":"Wed, 20 Sep 2017 15:43:41 +0930","X-Google-Sender-Auth":"R7NgMV4MThary1qfKlz8gfoD12I","Message-ID":"","Subject":"Re: [PATCH v2 4/4] watchdog: aspeed: Move init to arch_initcall","To":"Andrew Jeffery ","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"openbmc@lists.ozlabs.org","X-Mailman-Version":"2.1.24","Precedence":"list","List-Id":"Development list for OpenBMC ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Ryan Chen , linux-watchdog@vger.kernel.org,\n\tlinux-aspeed@lists.ozlabs.org,\n\tOpenBMC Maillist , \n\tLinux Kernel Mailing List ,\n\tWim Van Sebroeck , Guenter Roeck ","Errors-To":"openbmc-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org","Sender":"\"openbmc\"\n\t"}},{"id":1788283,"web_url":"http://patchwork.ozlabs.org/comment/1788283/","msgid":"<1508240158.24322.16.camel@aj.id.au>","list_archive_url":null,"date":"2017-10-17T11:35:58","subject":"Re: [PATCH v2 4/4] watchdog: aspeed: Move init to arch_initcall","submitter":{"id":68332,"url":"http://patchwork.ozlabs.org/api/people/68332/","name":"Andrew Jeffery","email":"andrew@aj.id.au"},"content":"On Wed, 2017-09-20 at 15:43 +0930, Joel Stanley wrote:\n> > On Wed, Sep 20, 2017 at 3:00 PM, Andrew Jeffery wrote:\n> > Probing at device_initcall time lead to perverse cases where the\n> > watchdog was probed after, say, I2C devices, which then leaves a\n> > potentially running watchdog at the mercy of I2C device behaviour and\n> > bus conditions.\n> > \n> > Load the watchdog driver early to ensure that the kernel is patting it\n> > well before initialising peripherals.\n> > \n> > Signed-off-by: Andrew Jeffery \n> \n> I agree that we need to make sure the watchdog driver is loaded\n> earlier. I think this is the correct method, but I'll defer to Guenter\n> on this one.\n\nJust following up on Joel's comments: Is there anything else I need to\naddress?\n\nCheers,\n\nAndrew","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","openbmc@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","openbmc@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yGY6l5Qb6z9sPr\n\tfor ;\n\tTue, 17 Oct 2017 22:36:15 +1100 (AEDT)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3yGY6l3MxSzDrGD\n\tfor ;\n\tTue, 17 Oct 2017 22:36:15 +1100 (AEDT)","from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com\n\t[66.111.4.28])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3yGY6b6VQGzDqlv\n\tfor ; Tue, 17 Oct 2017 22:36:07 +1100 (AEDT)","from compute4.internal (compute4.nyi.internal [10.202.2.44])\n\tby mailout.nyi.internal (Postfix) with ESMTP id BBBE620BC9;\n\tTue, 17 Oct 2017 07:36:05 -0400 (EDT)","from frontend2 ([10.202.2.161])\n\tby compute4.internal (MEProxy); Tue, 17 Oct 2017 07:36:05 -0400","from keelia26 (220-253-53-78.dyn.iinet.net.au [220.253.53.78])\n\tby mail.messagingengine.com (Postfix) with ESMTPA id 7501E2479D;\n\tTue, 17 Oct 2017 07:36:02 -0400 (EDT)"],"Authentication-Results":["ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=aj.id.au header.i=@aj.id.au header.b=\"mAEpYnP5\";\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=messagingengine.com\n\theader.i=@messagingengine.com header.b=\"asTXSH4j\"; \n\tdkim-atps=neutral","lists.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=aj.id.au header.i=@aj.id.au header.b=\"mAEpYnP5\";\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=messagingengine.com\n\theader.i=@messagingengine.com header.b=\"asTXSH4j\"; \n\tdkim-atps=neutral","ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=aj.id.au\n\t(client-ip=66.111.4.28; helo=out4-smtp.messagingengine.com;\n\tenvelope-from=andrew@aj.id.au; receiver=)","lists.ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=aj.id.au header.i=@aj.id.au header.b=\"mAEpYnP5\";\n\tdkim=pass (2048-bit key;\n\tunprotected) header.d=messagingengine.com\n\theader.i=@messagingengine.com\n\theader.b=\"asTXSH4j\"; dkim-atps=neutral"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=aj.id.au; h=cc\n\t:content-type:date:from:in-reply-to:message-id:mime-version\n\t:references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=\n\tfm1; bh=EGRUi4mkPWqCLs3YgdbNwnPgHu/gTGlmZam+yVUBj4c=; b=mAEpYnP5\n\tbAogoARXme6kAZmdbNciBh3W5DS7Yh4gMoxMYU1BrJyeFOqp2pk1tqJ2aj598MxJ\n\tWYjb4wqMRdzgWdxE+sm2m5VAG/u9YTEXBV1CENIW2iB79hHPk4Oe3GTtR3iTDQnK\n\tb4MvZuaRNrTR+LCvZFrHdwWEjH8mt5kHZDQXVeUTRYKKrcMA6s7+GzPRrKVbQCkG\n\tKTJuri7jOGUjTEDgEUBpafkxSJlFN6FBUjmmOYVUVyv2XyK6QaUnAN0d2hHbrsPn\n\tZKxvL47/CVUyYngxWbVrv7i/TiEu1efXUXHC4OxXuCOZ7WQlACQJwyuVCplSf1xj\n\tWiBWpjdIVeT7YQ==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n\tmessagingengine.com; h=cc:content-type:date:from:in-reply-to\n\t:message-id:mime-version:references:subject:to:x-me-sender\n\t:x-me-sender:x-sasl-enc; s=fm1; bh=EGRUi4mkPWqCLs3YgdbNwnPgHu/gT\n\tGlmZam+yVUBj4c=; b=asTXSH4jr05ZJ7xdgukljdq0zvwcQpVrmtcJEIx3JTZ+t\n\tCGD7kPqsu09Xo1GRjtcHu0unk6u36d8W2h9VtcWV62N/4qv1vhDn3ZnNilcQNtOY\n\tsC/eNI/vzndNo89e9HAwfGSkqSTNiYVISLQum9QvSCIRBq0SGs+FNnaBTvmyqkQc\n\tC6Er33QRwJQFx0yI3aHMQoqIQ5WxCsV4aJRvYXgXHMnjv9x6PjUdDXzvLF9xbh6b\n\tLWG/bFy53vxEYNramfJ4TZR99VfN64MWBQMAqukmFYYVmU+uMxXSFc1YTobMx9lS\n\t4PACzi3JiQKAVcWEiqmia2VqekA8dhPzPOpGxlfDw=="],"X-ME-Sender":"","Message-ID":"<1508240158.24322.16.camel@aj.id.au>","Subject":"Re: [PATCH v2 4/4] watchdog: aspeed: Move init to arch_initcall","From":"Andrew Jeffery ","To":"Joel Stanley ","Date":"Tue, 17 Oct 2017 22:05:58 +1030","In-Reply-To":"","References":"<20170920053020.6860-1-andrew@aj.id.au>\n\t<20170920053020.6860-5-andrew@aj.id.au>\n\t","Content-Type":"multipart/signed; micalg=\"pgp-sha512\";\n\tprotocol=\"application/pgp-signature\";\n\tboundary=\"=-jY4S5v9IgRxn0LWWmsEZ\"","X-Mailer":"Evolution 3.22.6-1ubuntu1 ","Mime-Version":"1.0","X-BeenThere":"openbmc@lists.ozlabs.org","X-Mailman-Version":"2.1.24","Precedence":"list","List-Id":"Development list for OpenBMC ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Ryan Chen , linux-watchdog@vger.kernel.org,\n\tlinux-aspeed@lists.ozlabs.org,\n\tOpenBMC Maillist , \n\tLinux Kernel Mailing List ,\n\tWim Van Sebroeck , Guenter Roeck ","Errors-To":"openbmc-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org","Sender":"\"openbmc\"\n\t"}},{"id":1792247,"web_url":"http://patchwork.ozlabs.org/comment/1792247/","msgid":"<20171022161333.GA20816@roeck-us.net>","list_archive_url":null,"date":"2017-10-22T16:13:33","subject":"Re: [v2,4/4] watchdog: aspeed: Move init to arch_initcall","submitter":{"id":21889,"url":"http://patchwork.ozlabs.org/api/people/21889/","name":"Guenter Roeck","email":"linux@roeck-us.net"},"content":"On Wed, Sep 20, 2017 at 03:00:20PM +0930, Andrew Jeffery wrote:\n> Probing at device_initcall time lead to perverse cases where the\n> watchdog was probed after, say, I2C devices, which then leaves a\n> potentially running watchdog at the mercy of I2C device behaviour and\n> bus conditions.\n> \n> Load the watchdog driver early to ensure that the kernel is patting it\n> well before initialising peripherals.\n> \n> Signed-off-by: Andrew Jeffery \n\nAt some point we'll need to come up with a generic means to handle those\nsituations. Until then, I don't have a better idea.\n\nReviewed-by: Guenter Roeck \n\n> ---\n> drivers/watchdog/aspeed_wdt.c | 13 ++++++++++++-\n> 1 file changed, 12 insertions(+), 1 deletion(-)\n> \n> diff --git a/drivers/watchdog/aspeed_wdt.c b/drivers/watchdog/aspeed_wdt.c\n> index 6c6dd3f4c48d..ca5b91e2eb92 100644\n> --- a/drivers/watchdog/aspeed_wdt.c\n> +++ b/drivers/watchdog/aspeed_wdt.c\n> @@ -316,7 +316,18 @@ static struct platform_driver aspeed_watchdog_driver = {\n> \t\t.of_match_table = of_match_ptr(aspeed_wdt_of_table),\n> \t},\n> };\n> -module_platform_driver(aspeed_watchdog_driver);\n> +\n> +static int __init aspeed_wdt_init(void)\n> +{\n> +\treturn platform_driver_register(&aspeed_watchdog_driver);\n> +}\n> +arch_initcall(aspeed_wdt_init);\n> +\n> +static void __exit aspeed_wdt_exit(void)\n> +{\n> +\tplatform_driver_unregister(&aspeed_watchdog_driver);\n> +}\n> +module_exit(aspeed_wdt_exit);\n> \n> MODULE_DESCRIPTION(\"Aspeed Watchdog Driver\");\n> MODULE_LICENSE(\"GPL\");","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","openbmc@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","openbmc@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yKl2j21SCz9t0F\n\tfor ;\n\tMon, 23 Oct 2017 03:13:49 +1100 (AEDT)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3yKl2h6MldzDqZv\n\tfor ;\n\tMon, 23 Oct 2017 03:13:48 +1100 (AEDT)","from mail-pf0-x241.google.com (mail-pf0-x241.google.com\n\t[IPv6:2607:f8b0:400e:c00::241])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3yKl2T40r2zDqZr;\n\tMon, 23 Oct 2017 03:13:36 +1100 (AEDT)","by mail-pf0-x241.google.com with SMTP id 17so15373828pfn.12;\n\tSun, 22 Oct 2017 09:13:36 -0700 (PDT)","from localhost (108-223-40-66.lightspeed.sntcca.sbcglobal.net.\n\t[108.223.40.66]) by smtp.gmail.com with ESMTPSA id\n\tq2sm7456630pgp.81.2017.10.22.09.13.33\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tSun, 22 Oct 2017 09:13:34 -0700 (PDT)"],"Authentication-Results":["ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"r0utC/o+\"; dkim-atps=neutral","lists.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"r0utC/o+\"; dkim-atps=neutral","ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=gmail.com\n\t(client-ip=2607:f8b0:400e:c00::241; helo=mail-pf0-x241.google.com;\n\tenvelope-from=groeck7@gmail.com; receiver=)","lists.ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"r0utC/o+\"; dkim-atps=neutral"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=sender:date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to:user-agent;\n\tbh=YEoAkLjiVHgq18kgrTs+tlq9khcKCAlCRxYoRSXcZVc=;\n\tb=r0utC/o+dphop5ooGVf/PelK9SYjJPvcI4vZVLBrSuygCasieZIetkz2yQniu6z4Xd\n\txJhrrFje+MYxIloyuUBa0pf6HLOSJZvevd1PXv8uIpp5P502N2ysLZRlJvOoNklRWjzn\n\tvjnCVi6/ihmWgbtXJOYWXR0ab98zxyX6ZzBmSm+/lWzIPh6n6RclfjI69G/lyKTl1/Ll\n\tbO2Jf5KmVUhcKnF//VWFiVqVRn3e7XQy08mUE0P9WpJ98YpHf4nFRzIwt3O3ggF8MnM5\n\tkQ1pCZ45eoFXt4cLrOzv1CQBvVshEfVoCi/SIVBdsmXJRVEYxQtA8QkxhRlVQn8dEXNM\n\tYhzw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:date:from:to:cc:subject:message-id\n\t:references:mime-version:content-disposition:in-reply-to:user-agent; \n\tbh=YEoAkLjiVHgq18kgrTs+tlq9khcKCAlCRxYoRSXcZVc=;\n\tb=e2RVfBM5fO6YcqCH/ZbFsf8NenuvU1ZC31QE/2LeGvN49y9uoJ5UJNB6JphkPE+KIX\n\tVsYdsXsAXhKqCBR5AB2Q9McWZ83KK1Cj9a0wd+LZn6wtqDS+b2GcSA52IGd68oiptekM\n\tcHcbBUusGv2UtWK6FNsMP+dkeIoWxVnnRAouaTKNsK7GkiOEZmOq6KN3Et8G3cV/QoqF\n\tPlhHh/Gr+rUHzbqyQqx5Fjuq/E8fSCzWxu8WDV/fr5wK3O+soScNVWC+5fFEKb0ferGG\n\tfRgLfYkSkB1SR1F9+fQKEUH/wmOD9c/BKXeq5C7ZmTFc2X19d8gF8DHua76BoaiMyBVv\n\ttNhQ==","X-Gm-Message-State":"AMCzsaUh0s6Hv9Lf32gDiGg2EdORVrZjygxdRmvMNlkn+yOt8i2NTjW6\n\tNVGkWhsZvTFA9VYmPQXVwkQ=","X-Google-Smtp-Source":"ABhQp+Tf5tAkQkViZPJbHU7hHcZmnJ6EwnU5Xk5qjNO/xzPoZgeHh8B3srhGHdtTaRJ8xwQyTZo1XA==","X-Received":"by 10.98.53.196 with SMTP id c187mr10769637pfa.38.1508688814769; \n\tSun, 22 Oct 2017 09:13:34 -0700 (PDT)","Date":"Sun, 22 Oct 2017 09:13:33 -0700","From":"Guenter Roeck ","To":"Andrew Jeffery ","Subject":"Re: [v2,4/4] watchdog: aspeed: Move init to arch_initcall","Message-ID":"<20171022161333.GA20816@roeck-us.net>","References":"<20170920053020.6860-5-andrew@aj.id.au>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170920053020.6860-5-andrew@aj.id.au>","User-Agent":"Mutt/1.5.24 (2015-08-30)","X-BeenThere":"openbmc@lists.ozlabs.org","X-Mailman-Version":"2.1.24","Precedence":"list","List-Id":"Development list for OpenBMC ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"ryan_chen@aspeedtech.com, linux-watchdog@vger.kernel.org,\n\tlinux-aspeed@lists.ozlabs.org, openbmc@lists.ozlabs.org,\n\tlinux-kernel@vger.kernel.org, wim@iguana.be","Errors-To":"openbmc-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org","Sender":"\"openbmc\"\n\t"}},{"id":1792248,"web_url":"http://patchwork.ozlabs.org/comment/1792248/","msgid":"","list_archive_url":null,"date":"2017-10-22T16:22:05","subject":"Re: [PATCH v2 4/4] watchdog: aspeed: Move init to arch_initcall","submitter":{"id":21889,"url":"http://patchwork.ozlabs.org/api/people/21889/","name":"Guenter Roeck","email":"linux@roeck-us.net"},"content":"On 10/17/2017 04:35 AM, Andrew Jeffery wrote:\n> On Wed, 2017-09-20 at 15:43 +0930, Joel Stanley wrote:\n>>> On Wed, Sep 20, 2017 at 3:00 PM, Andrew Jeffery wrote:\n>>> Probing at device_initcall time lead to perverse cases where the\n>>> watchdog was probed after, say, I2C devices, which then leaves a\n>>> potentially running watchdog at the mercy of I2C device behaviour and\n>>> bus conditions.\n>>>\n>>> Load the watchdog driver early to ensure that the kernel is patting it\n>>> well before initialising peripherals.\n>>>\n>>> Signed-off-by: Andrew Jeffery \n>>\n>> I agree that we need to make sure the watchdog driver is loaded\n>> earlier. I think this is the correct method, but I'll defer to Guenter\n>> on this one.\n> \n> Just following up on Joel's comments: Is there anything else I need to\n> address?\n> \n\nNo. Sorry, I have been terribly busy. Digging through patch backlog today.\n\nGuenter","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","openbmc@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","openbmc@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yKlDS3Djdz9t2S\n\tfor ;\n\tMon, 23 Oct 2017 03:22:16 +1100 (AEDT)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3yKlDS1xnszDrVt\n\tfor ;\n\tMon, 23 Oct 2017 03:22:16 +1100 (AEDT)","from mail-pg0-x242.google.com (mail-pg0-x242.google.com\n\t[IPv6:2607:f8b0:400e:c05::242])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3yKlDL4rX1zDqYc;\n\tMon, 23 Oct 2017 03:22:09 +1100 (AEDT)","by mail-pg0-x242.google.com with SMTP id b192so10015138pga.2;\n\tSun, 22 Oct 2017 09:22:09 -0700 (PDT)","from server.roeck-us.net\n\t(108-223-40-66.lightspeed.sntcca.sbcglobal.net. [108.223.40.66])\n\tby smtp.gmail.com with ESMTPSA id\n\tn72sm9144400pfi.92.2017.10.22.09.22.06\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tSun, 22 Oct 2017 09:22:07 -0700 (PDT)"],"Authentication-Results":["ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"TM8Ndz/w\"; dkim-atps=neutral","lists.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"TM8Ndz/w\"; dkim-atps=neutral","ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=gmail.com\n\t(client-ip=2607:f8b0:400e:c05::242; helo=mail-pg0-x242.google.com;\n\tenvelope-from=groeck7@gmail.com; receiver=)","lists.ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"TM8Ndz/w\"; dkim-atps=neutral"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=sender:subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=Pi/6WgWbu4xHbTNcdme4qRuyl4FFgDQgeiMQ+QLFJ0A=;\n\tb=TM8Ndz/wcKBnBS8G3YzqSJjFjwen4L57tmhqcV3rPGeTFSGBg6OLVA/HPPeT1OW1W7\n\txMRjaTF/d1jiHsWKPdNyRF8qYBufaPjXRFHw2gxlgu+2i28qTLZVfzKq6u8kZQ2tqFwx\n\tZ+rRDfg9WUcW4+X+9AVbXkKYV3Yt2Pj6JakGvUdluwpzvf3ldcn5limKfwn37Y0D/XcF\n\tFSW2h6gC3GO7DBXTo9R8of9wVdosbibMMbZjT2lLSG9Cg15Xguy8N3wWjMe0pciT1rzm\n\tTPdfADl8xzSbTHXMqFbqUZiNhHYZuVH8iZMg94o1vXuRxL6Q2VqWoggbzJSwjdFRPzkz\n\tos0Q==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:subject:to:cc:references:from:message-id\n\t:date:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=Pi/6WgWbu4xHbTNcdme4qRuyl4FFgDQgeiMQ+QLFJ0A=;\n\tb=GN8QOKilCgxDlFEfSjX1NJNuNBjeyVY7BHuDTo4qPv9jkxnBrjQvEpHIjtOiDeCH+T\n\tIQSUlniMzum+2+Fk2Ph0kmK0fzKwl0Qjiom6vagSZwpk54rO/MjDVWJy2vVig540gHjc\n\t9BxDIZiDAS3FnlltDzFZ6qNBXXg2RlqVmf8IpYD+ObMFjyR1dTjr01LB8p0njl65/BlH\n\teNPODkScpXOlsTb47hUHGdTAtiRlunnIXYxeft0AphWWCNs9zewKSVIpue92stCMim9u\n\tb3ZRU+Aier/M5z5n/+PSGGcvwG4PGViKoX8Vvrrl30ZclqC3FQPv4gOIY5pViRjiNdUx\n\tzJUA==","X-Gm-Message-State":"AMCzsaWjQXSEqxit6m8nmuOGYN1JeVujhajrjc3IES49yjw7v4yGswZw\n\t5gRidRUKPIXKU57yVQ7pqEkDVOCe","X-Google-Smtp-Source":"ABhQp+TpY49czupj4s8KNP+DMepaX5QPqCRUinVF4NVki+r13FxR5EHh5EccVvOoBnFhzkfFf1s5Uw==","X-Received":"by 10.99.4.209 with SMTP id 200mr9795374pge.123.1508689327660;\n\tSun, 22 Oct 2017 09:22:07 -0700 (PDT)","Subject":"Re: [PATCH v2 4/4] watchdog: aspeed: Move init to arch_initcall","To":"Andrew Jeffery , Joel Stanley ","References":"<20170920053020.6860-1-andrew@aj.id.au>\n\t<20170920053020.6860-5-andrew@aj.id.au>\n\t\n\t<1508240158.24322.16.camel@aj.id.au>","From":"Guenter Roeck ","Message-ID":"","Date":"Sun, 22 Oct 2017 09:22:05 -0700","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.4.0","MIME-Version":"1.0","In-Reply-To":"<1508240158.24322.16.camel@aj.id.au>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-BeenThere":"openbmc@lists.ozlabs.org","X-Mailman-Version":"2.1.24","Precedence":"list","List-Id":"Development list for OpenBMC ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Ryan Chen , linux-watchdog@vger.kernel.org,\n\tlinux-aspeed@lists.ozlabs.org,\n\tOpenBMC Maillist , \n\tLinux Kernel Mailing List ,\n\tWim Van Sebroeck ","Errors-To":"openbmc-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org","Sender":"\"openbmc\"\n\t"}}]