Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/816014/?format=api
{ "id": 816014, "url": "http://patchwork.ozlabs.org/api/patches/816014/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-aspeed/patch/20170920053020.6860-2-andrew@aj.id.au/", "project": { "id": 57, "url": "http://patchwork.ozlabs.org/api/projects/57/?format=api", "name": "Linux ASPEED SoC development", "link_name": "linux-aspeed", "list_id": "linux-aspeed.lists.ozlabs.org", "list_email": "linux-aspeed@lists.ozlabs.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170920053020.6860-2-andrew@aj.id.au>", "list_archive_url": null, "date": "2017-09-20T05:30:17", "name": "[v2,1/4] watchdog: aspeed: Retain watchdog enabled state", "commit_ref": null, "pull_url": null, "state": "not-applicable", "archived": true, "hash": "84aee1c60bfed5fe8231bc947a045ef04ebdf45c", "submitter": { "id": 68332, "url": "http://patchwork.ozlabs.org/api/people/68332/?format=api", "name": "Andrew Jeffery", "email": "andrew@aj.id.au" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-aspeed/patch/20170920053020.6860-2-andrew@aj.id.au/mbox/", "series": [ { "id": 4019, "url": "http://patchwork.ozlabs.org/api/series/4019/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-aspeed/list/?series=4019", "date": "2017-09-20T05:30:16", "name": "watchdog: aspeed: Retain enabled state and move to arch_initcall", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/4019/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/816014/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/816014/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<linux-aspeed-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "linux-aspeed@lists.ozlabs.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "linux-aspeed@lists.ozlabs.org" ], "Received": [ "from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xxpJf6fJXz9s82\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 20 Sep 2017 15:31:46 +1000 (AEST)", "from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xxpJd40StzDqYR\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 20 Sep 2017 15:31:45 +1000 (AEST)", "from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com\n\t[66.111.4.25])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xxpHm2njvzDqBd;\n\tWed, 20 Sep 2017 15:31:00 +1000 (AEST)", "from compute4.internal (compute4.nyi.internal [10.202.2.44])\n\tby mailout.nyi.internal (Postfix) with ESMTP id 4E9BE20E37;\n\tWed, 20 Sep 2017 01:30:58 -0400 (EDT)", "from frontend1 ([10.202.2.160])\n\tby compute4.internal (MEProxy); Wed, 20 Sep 2017 01:30:58 -0400", "from keelia.au.ibm.com (unknown [203.0.153.9])\n\tby mail.messagingengine.com (Postfix) with ESMTPA id A36E37F9CF;\n\tWed, 20 Sep 2017 01:30:54 -0400 (EDT)" ], "Authentication-Results": [ "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=aj.id.au header.i=@aj.id.au header.b=\"q94IezjA\";\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=messagingengine.com\n\theader.i=@messagingengine.com header.b=\"o4XFkDsh\"; \n\tdkim-atps=neutral", "lists.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=aj.id.au header.i=@aj.id.au header.b=\"q94IezjA\";\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=messagingengine.com\n\theader.i=@messagingengine.com header.b=\"o4XFkDsh\"; \n\tdkim-atps=neutral", "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=aj.id.au\n\t(client-ip=66.111.4.25; helo=out1-smtp.messagingengine.com;\n\tenvelope-from=andrew@aj.id.au; receiver=<UNKNOWN>)", "lists.ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=aj.id.au header.i=@aj.id.au header.b=\"q94IezjA\";\n\tdkim=pass (2048-bit key;\n\tunprotected) header.d=messagingengine.com\n\theader.i=@messagingengine.com\n\theader.b=\"o4XFkDsh\"; dkim-atps=neutral" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=aj.id.au; h=cc\n\t:date:from:in-reply-to:message-id:references:subject:to\n\t:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s=fm1; bh=d2sif+\n\ttrFNrk8EaEqbpPgDd9xOzrgIN5Xv3evoe1a/k=; b=q94IezjAjwE3njmPLO0FrV\n\tEsLthd1Q5zlWYmJ1pQohwvRkvvDKiGBv8W1UojYnIlx9hiYEk37FAUkzxGFLNM4w\n\t2cqAg1AL3gZgWQK61AIkCYbG94D/KUyjL1fAJPc7TWEqtyjKtW/GGbU2gQnwckgr\n\ta0g1hOcGkglgWHgl/Oxh7m4jSJFriOwRqOh1xiZfw+NlF/q09F96d2wHuDLPhrp0\n\trW0VLE7rr9//LtixJcO0KxfNmbrp3vhGruHMQroYarQ6r2UzYTu9jqWSerrfjb8r\n\twUOdQq8BlTj/+dy6MSsjWubnBVl4l5jgKjizOAfloQGzYD+aeGl5mqnFDecFp8MA\n\t==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n\tmessagingengine.com; h=cc:date:from:in-reply-to:message-id\n\t:references:subject:to:x-me-sender:x-me-sender:x-sasl-enc\n\t:x-sasl-enc; s=fm1; bh=d2sif+trFNrk8EaEqbpPgDd9xOzrgIN5Xv3evoe1a\n\t/k=; b=o4XFkDshzKouFLv4gcFNc88XNNFc6lbSzqXGKwQ+UTbGGd0cUH/qEcbr/\n\tlhTtZjqQlZpBfR9bKm3Q7EIx9bBiM0qJwGJkMIaPb5aKM1zUQbEe+ExtnAx5f95d\n\t7lsAeCEg80a/3uAaCec/dL+ppxvihSjxYO/XZ5c+MiettHbW9+85Is7ltJnvlJ1S\n\tQ+p/kB7ALQU7fWnHp1O+uGYRMBYdiovozpeAU7htHIvt/hyo7MY1T9GfkOe43VQ2\n\tHSRg+605rwqEADwcIttJnDPoK0QFn1L0FEXRcgxJqHO+GeroYfVDumzGfsFkzX7a\n\tt7JfaERTzrIVwZDNBJ1IUdu9P/9Eg==" ], "X-ME-Sender": "<xms:Ev3BWa4bfLVYaXiBhiTrThe3TYYebzcdOAOeu6vgTY5rNHeCgOQyHw>", "X-Sasl-enc": "NodKJXea2snAQpmkMaO7EJsmdCAuUhy/D70hj61KMedz 1505885457", "From": "Andrew Jeffery <andrew@aj.id.au>", "To": "linux-watchdog@vger.kernel.org", "Subject": "[PATCH v2 1/4] watchdog: aspeed: Retain watchdog enabled state", "Date": "Wed, 20 Sep 2017 15:00:17 +0930", "Message-Id": "<20170920053020.6860-2-andrew@aj.id.au>", "X-Mailer": "git-send-email 2.11.0", "In-Reply-To": "<20170920053020.6860-1-andrew@aj.id.au>", "References": "<20170920053020.6860-1-andrew@aj.id.au>", "X-BeenThere": "linux-aspeed@lists.ozlabs.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Linux ASPEED SoC development <linux-aspeed.lists.ozlabs.org>", "List-Unsubscribe": "<https://lists.ozlabs.org/options/linux-aspeed>,\n\t<mailto:linux-aspeed-request@lists.ozlabs.org?subject=unsubscribe>", "List-Archive": "<http://lists.ozlabs.org/pipermail/linux-aspeed/>", "List-Post": "<mailto:linux-aspeed@lists.ozlabs.org>", "List-Help": "<mailto:linux-aspeed-request@lists.ozlabs.org?subject=help>", "List-Subscribe": "<https://lists.ozlabs.org/listinfo/linux-aspeed>,\n\t<mailto:linux-aspeed-request@lists.ozlabs.org?subject=subscribe>", "Cc": "ryan_chen@aspeedtech.com, linux-aspeed@lists.ozlabs.org,\n\topenbmc@lists.ozlabs.org, linux-kernel@vger.kernel.org, wim@iguana.be,\n\tlinux@roeck-us.net", "Errors-To": "linux-aspeed-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org", "Sender": "\"Linux-aspeed\"\n\t<linux-aspeed-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org>" }, "content": "An unintended post-condition of probe() is that the watchdog is\ndisabled. This behaviour was introduced by an unnecessary write to the\ncontrol register to configure the hardware based on the devicetree. The\nwrite is unnecessary because the cached control value that is\nmanipulated by the code parsing the devicetree is eventually written by\naspeed_wdt_enable(), which is when we care how the control register\nshould be configured.\n\nRemove the write to restore expected behaviour.\n\nFixes: b7f0b8ad25f3 (\"drivers/watchdog: ASPEED reference dev tree properties for config\")\nSigned-off-by: Andrew Jeffery <andrew@aj.id.au>\n---\n drivers/watchdog/aspeed_wdt.c | 8 ++++++--\n 1 file changed, 6 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/watchdog/aspeed_wdt.c b/drivers/watchdog/aspeed_wdt.c\nindex 79cc766cd30f..6c6dd3f4c48d 100644\n--- a/drivers/watchdog/aspeed_wdt.c\n+++ b/drivers/watchdog/aspeed_wdt.c\n@@ -243,9 +243,13 @@ static int aspeed_wdt_probe(struct platform_device *pdev)\n \tif (of_property_read_bool(np, \"aspeed,external-signal\"))\n \t\twdt->ctrl |= WDT_CTRL_WDT_EXT;\n \n-\twritel(wdt->ctrl, wdt->base + WDT_CTRL);\n-\n \tif (readl(wdt->base + WDT_CTRL) & WDT_CTRL_ENABLE) {\n+\t\t/*\n+\t\t * The watchdog is running, but invoke aspeed_wdt_start() to\n+\t\t * write wdt->ctrl to WDT_CTRL to ensure the watchdog's\n+\t\t * configuration conforms to the driver's expectations.\n+\t\t * Primarily, ensure we're using the 1MHz clock source.\n+\t\t */\n \t\taspeed_wdt_start(&wdt->wdd);\n \t\tset_bit(WDOG_HW_RUNNING, &wdt->wdd.status);\n \t}\n", "prefixes": [ "v2", "1/4" ] }