Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 815182,
    "url": "http://patchwork.ozlabs.org/api/patches/815182/?format=api",
    "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/20170918214128.27896-4-f.fainelli@gmail.com/",
    "project": {
        "id": 7,
        "url": "http://patchwork.ozlabs.org/api/projects/7/?format=api",
        "name": "Linux network development",
        "link_name": "netdev",
        "list_id": "netdev.vger.kernel.org",
        "list_email": "netdev@vger.kernel.org",
        "web_url": null,
        "scm_url": null,
        "webscm_url": null,
        "list_archive_url": "",
        "list_archive_url_format": "",
        "commit_url_format": ""
    },
    "msgid": "<20170918214128.27896-4-f.fainelli@gmail.com>",
    "list_archive_url": null,
    "date": "2017-09-18T21:41:19",
    "name": "[net-next,03/12] net: dsa: b53: Defer port enabling to calling port_enable",
    "commit_ref": null,
    "pull_url": null,
    "state": "changes-requested",
    "archived": true,
    "hash": "a6b88b967fa843251221aa9cd5bcb574e1904e1f",
    "submitter": {
        "id": 2800,
        "url": "http://patchwork.ozlabs.org/api/people/2800/?format=api",
        "name": "Florian Fainelli",
        "email": "f.fainelli@gmail.com"
    },
    "delegate": {
        "id": 34,
        "url": "http://patchwork.ozlabs.org/api/users/34/?format=api",
        "username": "davem",
        "first_name": "David",
        "last_name": "Miller",
        "email": "davem@davemloft.net"
    },
    "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/20170918214128.27896-4-f.fainelli@gmail.com/mbox/",
    "series": [
        {
            "id": 3739,
            "url": "http://patchwork.ozlabs.org/api/series/3739/?format=api",
            "web_url": "http://patchwork.ozlabs.org/project/netdev/list/?series=3739",
            "date": "2017-09-18T21:41:16",
            "name": "net: dsa: b53/bcm_sf2 cleanups",
            "version": 1,
            "mbox": "http://patchwork.ozlabs.org/series/3739/mbox/"
        }
    ],
    "comments": "http://patchwork.ozlabs.org/api/patches/815182/comments/",
    "check": "pending",
    "checks": "http://patchwork.ozlabs.org/api/patches/815182/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<netdev-owner@vger.kernel.org>",
        "X-Original-To": "patchwork-incoming@ozlabs.org",
        "Delivered-To": "patchwork-incoming@ozlabs.org",
        "Authentication-Results": [
            "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)",
            "ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"Ndzh1GQV\"; dkim-atps=neutral"
        ],
        "Received": [
            "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xwzws19cFz9ryv\n\tfor <patchwork-incoming@ozlabs.org>;\n\tTue, 19 Sep 2017 07:41:49 +1000 (AEST)",
            "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751497AbdIRVlr (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tMon, 18 Sep 2017 17:41:47 -0400",
            "from mail-wr0-f196.google.com ([209.85.128.196]:35726 \"EHLO\n\tmail-wr0-f196.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751057AbdIRVlq (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Mon, 18 Sep 2017 17:41:46 -0400",
            "by mail-wr0-f196.google.com with SMTP id n64so1141650wrb.2\n\tfor <netdev@vger.kernel.org>; Mon, 18 Sep 2017 14:41:45 -0700 (PDT)",
            "from fainelli-desktop.broadcom.com ([192.19.255.250])\n\tby smtp.gmail.com with ESMTPSA id\n\te34sm9242761wre.15.2017.09.18.14.41.41\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tMon, 18 Sep 2017 14:41:43 -0700 (PDT)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=i+cf+nOKttQ4IQa4MEVfKAYPU7XBFNiI0Spyajf4HUI=;\n\tb=Ndzh1GQVJdi5Ct/Rgyu0ikqr1UgE8a2sLnNgX/mgb14qja9WIyQfni9crIloNQAfQl\n\twRlik/5O2Wcbg1kgDz6qYLQpOHty5+ztre3JphFnuv9SkDyrliFC14nuqxFkDg9ccMz8\n\tMleo+ilraxbozIo2qLL2MLHHZGZGz4adlZEcWg0IXAwwZJYypXPppSvX89+G/L+pKRBy\n\tbMx8foFPI6sb62Tg2x76cuzWhRHagNaWH7ejkGDjjh1LvSo0lNlrKqYl2ShZEGXoKZ2d\n\tdIqJx3UIdw5or0mIEYi4EFObV9JaP7mmEXvQKc77Ry/NOOxG54wMDselSk47nAKm5N8L\n\t2LyA==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=i+cf+nOKttQ4IQa4MEVfKAYPU7XBFNiI0Spyajf4HUI=;\n\tb=hXg/9xKLaY+2zLAq6yXw1t1SFGz0drVJ0KjVv81AzG4SKuNY98gpGWFkaXjNSH4U0M\n\t++x53kkClSqWH9FycdsTLKOj9bCFUUNjRFgXiyT0NpqodPh1uLpVrwEZXbne0d2tLT3b\n\t5KYa+JG015QHJFUhgl4WXj1UHGehVLHzTTtMCT05UN6TgPD0j7NgJrDaq1jDYyydqikr\n\tZn3l6tuxKRgKXRCAaEuAgJnhAzCw6DCntndM2aT0NTw3/hUz99TcnK2gsfaaQ8Uq/qCg\n\toI7hBnJ/7kUwpH0bup08PKxckUGxs3SFcaRiXUwY3iIDQ1VbdO5rWF/wdI1CNzZ0wAa8\n\tbIAg==",
        "X-Gm-Message-State": "AHPjjUjPoJ8ovD9vqaZiwKbb4rA/7E6uiQW15Zr1k/LtzWplLN+ZBENY\n\t4JAvg5hIf7qKZegd25o=",
        "X-Google-Smtp-Source": "AOwi7QAJMigjRgvZPZJnex7xDL+ps0jenK9Am9CYdYtKTqjPRfXxUH5FG4+wBgJQ/umL0Q7p8DTPzg==",
        "X-Received": "by 10.223.178.193 with SMTP id g59mr18244204wrd.0.1505770904761; \n\tMon, 18 Sep 2017 14:41:44 -0700 (PDT)",
        "From": "Florian Fainelli <f.fainelli@gmail.com>",
        "To": "netdev@vger.kernel.org",
        "Cc": "davem@davemloft.net, andrew@lunn.ch, vivien.didelot@savoirfairelinux.com,\n\tFlorian Fainelli <f.fainelli@gmail.com>",
        "Subject": "[PATCH net-next 03/12] net: dsa: b53: Defer port enabling to\n\tcalling port_enable",
        "Date": "Mon, 18 Sep 2017 14:41:19 -0700",
        "Message-Id": "<20170918214128.27896-4-f.fainelli@gmail.com>",
        "X-Mailer": "git-send-email 2.9.3",
        "In-Reply-To": "<20170918214128.27896-1-f.fainelli@gmail.com>",
        "References": "<20170918214128.27896-1-f.fainelli@gmail.com>",
        "Sender": "netdev-owner@vger.kernel.org",
        "Precedence": "bulk",
        "List-ID": "<netdev.vger.kernel.org>",
        "X-Mailing-List": "netdev@vger.kernel.org"
    },
    "content": "There is no need to configure the enabled ports once in b53_setup() and then a\nsecond time around when dsa_switch_ops::port_enable is called, just do it when\nport_enable is called which is better in terms of power consumption and\ncorrectness.\n\nSigned-off-by: Florian Fainelli <f.fainelli@gmail.com>\n---\n drivers/net/dsa/b53/b53_common.c | 9 +++++----\n 1 file changed, 5 insertions(+), 4 deletions(-)",
    "diff": "diff --git a/drivers/net/dsa/b53/b53_common.c b/drivers/net/dsa/b53/b53_common.c\nindex d8bc54cfcfbe..3297af6aab8a 100644\n--- a/drivers/net/dsa/b53/b53_common.c\n+++ b/drivers/net/dsa/b53/b53_common.c\n@@ -815,12 +815,13 @@ static int b53_setup(struct dsa_switch *ds)\n \tif (ret)\n \t\tdev_err(ds->dev, \"failed to apply configuration\\n\");\n \n+\t/* Configure IMP/CPU port, disable unused ports. Enabled\n+\t * ports will be configured with .port_enable\n+\t */\n \tfor (port = 0; port < dev->num_ports; port++) {\n-\t\tif (BIT(port) & ds->enabled_port_mask)\n-\t\t\tb53_enable_port(ds, port, NULL);\n-\t\telse if (dsa_is_cpu_port(ds, port))\n+\t\tif (dsa_is_cpu_port(ds, port))\n \t\t\tb53_enable_cpu_port(dev, port);\n-\t\telse\n+\t\telse if (!(BIT(port) & ds->enabled_port_mask))\n \t\t\tb53_disable_port(ds, port, NULL);\n \t}\n \n",
    "prefixes": [
        "net-next",
        "03/12"
    ]
}