[{"id":1770537,"web_url":"http://patchwork.ozlabs.org/comment/1770537/","msgid":"<87377j3c8h.fsf@weeman.i-did-not-set--mail-host-address--so-tickle-me>","list_archive_url":null,"date":"2017-09-18T21:53:18","subject":"Re: [PATCH net-next 03/12] net: dsa: b53: Defer port enabling to\n\tcalling port_enable","submitter":{"id":15889,"url":"http://patchwork.ozlabs.org/api/people/15889/","name":"Vivien Didelot","email":"vivien.didelot@savoirfairelinux.com"},"content":"Florian Fainelli <f.fainelli@gmail.com> writes:\n\n> There is no need to configure the enabled ports once in b53_setup() and then a\n> second time around when dsa_switch_ops::port_enable is called, just do it when\n> port_enable is called which is better in terms of power consumption and\n> correctness.\n>\n> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>\n\nGreat, my next step is to move up the ports enabling/disabling withing\nDSA core. This patch helps going in that direction, thanks.\n\nReviewed-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>","headers":{"Return-Path":"<netdev-owner@vger.kernel.org>","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xx0GF2Kx9z9s7G\n\tfor <patchwork-incoming@ozlabs.org>;\n\tTue, 19 Sep 2017 07:56:53 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751593AbdIRV4u (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tMon, 18 Sep 2017 17:56:50 -0400","from mail.savoirfairelinux.com ([208.88.110.44]:34584 \"EHLO\n\tmail.savoirfairelinux.com\" rhost-flags-OK-OK-OK-OK) by\n\tvger.kernel.org with ESMTP id S1751336AbdIRV4u (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Mon, 18 Sep 2017 17:56:50 -0400","from localhost (localhost [127.0.0.1])\n\tby mail.savoirfairelinux.com (Postfix) with ESMTP id 2DA1E9C19D8;\n\tMon, 18 Sep 2017 17:56:49 -0400 (EDT)","from mail.savoirfairelinux.com ([127.0.0.1])\n\tby localhost (mail.savoirfairelinux.com [127.0.0.1]) (amavisd-new,\n\tport 10032)\n\twith ESMTP id B-dZN04YWQb8; Mon, 18 Sep 2017 17:56:48 -0400 (EDT)","from localhost (localhost [127.0.0.1])\n\tby mail.savoirfairelinux.com (Postfix) with ESMTP id BB3DD9C2C5F;\n\tMon, 18 Sep 2017 17:56:48 -0400 (EDT)","from mail.savoirfairelinux.com ([127.0.0.1])\n\tby localhost (mail.savoirfairelinux.com [127.0.0.1]) (amavisd-new,\n\tport 10026)\n\twith ESMTP id RsFx7e9wfiNS; Mon, 18 Sep 2017 17:56:48 -0400 (EDT)","from localhost (unknown [192.168.49.104])\n\tby mail.savoirfairelinux.com (Postfix) with ESMTPSA id 903ED9C19D8;\n\tMon, 18 Sep 2017 17:56:48 -0400 (EDT)"],"X-Virus-Scanned":"amavisd-new at mail.savoirfairelinux.com","From":"Vivien Didelot <vivien.didelot@savoirfairelinux.com>","To":"Florian Fainelli <f.fainelli@gmail.com>, netdev@vger.kernel.org","Cc":"davem@davemloft.net, andrew@lunn.ch,\n\tFlorian Fainelli <f.fainelli@gmail.com>","Subject":"Re: [PATCH net-next 03/12] net: dsa: b53: Defer port enabling to\n\tcalling port_enable","In-Reply-To":"<20170918214128.27896-4-f.fainelli@gmail.com>","References":"<20170918214128.27896-1-f.fainelli@gmail.com>\n\t<20170918214128.27896-4-f.fainelli@gmail.com>","Date":"Mon, 18 Sep 2017 17:53:18 -0400","Message-ID":"<87377j3c8h.fsf@weeman.i-did-not-set--mail-host-address--so-tickle-me>","MIME-Version":"1.0","Content-Type":"text/plain","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<netdev.vger.kernel.org>","X-Mailing-List":"netdev@vger.kernel.org"}}]