Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/814626/?format=api
{ "id": 814626, "url": "http://patchwork.ozlabs.org/api/patches/814626/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-i2c/patch/20170917093906.16325-7-linus.walleij@linaro.org/", "project": { "id": 35, "url": "http://patchwork.ozlabs.org/api/projects/35/?format=api", "name": "Linux I2C development", "link_name": "linux-i2c", "list_id": "linux-i2c.vger.kernel.org", "list_email": "linux-i2c@vger.kernel.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170917093906.16325-7-linus.walleij@linaro.org>", "list_archive_url": null, "date": "2017-09-17T09:39:05", "name": "[6/7] dt-bindings: i2c: i2c-gpio: Add support for named gpios", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "841001941c513548f1786a0ec360917c38904f74", "submitter": { "id": 7055, "url": "http://patchwork.ozlabs.org/api/people/7055/?format=api", "name": "Linus Walleij", "email": "linus.walleij@linaro.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-i2c/patch/20170917093906.16325-7-linus.walleij@linaro.org/mbox/", "series": [ { "id": 3497, "url": "http://patchwork.ozlabs.org/api/series/3497/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-i2c/list/?series=3497", "date": "2017-09-17T09:38:59", "name": "I2C GPIO to use gpiolibs open drain", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/3497/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/814626/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/814626/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<linux-i2c-owner@vger.kernel.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-i2c-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"EJcODZSd\"; dkim-atps=neutral" ], "Received": [ "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xw3yq3xpRz9sPs\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSun, 17 Sep 2017 19:40:19 +1000 (AEST)", "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1750862AbdIQJkR (ORCPT <rfc822;incoming@patchwork.ozlabs.org>);\n\tSun, 17 Sep 2017 05:40:17 -0400", "from mail-lf0-f44.google.com ([209.85.215.44]:50536 \"EHLO\n\tmail-lf0-f44.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750995AbdIQJkQ (ORCPT\n\t<rfc822; linux-i2c@vger.kernel.org>); Sun, 17 Sep 2017 05:40:16 -0400", "by mail-lf0-f44.google.com with SMTP id d4so5626828lfj.7\n\tfor <linux-i2c@vger.kernel.org>; Sun, 17 Sep 2017 02:40:15 -0700 (PDT)", "from fabina.bredbandsbolaget.se\n\t(c-2209e055.014-348-6c756e10.cust.bredbandsbolaget.se.\n\t[85.224.9.34]) by smtp.gmail.com with ESMTPSA id\n\tt84sm974559lfi.21.2017.09.17.02.40.12\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tSun, 17 Sep 2017 02:40:13 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=gCUiTTfNN4A0Ks5ICP11L6908VWob6q3aNpZBxzMr2o=;\n\tb=EJcODZSdpg3anuolr3cBANwdDM8I3E5iGHNAV6io8KZ76ctPs1N8pDHUd5hSGKBLmS\n\tPWtS4Z0u2rQ02mW/KebTOT15ijAUtZAR325dmSS6xwD2tQcKoSAwgvypytV92QiQmxTf\n\tdG62zACB18ekGsRb0Lruib8UTN498A80hzV68=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=gCUiTTfNN4A0Ks5ICP11L6908VWob6q3aNpZBxzMr2o=;\n\tb=ZuBt8yWP7i5uSBVBVOCfXyl3imIjOw17tbIzBCMvwSVE6ghNvpyDXEfE7JmnLMVcTe\n\tCkuwTNjiiT3PX4Fx7ODpaED1WG9vMuFjQg/i4Pyhd88X2rFD72JZ/9yDr81m0OzuYoAX\n\tg6oTR4XP0qIpo/KDvU/h6gVqey2+wTfPUDJC4iITraxh8+U9HnHczzXvkppEAV6wExeP\n\t5M2q/ixKNC95ajty26VWx7MOVK2QsesfPl9MkZNJUSUtoX5Tv9sCqFrkc0x30IvBxTNx\n\teKCSJs1jKGAnq+wE//u5Fy1PgJizNRVprC/E0ipQ8d302qbAeprQJIx/BwArrbnPSu4Y\n\tKe8g==", "X-Gm-Message-State": "AHPjjUj0LGqJhwUoVHxFmqDT4c+j5TbbISgmuOpQQ4QhUh8qf+FCRsFe\n\t8tpzNF0+v5GEHAdH", "X-Google-Smtp-Source": "AOwi7QDWbRvs7Toyp6taphGqkvNt0d7MrNzgbP/livSNkIwozyUchtApTPh4f+O29jWcgjEgCNNigg==", "X-Received": "by 10.25.217.213 with SMTP id s82mr2511208lfi.176.1505641214477; \n\tSun, 17 Sep 2017 02:40:14 -0700 (PDT)", "From": "Linus Walleij <linus.walleij@linaro.org>", "To": "Wolfram Sang <wsa@the-dreams.de>, linux-i2c@vger.kernel.org", "Cc": "linux-arm-kernel@lists.infradead.org, linux-mips@linux-mips.org,\n\tadi-buildroot-devel@lists.sourceforge.net,\n\tGeert Uytterhoeven <geert@linux-m68k.org>,\n\tgeert.renesas@glider.be, devicetree@vger.kernel.org,\n\tGeert Uytterhoeven <geert+renesas@glider.be>,\n\tLinus Walleij <linus.walleij@linaro.org>", "Subject": "[PATCH 6/7] dt-bindings: i2c: i2c-gpio: Add support for named gpios", "Date": "Sun, 17 Sep 2017 11:39:05 +0200", "Message-Id": "<20170917093906.16325-7-linus.walleij@linaro.org>", "X-Mailer": "git-send-email 2.13.5", "In-Reply-To": "<20170917093906.16325-1-linus.walleij@linaro.org>", "References": "<20170917093906.16325-1-linus.walleij@linaro.org>", "Sender": "linux-i2c-owner@vger.kernel.org", "Precedence": "bulk", "List-ID": "<linux-i2c.vger.kernel.org>", "X-Mailing-List": "linux-i2c@vger.kernel.org" }, "content": "From: Geert Uytterhoeven <geert+renesas () glider ! be>\n\nThe current i2c-gpio DT bindings use a single unnamed \"gpios\" property\nto refer to the SDA and SCL signal lines by index. This is error-prone\nfor the casual DT writer and reviewer, as one has to look up the order\nin the DT bindings.\n\nFix this by amending the DT bindings to use two separate named gpios\nproperties, and deprecate the old unnamed variant.\n\nTake this opportunity to clearly deprecate the \"i2c-gpio,sda-open-drain\"\nand \"i2c-gpio,scl-open-drain\" flags as well. The commit describes\nin detail what these flags actually mean, and why they should not be\nused in new device trees.\n\nCc: devicetree@vger.kernel.org\nSigned-off-by: Geert Uytterhoeven <geert+renesas@glider.be>\n[Augmented to what I and Rob would like]\nSigned-off-by: Linus Walleij <linus.walleij@linaro.org>\n---\nChangeLog v1->v2:\n- Create a special section for the deprecated bindings\n- Also deprecate the open drain bool properties\n- Update the example to use the new style of bindings\n---\n Documentation/devicetree/bindings/i2c/i2c-gpio.txt | 32 ++++++++++++++++------\n 1 file changed, 23 insertions(+), 9 deletions(-)", "diff": "diff --git a/Documentation/devicetree/bindings/i2c/i2c-gpio.txt b/Documentation/devicetree/bindings/i2c/i2c-gpio.txt\nindex 4f8ec947c6bd..38a05562d1d2 100644\n--- a/Documentation/devicetree/bindings/i2c/i2c-gpio.txt\n+++ b/Documentation/devicetree/bindings/i2c/i2c-gpio.txt\n@@ -2,25 +2,39 @@ Device-Tree bindings for i2c gpio driver\n \n Required properties:\n \t- compatible = \"i2c-gpio\";\n-\t- gpios: sda and scl gpio\n-\n+\t- sda-gpios: gpio used for the sda signal, this should be flagged as\n+\t active high using open drain with (GPIO_ACTIVE_HIGH|GPIO_OPEN_DRAIN)\n+\t from <dt-bindings/gpio/gpio.h> since the signal is by definition\n+\t open drain.\n+\t- scl-gpios: gpio used for the scl signal, this should be flagged as\n+\t active high using open drain with (GPIO_ACTIVE_HIGH|GPIO_OPEN_DRAIN)\n+\t from <dt-bindings/gpio/gpio.h> since the signal is by definition\n+\t open drain.\n \n Optional properties:\n-\t- i2c-gpio,sda-open-drain: sda as open drain\n-\t- i2c-gpio,scl-open-drain: scl as open drain\n \t- i2c-gpio,scl-output-only: scl as output only\n \t- i2c-gpio,delay-us: delay between GPIO operations (may depend on each platform)\n \t- i2c-gpio,timeout-ms: timeout to get data\n \n+Deprecated properties, do not use in new device tree sources:\n+\t- gpios: sda and scl gpio, alternative for {sda,scl}-gpios\n+\t- i2c-gpio,sda-open-drain: this means that something outside of our\n+\t control has put the GPIO line used for SDA into open drain mode, and\n+\t that something is not the GPIO chip. It is essentially an\n+\t inconsistency flag.\n+\t- i2c-gpio,scl-open-drain: this means that something outside of our\n+\t control has put the GPIO line used for SCL into open drain mode, and\n+\t that something is not the GPIO chip. It is essentially an\n+\t inconsistency flag.\n+\n Example nodes:\n \n+#include <dt-bindings/gpio/gpio.h>\n+\n i2c@0 {\n \tcompatible = \"i2c-gpio\";\n-\tgpios = <&pioA 23 0 /* sda */\n-\t\t &pioA 24 0 /* scl */\n-\t\t>;\n-\ti2c-gpio,sda-open-drain;\n-\ti2c-gpio,scl-open-drain;\n+\tsda-gpios = <&pioA 23 (GPIO_ACTIVE_HIGH|GPIO_OPEN_DRAIN)>;\n+\tscl-gpios = <&pioA 24 (GPIO_ACTIVE_HIGH|GPIO_OPEN_DRAIN)>;\n \ti2c-gpio,delay-us = <2>;\t/* ~100 kHz */\n \t#address-cells = <1>;\n \t#size-cells = <0>;\n", "prefixes": [ "6/7" ] }