[{"id":1772210,"web_url":"http://patchwork.ozlabs.org/comment/1772210/","msgid":"<20170920205304.shkguzlqco3m6weu@rob-hp-laptop>","list_archive_url":null,"date":"2017-09-20T20:53:04","subject":"Re: [PATCH 6/7] dt-bindings: i2c: i2c-gpio: Add support for named\n\tgpios","submitter":{"id":62529,"url":"http://patchwork.ozlabs.org/api/people/62529/","name":"Rob Herring (Arm)","email":"robh@kernel.org"},"content":"On Sun, Sep 17, 2017 at 11:39:05AM +0200, Linus Walleij wrote:\n> From: Geert Uytterhoeven <geert+renesas () glider ! be>\n> \n> The current i2c-gpio DT bindings use a single unnamed \"gpios\" property\n> to refer to the SDA and SCL signal lines by index.  This is error-prone\n> for the casual DT writer and reviewer, as one has to look up the order\n> in the DT bindings.\n> \n> Fix this by amending the DT bindings to use two separate named gpios\n> properties, and deprecate the old unnamed variant.\n> \n> Take this opportunity to clearly deprecate the \"i2c-gpio,sda-open-drain\"\n> and \"i2c-gpio,scl-open-drain\" flags as well. The commit describes\n> in detail what these flags actually mean, and why they should not be\n> used in new device trees.\n> \n> Cc: devicetree@vger.kernel.org\n> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>\n> [Augmented to what I and Rob would like]\n> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>\n> ---\n> ChangeLog v1->v2:\n> - Create a special section for the deprecated bindings\n> - Also deprecate the open drain bool properties\n> - Update the example to use the new style of bindings\n> ---\n>  Documentation/devicetree/bindings/i2c/i2c-gpio.txt | 32 ++++++++++++++++------\n>  1 file changed, 23 insertions(+), 9 deletions(-)\n\nAcked-by: Rob Herring <robh@kernel.org>","headers":{"Return-Path":"<linux-i2c-owner@vger.kernel.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-i2c-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xyBnm4rFzz9sNr\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 21 Sep 2017 06:54:52 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751594AbdITUys (ORCPT <rfc822;incoming@patchwork.ozlabs.org>);\n\tWed, 20 Sep 2017 16:54:48 -0400","from mail-pg0-f67.google.com ([74.125.83.67]:38751 \"EHLO\n\tmail-pg0-f67.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751678AbdITUxG (ORCPT\n\t<rfc822; linux-i2c@vger.kernel.org>); Wed, 20 Sep 2017 16:53:06 -0400","by mail-pg0-f67.google.com with SMTP id m30so2240404pgn.5;\n\tWed, 20 Sep 2017 13:53:06 -0700 (PDT)","from localhost ([2620:0:1000:fd28:e83d:5428:912b:b325])\n\tby smtp.gmail.com with ESMTPSA id\n\tj1sm8761371pfc.169.2017.09.20.13.53.05\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tWed, 20 Sep 2017 13:53:05 -0700 (PDT)"],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=0lyIskk6H4f0CWizhoe1/vE50IcZAqdd2ajuPiWbZNM=;\n\tb=IBPqyyk3hl2hIaTEU27Bmoog8Jn/gRFxHe7LqBIBrlkx2dNBkhKUbDOW3uMMnEZOD2\n\t9m4+G/WxAZjmISRRLGBnCYa7q3E06NAbuAgOthRWx+9386mqvXpUdKqztdHBR/bYws5m\n\tJwfhZ6pEy2DNvER4WsOs2Cmhbe8HUqjIFsUhzBQ4JkofXIbFETgjx0TyGzdDw/Lnt8Ai\n\tmFKFjb8o2CmJnewp5vb85uf8whrr1Sfl8Y/RTUfbXmvhGu9JLa4abgUTcUzbxPrYYHD5\n\tz5Ma61HbmM6yBhceR3RAVB6etbQacIjbT2BA6pf+hKVnxMeSv7lKn8BfywHVb+7PD8V2\n\tqddg==","X-Gm-Message-State":"AHPjjUjQHQLuWGawKrnWEk0OuajfmYl1LNDaL0tGEpZ2mk43f4/ZyZcO\n\tdNJJkDj5T2Ico8zObbyZuA==","X-Google-Smtp-Source":"AOwi7QA/xK/AQ6JTU/WBmuu/cxX+OYdXdOdR+QUeH+FTTOZ1h4nbJuqCjRkcfKDiNMJ1+rg2OU33VQ==","X-Received":"by 10.99.99.197 with SMTP id x188mr3413376pgb.90.1505940785875; \n\tWed, 20 Sep 2017 13:53:05 -0700 (PDT)","Date":"Wed, 20 Sep 2017 15:53:04 -0500","From":"Rob Herring <robh@kernel.org>","To":"Linus Walleij <linus.walleij@linaro.org>","Cc":"Wolfram Sang <wsa@the-dreams.de>, linux-i2c@vger.kernel.org,\n\tlinux-arm-kernel@lists.infradead.org, linux-mips@linux-mips.org,\n\tadi-buildroot-devel@lists.sourceforge.net,\n\tGeert Uytterhoeven <geert@linux-m68k.org>,\n\tgeert.renesas@glider.be, devicetree@vger.kernel.org,\n\tGeert Uytterhoeven <geert+renesas@glider.be>","Subject":"Re: [PATCH 6/7] dt-bindings: i2c: i2c-gpio: Add support for named\n\tgpios","Message-ID":"<20170920205304.shkguzlqco3m6weu@rob-hp-laptop>","References":"<20170917093906.16325-1-linus.walleij@linaro.org>\n\t<20170917093906.16325-7-linus.walleij@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170917093906.16325-7-linus.walleij@linaro.org>","User-Agent":"NeoMutt/20170113 (1.7.2)","Sender":"linux-i2c-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<linux-i2c.vger.kernel.org>","X-Mailing-List":"linux-i2c@vger.kernel.org"}}]